From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2787441DE03 for ; Mon, 24 Aug 2026 12:55:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787576145; cv=none; b=NR3d6iWS4EmuvbqXYSA0SqUW/1CP+fXl37MHjmqvGlkLpBzQoh7QqM/iXCYhzaUAaMw+eE5SfAlEzc2f1dN2A88orhOtAewbiUMjOpPq+QCMEXhLNn+P7+6lq3touvfpy8gDywkfUdrVPUeGvxWnDLoxrcmEbcKFUwreMZ4wUUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787576145; c=relaxed/simple; bh=pKILCIAN+R1XJIexmr3duPunuNDAf8Haawwh/AnvhFM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i5+Xz+muq3mR5PWqkMsFOGNqW6gK/9NcG9k/il57bm4G/34xHLaAcfi4PR0ANSf1uu6iujMTNhyb3hGL6oVFLMzjsJsEcUyg5AmDORgteULSzpyRaeOLZ6vAfNYp3V7zq8QOarFnrNNq1etdKzDLJbXGTXqN2b/FpilD5VWerfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DcRW/Bzs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A3VCcbHO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DcRW/Bzs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A3VCcbHO" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67OBMdHj3194977 for ; Mon, 24 Aug 2026 12:55:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rOaylOn1lOxDzyU+vOEzZ5eDL2e1rhW0wfVT+oTC0xc=; b=DcRW/BzsWc8h5CCJ tNBRIVKUkj+vKHD6u8gZL3my4n8CVj055G5DarI4DxefZXR2pKYWIW7puazkXQ3K WSjwEJzgPv9/e3i0we7yu6Y6bfcIaubu2e7i5nBP2SXt+9BTewdQfS7KNr62qySQ RU0rtyLRu3i8fX24nogft28/zl8QnThy5iBrKiCdm2A+8pTusVxD8buJlIDE8vg+ m3oLsMOUC7KrLvblK5Tk3ZNpPHfoO2I/1Cfab6bPQ+VmRJyFFWBkud0cauDwwj7V C5YeKhDfj4Vv4orUYbVpXKhjaj3ZnYpREJ6giwUqOzYK6EKjRcPac9OvNQsTNSWh z92obg== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8hjgsack-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Aug 2026 12:55:43 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-97c3746cd0bso40898241.0 for ; Mon, 24 Aug 2026 05:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787576142; x=1788180942; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=rOaylOn1lOxDzyU+vOEzZ5eDL2e1rhW0wfVT+oTC0xc=; b=A3VCcbHOB03Ut+BJD6ri0oDCoK/Z4XTe+6kMUFAjL2T4p2dqMsUwoIabj2f8vJLVnF Lk/Wk4+V2yS8SZ55vUipdXvjGHiX0s4fyb3U8Mai+dYF/XxdTuJgts3xCBtQnYS3nRxT gBqiQ65K6WFHTrMaFiffrPCCaTfQOoEn5uMiY20ySBWUUcfUrKLQpRGfdVepurSeylSP i4MxI4PSAs/Rck7UAE7uPmHcJi6Mr1kYinxtvczTrJibYKwucEUSM1CGgPLCZGY9B+rF j7Bsp8OgAa8GG8QIkvYUc4d+BAFZc77W7YOZfnZVuel6+37fYg3qf1V+wvuKLDV4+W8j DgnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787576142; x=1788180942; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rOaylOn1lOxDzyU+vOEzZ5eDL2e1rhW0wfVT+oTC0xc=; b=fbQJ607kAa5oU7hmwEUyLSq5/XRNruj9rSPz8tYCw6x5JNAA5WiCh/+hASaG02Y+rK nMfSwWssJG3yf9tiKETtIQmm+Mx22eDwnZcpZ5aCHPPXOsNdR2wea0eRW6T3P6x8ebmV 9F8O+LU3g6WzmlddZ7XsVULWbKjkPRLMHXhkel78JjaUWcQdsR/C3APTXUCL3V3YgKQT 8xxJ0JhBkoSYqEQpHPKhKif8hMGNmVAbwlIVE2SFEAlCiMRgYh0UZHnWRKWuyHfO9seE 915EpZtnW9BWhBNuvkpi63f0tbUilaKAd1mfRr31Nwl/jcJYYZdNv7IMudNm9JjOLDct mEdg== X-Forwarded-Encrypted: i=1; AHgh+RpE8quc4FQJ3ao6UxcNiMvpu5rs6AGdTzOZKSyyv/bsvPUv0xV61xVf6JlV7nx41rYzGdhc0mDgdm6rlPU=@vger.kernel.org X-Gm-Message-State: AFuF++k9w0H+BtTPDHYQKxclLxxSnsU6LNOmRHhbfQ0e49m5RhK2gyg4 /J/SGzFK2oRAC2bAjbO0ievN1o1IvWmYR9qFvSDrCMcTkYbbDPjGv3I86Lj3GhcyR0Hlb2NSavV v6AhqtYik09fNGQ5as5N2T9pNI+A3ZtlRwc/NSJQPMfOrnq+pjNnIeWnDqI0PGURAKUM= X-Gm-Gg: AR+sD13bCbYW3j6YCfz2go+Ek0SFL+a+wmJaG3WBB9YbUNLmyBsCsXkSiVgIlD9E/3s Q+XIbCeIc2tf/zwn1Y8vpsUr99tWgEK1dd6ArXUADggbRgNfu+HCBEkmvK/fHGUGmiMEMZn/AvM bPfubvidjjBhY094RqWPdRxEfY2B9nptbQ5Yb0Zb12JOXXUpq4yLgyoU+HjQU8Npj5KPH/gXTSa kUq+tcePTaCOD4geTsnK2oRI18TF1bG3uEB4dal9AZxhgAUkroOkItgRpB0hJ28lE7b6osYQrSl rsbe5ykbsqXRf0k5fT0wK+Upsjh3Iw+PxNgM2AGEpyIspoqE1cPHPzx57zyOmvZvzByn/r8HJcs Do5FvlnGsSNvlmwBOTq16jlRF X-Received: by 2002:a05:6102:f90:b0:779:7d3b:1398 with SMTP id ada2fe7eead31-77a5edee8a5mr3839440137.0.1787576142345; Mon, 24 Aug 2026 05:55:42 -0700 (PDT) X-Received: by 2002:a05:6102:f90:b0:779:7d3b:1398 with SMTP id ada2fe7eead31-77a5edee8a5mr3839432137.0.1787576141876; Mon, 24 Aug 2026 05:55:41 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59dd550bcsm9324844a12.0.2026.08.24.05.55.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 05:55:41 -0700 (PDT) Message-ID: <9f51f316-1303-479d-932a-a688799796bf@oss.qualcomm.com> Date: Mon, 24 Aug 2026 14:55:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] spi: qcom-geni: rename setup_fifo_params() to setup_spi_params() and make it void To: Viken Dadhaniya , Mark Brown Cc: linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260824-spi-qcom-geni-cleanup-setup-fifo-params-v1-1-bdf98ae62953@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260824-spi-qcom-geni-cleanup-setup-fifo-params-v1-1-bdf98ae62953@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI0MDEwOCBTYWx0ZWRfX9cr9vVxFSHo9 5Shk+KVJHstij320F0qpHt+YFxQa0yNSuKDmTh8auvoxsXJYUYZ35DHyUUlW1d6/G8rTxSWFwEe bmfMkVQcLJMGEDOzKYEe8RDUMeKeq2Q= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI0MDEwOCBTYWx0ZWRfX8hhkA6YYLqjJ OdMrnpjCRTVY1hshoCYaNKF3nGJcIsNufLHFF7LFLImcrwE8cDR774hSKrAuH/h/syPGhCN3wsw JGDoF6VtRfYjvrHlHuoqPYEQLpjicZmWLgXqp8FWzGw8sP4+jxuhcvyYKXewIx+CXbz6M8B5W2x gdVm5mGVEgxLGEt7bSd6S/4m8pKulTirzrU9npnBaWRPuXR6a5dbL4tIwjxAcNhOefvMElNaWGJ 9a8fczaG+4X4iYH/QD54RThDaY/buiklpZxL3UTRtqi6jj00Iczt8LkD/uGJm/UBTVRPCzPUDuq zKNa0eF2lrADhGkSKozihwRbcpfM4TbdZOR+qcDiw4YrmwiqJINm/MtvszPDe82miQMwxiKdZgU kSmRBjMKujCqw26tAWLtJCyYrTIUIdrvRGPAz+XY/ZcwWAyyUhOsZJTJ9qWPsan2F+G+Gzg2frE VXpXP+YwKyZkqWcfp2A== X-Proofpoint-ORIG-GUID: HyYMTS7Yn5m61_0CMy_gaf_8AuiKftCR X-Authority-Analysis: v=2.4 cv=CoCPtH4D c=1 sm=1 tr=0 ts=6a8c3f4f cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pkmFLQsO-xIKxrFyL9MA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-GUID: HyYMTS7Yn5m61_0CMy_gaf_8AuiKftCR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-24_03,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608240108 On 8/24/26 12:13 PM, Viken Dadhaniya wrote: > The function always returned 0 and had no error paths, so change its > return type to void. Drop the now-dead ret variable and error check > in spi_geni_prepare_message(). > > setup_fifo_params() is called for both GENI_SE_FIFO and GENI_SE_DMA > modes, so the "fifo" in the name is misleading. Rename it to > setup_spi_params() to better reflect its purpose of configuring SPI > mode parameters (CS, CPHA, CPOL, loopback, LSB-first). > > No functional change. > > Signed-off-by: Viken Dadhaniya > --- Reviewed-by: Konrad Dybcio Konrad