From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932349AbcFBJPS (ORCPT ); Thu, 2 Jun 2016 05:15:18 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:23887 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbcFBJPQ (ORCPT ); Thu, 2 Jun 2016 05:15:16 -0400 Subject: Re: [PATCH] MIPS: pic32mzda: fix linker error for pic32_get_pbclk(). To: Purna Chandra Mandal , References: <1464844821-1581-1-git-send-email-purna.mandal@microchip.com> CC: , Ralf Baechle , Joshua Henderson , Joshua Henderson From: Harvey Hunt Message-ID: <9f53c6f4-735a-1a76-9c62-a4f5f127b1e9@imgtec.com> Date: Thu, 2 Jun 2016 10:15:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464844821-1581-1-git-send-email-purna.mandal@microchip.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.26] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Purna, On 02/06/16 06:20, Purna Chandra Mandal wrote: > Early clock API pic32_get_pbclk() is defined in early_clk.c and > used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't > set, early_clk.c isn't compiled and so a linker error is reported > while referring the API from time.c. Maybe "early_clk.c isn't compiled and so time.c fails to link"? > > Fix it by compiling early_clk.c always. Also sort files in > alphabetical order. > > Cc: Harvey Hunt > Cc: Ralf Baechle > Cc: linux-mips@linux-mips.org > Cc: Joshua Henderson > > Signed-off-by: Purna Chandra Mandal > > --- > > arch/mips/pic32/pic32mzda/Makefile | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile > index 4a4c272..c286496 100644 > --- a/arch/mips/pic32/pic32mzda/Makefile > +++ b/arch/mips/pic32/pic32mzda/Makefile > @@ -2,8 +2,7 @@ > # Joshua Henderson, > # Copyright (C) 2015 Microchip Technology, Inc. All rights reserved. > # > -obj-y := init.o time.o config.o > +obj-y := config.o early_clk.o init.o time.o > > obj-$(CONFIG_EARLY_PRINTK) += early_console.o \ > - early_pin.o \ > - early_clk.o > + early_pin.o > Perhaps add: Reported-by: Harvey Hunt Thanks for fixing this, Reviewed-by: Harvey Hunt Thanks, Harvey