From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC253254B5 for ; Tue, 27 Jan 2026 18:13:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769537612; cv=none; b=dX5mxM4cHQxrV0GMY6gA/92OcKGnUaf2f//eOsn2cHxm1scTdVjNF+uonMvHgXttbyoPkb3sv3nja71ATYa56qDGZSzEl9QAbGvQLyq/Jx7YSari80mH2e7ujGBc54wZqpg0PVugyO2TpBvmAloPmWZaxdPksPAcD1NubxraXoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769537612; c=relaxed/simple; bh=ZP9jD5oBd6p4cx2ft8JtLqpa/EzTPpDlX6uplfrO2XE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CZih6Qyp6Go5SF4rD2lsXhSbdvfwrWG5hTMqGlwvL3TzQHsc5XTIzqg5psBJGKHk9sL0xxzpNOwdSzAKt6FCSwZr4w2C18cRXJtV4b/XVLVMiMAPpmHitmq7fI2hSOs4kX7cGqG46MoBkJ+19tGcctfLqgFjzQf87UwWZVuV5zY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ou/yhYGM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NnrjsuvK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ou/yhYGM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NnrjsuvK" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60RH1rq81334166 for ; Tue, 27 Jan 2026 18:13:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fVOW5CGJHEDR3nYWnM/7tFR0BEN89n9x3EXWGMv4peE=; b=ou/yhYGMRM4LwzGb E4qvBiStIcXtWASzRfsdEFehMEKrw77cn4SPAbGGApt1J/psJCEzLjeKeC8JOIuq kRL/N/+4Y9ZHSlGIVkBsmR1r2JgiRZPlvoNwacnq4Vo8PpCSyLQId/zSe9RIthol CvnLd/Ns1MQ/HCGRdYsSngV1AGwEnp1JH3l8AAoP3YDBHQKAbO1FMnukAjMZYkkp D1ktPADmCkTNeLDcGMkfAH6v3SGxzqbZtaYBgjBiTegm9V1uHlggsGeSEOzFCFKD 6CuzaMXPahrzKEqZeb+95/I/4jbY2PslhFlVcSLNVOBPIFvv8lU5Oyn82cXF6obc 7K1DLA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4by1dfr84n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 18:13:30 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81d9b88caf2so4645406b3a.1 for ; Tue, 27 Jan 2026 10:13:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769537609; x=1770142409; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fVOW5CGJHEDR3nYWnM/7tFR0BEN89n9x3EXWGMv4peE=; b=NnrjsuvKOFwpJEmlmnxMw+VZU8z3+45WX7RNK4qOw+N+DLxw0/yqw7w1c2ERXajQaq u3yM24I6pCZeMHj/oUwpwlzvRhOdKEFACeejtluntJphWDbb4UoESXpsLSfojp2DYY2T h160FLXhd1Zq0qxW6tk0cZcT/pqwWwKDa6c9q9RkVg0pD0CJxoU9czvoXiBH0oF4Uqpx Uv8tFC03j289CKPZBkg0VpFhmP4RrDF6FBps3jqZ35nCu1YBPK+nGcwoT14RfAJH4cMQ nEYNAwZftpVWF9uPmku7LM/pGGw3qNfWXiqQVncak4v+l+oimEn70TLVarSasxNX7CZW rgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769537609; x=1770142409; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fVOW5CGJHEDR3nYWnM/7tFR0BEN89n9x3EXWGMv4peE=; b=tZmy8Elqfz/hnvT4ynt4XkRJAgc+QLuG6cNsaByXBVweRkACE5QMnH87zOhbD4yqmW AG8IjPjnBp+6DD/STUL1RIyXqBjd86Nft858aW2klKQWUkN4OaiM++ws3X6Oto+m/fDb pvXRE8n6hmLHwbtDmXdltC88ZDP+I7QQpitEHEGjTFd0Dg9hV0gO1CODLNSra5idFtka qBLfVX2H7AG4zyW/amb8oCcaZYP2vAV3j5CiwVeyXxAN9eJbj+Xp7xv6gkT7gdGALdiZ zdgOOPIIuNM2Z+Zp+ffrjPqCAlbiNEcg8YxZc1AM9NQQ/mXWa79ZVxALMy6Vid3GrJlR bzWQ== X-Forwarded-Encrypted: i=1; AJvYcCWXlYeanoN72rmlA3baddK7qNagzUHzw3YkPLc86G/yaLA71mGV5xwtTCMgJ0j3kLqHEyvTItYbqZpaYVE=@vger.kernel.org X-Gm-Message-State: AOJu0YwvMFNRZ6Ys0Lwkel88Tz2Hp5iUsZ3UY+vFvHcEqg9kZ6WGsojZ fmNX+eqVy9mFl2P0Thd+byJqZUizR87htwHNrvuJPM+3Mu0i85jfFWk1eafquFhU6NT9asD8rwo INjL+6BZp+0SHl7yNI+a5ngIs+2tiLnJXkZJ0jvewLvt9WhWNc+0WT2DCKejkifr8tNk= X-Gm-Gg: AZuq6aIC+LHBU2r+XCknb3lncOxSI/CLRQmojLIU5PZrZ/L3PyjLOl6Ye1uXs54HPf9 uPYExLri3Ci0NikG//PDG253wDN3qGUCHRHMvAcaCOa+WmpohUrJVK/1Ers2OWGi1YB4P8HSSM0 XztyB6sWGSH5PIVj0+UBvpXMG5Wy5vUw3ww6v+oqhqyXGNtKvS+mmpaHRpHEVvBNsI3cqDaeVoJ IKPAMgkTJAnbYEMv55dJ9keSVuZLaMXiOPscUxMEgZQ8Voz0Ud6RD3rw/MabxzIToQJvrSHIwIE vU6CLgPGna0kaFHrqf/KcN4jt0WVtOja/keuJuLUlzR3thycEepzNvs4RZ4+t3WnF+8nTjxDc5l 8KuPs9mywZ1K+T8u/jl/Lx2AXavEgtx6EALCmMpNuE/+QAb/G X-Received: by 2002:a05:6a00:8d94:b0:823:244f:1f91 with SMTP id d2e1a72fcca58-8236916b19fmr2106843b3a.11.1769537608910; Tue, 27 Jan 2026 10:13:28 -0800 (PST) X-Received: by 2002:a05:6a00:8d94:b0:823:244f:1f91 with SMTP id d2e1a72fcca58-8236916b19fmr2106816b3a.11.1769537608266; Tue, 27 Jan 2026 10:13:28 -0800 (PST) Received: from [192.168.1.5] ([106.212.237.20]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82379c226afsm217807b3a.49.2026.01.27.10.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Jan 2026 10:13:27 -0800 (PST) Message-ID: <9f5436df-fef7-4921-85b3-b6fe4e942779@oss.qualcomm.com> Date: Tue, 27 Jan 2026 23:43:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi-pinctrl: Add SA8775P and QCS8300 pinctrl To: Rob Herring Cc: Bjorn Andersson , Linus Walleij , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260127105511.3917491-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260127141740.GA1574044-robh@kernel.org> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260127141740.GA1574044-robh@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDE0OCBTYWx0ZWRfX8nwuuVo10WtK yc0rLegXVWGAyKjmE7c99QwskZHvzLZL/qqdXEKd05/EeZq+sW5RNgFzYybasc9/C40CA/ncm7X rWWxOCrMcgymwJYnssj1hNLMCDrwgWhU21MkWx4p7VNe94FWg2mBr82tB/TEasSU8q7B7q7y+gC 1UJpOkC4BowanprPqOU+8HiwoZh+F3jo0lrc+FNIq5IgKI7aJUFJzUSZa7PDdAhb8J65tCLbUlo J7yEVovbw1sH57PRfqemYYYKDZrx/VwSgzQDKZyVFpDOaUP2wQgrLptNZ2U2rqivs19OENsLMNM NAVwE3gjIO/AtiJ5U3V/mrBJFRE7mKWs/mTcGFr5O9MH9am1L3ejqohJLdaQCHhRts54auj/fnk EcoovUW1r8ONfyTzJ05hGm5YMKq0SslKKEbkEaHcBsUq4o+DnXn+way1B906IdGAUMt28BQ8b13 KynE0UH6xCGczBbQgKg== X-Proofpoint-GUID: 68FluqIeAWztsB1ech1lV-hvweSc9gVT X-Proofpoint-ORIG-GUID: 68FluqIeAWztsB1ech1lV-hvweSc9gVT X-Authority-Analysis: v=2.4 cv=YeuwJgRf c=1 sm=1 tr=0 ts=6979004a cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=buDgOHdOW+2HB7N8kE10CA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=HaOfPcbtI1sGS6EAhDsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-27_04,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 bulkscore=0 adultscore=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270148 On 1/27/2026 7:47 PM, Rob Herring wrote: > On Tue, Jan 27, 2026 at 04:25:11PM +0530, Mohammad Rafi Shaik wrote: >> Document compatible for Qualcomm SA8775P and QCS8300 SoC LPASS TLMM >> pin controller, fully compatible with previous SM8450 generation >> (same amount of pins and functions). >> >> Signed-off-by: Mohammad Rafi Shaik >> --- >> changes in [v3]: >> - Removed the duplicate driver code patch as suggested by Krzysztof. >> - Reused the existing SM8490 pinctrl, which is fully compatible with SA8775P and QCS8300. >> - Link to V2: https://lore.kernel.org/all/20260107192007.500995-1-mohammad.rafi.shaik@oss.qualcomm.com/ >> >> changes in [v2]: >> - Fixed dt-binding errors reported by Krzysztof and Rob. >> - Added proper slew rate value for wsa2_swr_data GPIO, as suggested by Konrad. >> - Documented Monaco compatible as suggested by Konrad. >> - Link to V1: https://lore.kernel.org/all/20251116171656.3105461-1-mohammad.rafi.shaik@oss.qualcomm.com/ >> --- >> .../pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> index e7565592d..354629c38 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8450-lpass-lpi-pinctrl.yaml >> @@ -15,7 +15,15 @@ description: >> >> properties: >> compatible: >> - const: qcom,sm8450-lpass-lpi-pinctrl >> + oneOf: >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + - items: >> + - enum: >> + - qcom,qcs8300-lpass-lpi-pinctrl >> + - qcom,sa8775p-lpass-lpi-pinctrl >> + - const: qcom,sm8450-lpass-lpi-pinctrl >> + minItems: 1 >> + maxItems: 2 > > No. You are either backwards compatible with sm8450 or you aren't. The > h/w is fixed. > ACK, Agree, Need backward compatibility with sm8450 for both sa8775p and qcs8300 as they must fall back to the sm8450, so initially used enum to pick between the sa8775p and qcs8300 compatibles. I see enum isn’t appropriate here since fixed h/w. will use the const instead of enum like below. properties: compatible: - const: qcom,sm8450-lpass-lpi-pinctrl + oneOf: + - const: qcom,sm8450-lpass-lpi-pinctrl + - items: + - const: qcom,sa8775p-lpass-lpi-pinctrl + - const: qcom,sm8450-lpass-lpi-pinctrl + + - items: + - const: qcom,qcs8300-lpass-lpi-pinctrl + - const: qcom,sm8450-lpass-lpi-pinctrl Thanks & Regards, Rafi > Rob