From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, wenst@chromium.org, hsinyi@chromium.org,
sean.wang@mediatek.com, dianders@google.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 2/4] arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks
Date: Tue, 3 Dec 2024 10:09:23 +0100 [thread overview]
Message-ID: <9f55bfdb-d4c5-48d2-8a6b-fee5dc147d94@collabora.com> (raw)
In-Reply-To: <20241202032035.29045-3-xiazhengqiao@huaqin.corp-partner.google.com>
Il 02/12/24 04:20, Zhengqiao Xia ha scritto:
> MT8186 chinchou, known as ASUS Chromebook CZ12 Flip (CZ1204F)
> and CZ12(CZ1204C), is a MT8186 based laptop.
> It is based on the "corsola" design.It includes chinchou and chinchou360,
> including LTE, stylus, touchscreen combinations.
>
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@huaqin.corp-partner.google.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 3 +
> .../mediatek/mt8186-corsola-chinchou-sku0.dts | 18 +
> .../mediatek/mt8186-corsola-chinchou-sku1.dts | 35 ++
> .../mt8186-corsola-chinchou-sku16.dts | 29 ++
> .../dts/mediatek/mt8186-corsola-chinchou.dtsi | 321 ++++++++++++++++++
> 5 files changed, 406 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku16.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
>
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 8fd7b2bb7a15..0db7770e8907 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -55,6 +55,9 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-kodama-sku32.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku0.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-kukui-krane-sku176.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8183-pumpkin.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku0.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku1.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-chinchou-sku16.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393216.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393217.dtb
> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8186-corsola-magneton-sku393218.dtb
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> new file mode 100644
> index 000000000000..5d012bc4ff0d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku0.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2024 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola-chinchou.dtsi"
> +
> +/ {
> + model = "Google chinchou CZ1104CM2A/CZ1204CM2A";
> + compatible = "google,chinchou-sku0", "google,chinchou-sku2",
> + "google,chinchou-sku4", "google,chinchou-sku5",
> + "google,chinchou", "mediatek,mt8186";
> +};
> +
> +&gpio_keys {
> + status = "disabled";
> +};
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> new file mode 100644
> index 000000000000..c18f473f6a0f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou-sku1.dts
> @@ -0,0 +1,35 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright 2024 Google LLC
> + */
> +
> +/dts-v1/;
> +#include "mt8186-corsola-chinchou.dtsi"
> +
> +/ {
> + model = "Google chinchou CZ1104FM2A/CZ1204FM2A/CZ1104CM2A/CZ1204CM2A";
> + compatible = "google,chinchou-sku1", "google,chinchou-sku17",
As pointed out in the binding review, please move SKU17 after 7, before 20.
> + "google,chinchou-sku3", "google,chinchou-sku6",
> + "google,chinchou-sku7", "google,chinchou-sku20",
> + "google,chinchou-sku22", "google,chinchou-sku23",
> + "google,chinchou", "mediatek,mt8186";
> +};
> +
..snip..
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> new file mode 100644
> index 000000000000..c3835c7c4444
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola-chinchou.dtsi
> @@ -0,0 +1,321 @@
..snip..
> +
> +&mmc1_pins_default {
> + pins-clk {
> + drive-strength = <MTK_DRIVE_8mA>;
Please do not use the MTK_DRIVE_xxx definitions.
This is just `drive-strength = <8>;`
> + };
> +
> + pins-cmd-dat {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +};
> +
> +&mmc1_pins_uhs {
> + pins-clk {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +
> + pins-cmd-dat {
> + drive-strength = <MTK_DRIVE_8mA>;
> + };
> +};
> +
Everything else looks good.
Cheers,
Angelo
next prev parent reply other threads:[~2024-12-03 9:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 3:20 [PATCH v4 0/4] arm64: dts: mediatek: Add MT8186 Chinchou Zhengqiao Xia
2024-12-02 3:20 ` [PATCH v4 1/4] dt-bindings: arm: mediatek: Add MT8186 Chinchou Chromebook Zhengqiao Xia
2024-12-03 9:09 ` AngeloGioacchino Del Regno
2024-12-02 3:20 ` [PATCH v4 2/4] arm64: dts: mediatek: Add MT8186 Chinchou Chromebooks Zhengqiao Xia
2024-12-03 9:09 ` AngeloGioacchino Del Regno [this message]
2024-12-02 3:20 ` [PATCH v4 3/4] arm64: dts: mediatek: Add exton node for DP bridge Zhengqiao Xia
2024-12-03 9:09 ` AngeloGioacchino Del Regno
2024-12-03 9:15 ` Chen-Yu Tsai
2024-12-02 3:20 ` [PATCH v4 4/4] arm64: dts: mediatek: Modify audio codec name for pmic Zhengqiao Xia
2024-12-03 7:56 ` Chen-Yu Tsai
2024-12-03 9:09 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f55bfdb-d4c5-48d2-8a6b-fee5dc147d94@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=hsinyi@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=wenst@chromium.org \
--cc=xiazhengqiao@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®