From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <ying.huang@intel.com>,
<david@redhat.com>, Zi Yan <ziy@nvidia.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH -next v2 09/19] mm: mprotect: use a folio in change_pte_range()
Date: Sat, 14 Oct 2023 11:11:54 +0800 [thread overview]
Message-ID: <9f56879d-2157-45ba-9f62-2c67b924da8d@huawei.com> (raw)
In-Reply-To: <ZSlekx1pYOh7ltaF@casper.infradead.org>
On 2023/10/13 23:13, Matthew Wilcox wrote:
> On Fri, Oct 13, 2023 at 04:55:53PM +0800, Kefeng Wang wrote:
>> Use a folio in change_pte_range() to save three compound_head() calls.
>
> Yes, but here we have a change of behaviour, which should be argued
> is desirable. Before if a partial THP was mapped, or a fs large
> folio, we would do this to individual pages. Now we're doing it to the
> entire folio. Is that desirable? I don't have the background to argue
> either way.
The Huang's replay in v1[1] already mentioned this, we only use
last_cpupid from head page, and large folio won't be handled from
do_numa_page(), and if large folio numa balancing is supported,
we could migrate the entire large folio mapped only one process,
or maybe split the large folio mapped multi-processes, and when
split it, we will copy the last_cpupid from head to the tail page.
Anyway, I think this change or the wp_page_reuse() won't break
current numa balancing.
Thanks.
[1]https://lore.kernel.org/linux-mm/874jixhfeu.fsf@yhuang6-desk2.ccr.corp.intel.com/
>
>> @@ -157,7 +159,7 @@ static long change_pte_range(struct mmu_gather *tlb,
>> continue;
>> if (sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING &&
>> !toptier)
>> - xchg_page_access_time(page,
>> + folio_xchg_access_time(folio,
>> jiffies_to_msecs(jiffies));
>> }
>
next prev parent reply other threads:[~2023-10-14 3:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:55 [PATCH -next v2 00/19] mm: convert page cpupid functions to folios Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 01/19] mm_types: add virtual and _last_cpupid into struct folio Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 02/19] mm: add folio_last_cpupid() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 03/19] mm: memory: use folio_last_cpupid() in do_numa_page() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 04/19] mm: huge_memory: use folio_last_cpupid() in do_huge_pmd_numa_page() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 05/19] mm: huge_memory: use folio_last_cpupid() in __split_huge_page_tail() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 06/19] mm: remove page_cpupid_last() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 07/19] mm: add folio_xchg_access_time() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 08/19] sched/fair: use folio_xchg_access_time() in numa_hint_fault_latency() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 09/19] mm: mprotect: use a folio in change_pte_range() Kefeng Wang
2023-10-13 15:13 ` Matthew Wilcox
2023-10-14 3:11 ` Kefeng Wang [this message]
2023-10-13 8:55 ` [PATCH -next v2 10/19] mm: huge_memory: use a folio in change_huge_pmd() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 11/19] mm: remove xchg_page_access_time() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 12/19] mm: add folio_xchg_last_cpupid() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 13/19] sched/fair: use folio_xchg_last_cpupid() in should_numa_migrate_memory() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 14/19] mm: migrate: use folio_xchg_last_cpupid() in folio_migrate_flags() Kefeng Wang
2023-10-13 8:55 ` [PATCH -next v2 15/19] mm: huge_memory: use folio_xchg_last_cpupid() in __split_huge_page_tail() Kefeng Wang
2023-10-13 8:56 ` [PATCH -next v2 16/19] mm: make finish_mkwrite_fault() static Kefeng Wang
2023-10-13 8:56 ` [PATCH -next v2 17/19] mm: convert wp_page_reuse() and finish_mkwrite_fault() to take a folio Kefeng Wang
2023-10-17 7:33 ` kernel test robot
2023-10-17 9:04 ` Kefeng Wang
2023-10-17 14:51 ` Andrew Morton
2023-10-13 8:56 ` [PATCH -next v2 18/19] mm: use folio_xchg_last_cpupid() in wp_page_reuse() Kefeng Wang
2023-10-13 15:19 ` Matthew Wilcox
2023-10-13 8:56 ` [PATCH -next v2 19/19] mm: remove page_cpupid_xchg_last() Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f56879d-2157-45ba-9f62-2c67b924da8d@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=vincent.guittot@linaro.org \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®