From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 053143890FB for ; Fri, 13 Mar 2026 09:54:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395655; cv=none; b=Zl7MXWoXCCSAeO0+i5YswjxV6P8nielGG0i67ghSORXavI4yZtRVZ5uyivS46jxSbmj2kvyg5nxehAGv06lVD3VVEHN1RvsYZIvbmnZMMGv1PuRSZiIm/mdIocTiLcR2xMXN5J+VE+Zj9BDvD/il44GY9lmrI6PpAmBqVc/WiGw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773395655; c=relaxed/simple; bh=jF+RGW1oq+A2HAK5SMqoEpl7vhxLMd3h55OdaY/EqoM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MT79Z51D4XrzDfJsW3Rdgix5itNnO6QttEOJVrj6IsOSTccxWC0XV/S/+cLA7ofVkO57wzw+jFK87ck1udsNgc748wMbp2Y2M0+iQcl9EyDl2c/8KCeuQ8SFh4BD8hEkA0xOSvg1k9tbqApyNGDRiJK0+BBRZEQKRKQIwWcWhcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DhbjcMKN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=isfkRUtt; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DhbjcMKN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="isfkRUtt" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D5tfY31574644 for ; Fri, 13 Mar 2026 09:54:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UMs7baKzQP96vz7tn8LFJ/luoeqtWF5RUkw5fVAin8U=; b=DhbjcMKNsVvJF9GM vz8KZkmTiptrfvp/Yr0Z+E29KWdeEdwTmrpGuq/egQhqW95QgTM12N47JGeJxxg0 JGEBA2l9tRow0UCgsmxEwuhPLDpF/j0OTbglLEXXvc50M8tbpDiq80iSbcYLqwq/ 7J5KWZxNP43gpSd75yz97uPUheTY3VTsLUpSYkdClFapx9AzFePNDxqS6ywQBYvK klH5B1rTbiEc/erg1OsbweQ5lAwWpCE0f8gkia/tBKb5siwXn8YZRjIrPYY2cNSQ +O0EqrTFiEbXrSI4hjy9PKg+3G7cErqisjm94i64s/YtMmFWKNlppAULwLYXMktL cHqQVA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cuh53nhrq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 09:54:11 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5091327215dso128243811cf.1 for ; Fri, 13 Mar 2026 02:54:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773395651; x=1774000451; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UMs7baKzQP96vz7tn8LFJ/luoeqtWF5RUkw5fVAin8U=; b=isfkRUttxuyvpm6LHjq36eIMdbGLTzeiHovzqcgE1RjlCrTGg1o+BqxTHvGCEnwOkL fwelSsn2OnrjP/YalfhuePsLqQMr0glnKS7Puu7ShF77jmN1odfJvFxg+aW8nXOFfogY /nb/GvoyDrXdrEz486VaQbyzyiRxGWfogSWwJfvdu/iC9/FJijQMm6uCyYhqUy44ZUJ0 HXjcoubXNy+MTjmAfADYUYZZzKlXG44DXV9m3XJREsBXPBixXl9DMZA0/3KYX2nnPw3W tEcQYVyIJxCjxbtFU8Dtuishq6X2hYdgUVooWW13ue0Mc5Afa2227GHFAt18q2waeC1/ EKcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773395651; x=1774000451; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UMs7baKzQP96vz7tn8LFJ/luoeqtWF5RUkw5fVAin8U=; b=WWRdOPwjhvYBPxscDcIsvdxgK5a2mVUzqfN5e6SVnMo2yNy4Eynw5Z3bduhQLUnQ0v TitdV1d0b8gAwterrmUP9k3RfHI1wdTxbB3rMl9Kx9VgDO0b+sp3hLwDOKpN2GRfPrKF TfjfAdyoqjaRQKI4GtO/BamUwfuu/Oyj5B2hXcGlLna/4dbsjdC5yakL3ADNgLnxJgcJ XAMUQGvNHs4NwkzLuC7OVR0UD1Sabo23jwS/DDUFiZ4qaf6kZSCcLGnHdmjJA0dRUXtI hw0yo0cOCm8v5Ukm18yy9x/FxpMhSZzWby/1lJywgyxkl/TD83M4uoa9eIZka1PlcbSP txYA== X-Forwarded-Encrypted: i=1; AJvYcCUritJa4vuVHM/qVNHW7f84MaLb/4pJkgaWgpzCvshmIxI8iUfi5IkYbsB7/fuNTt3R8d1OIlK8eWnsmmk=@vger.kernel.org X-Gm-Message-State: AOJu0YxUwDfQpW9OniClGOBtZ0besak+Vxgmis9t6vQH2EGdluk9G2nD 9Lji/nxYSLN0JIlIQtmTo1SnU9sRTwrNAQM2nKdZi0dL19+VKvEtjjaEw2zptKR/HcD+C3G5P7h VsOUyeUNVAlSxd0u2CaxvVCwpc/+F3jsTIWCyOAU8PNFjWJKkgwJFw6NkcvbzOC0Wxsc= X-Gm-Gg: ATEYQzxcZXAq7S7ETuNKJTkmM2ABeq0cYuNOVKthfsat1vKfmPQJdH0TfK93ciO6Xeu c25oKd0PGNSo3OOg+thoawMM+NDIL7CkE339Hbzc+RW7q8VEBh9JkTdbs+dO/3sIQjNGkR0i52P 9IuL6IvrA91qVi+7O5r8yKX27O4MnH1zVrBMZAHLr2JajpISX7WvM71zeqVBvBmbC2aO9rlI8M4 QjDGCYNTDKlIHnITQLleVC4m46GBQl5V8XJ53L0okdEoa9el1u8U9X8owctbuAgu2RFk5dbBi3S vrQujpHgqSEtjiQeAlPOLWWKat+faDUPo0my8ZS/kyaVP7HmAAlD0flubMAq+brshh5MYhfKo7n pfnA6bqEoE1WrF9ZdLDrr7eJHfVYBYsgtOsw/KF/6O2pQzATg8upCKgs6CZMPiEVGc63MhNG86h LlUSaBUeM= X-Received: by 2002:ac8:5ad6:0:b0:509:2448:41a with SMTP id d75a77b69052e-50957e6d955mr32552231cf.42.1773395651220; Fri, 13 Mar 2026 02:54:11 -0700 (PDT) X-Received: by 2002:ac8:5ad6:0:b0:509:2448:41a with SMTP id d75a77b69052e-50957e6d955mr32552001cf.42.1773395650735; Fri, 13 Mar 2026 02:54:10 -0700 (PDT) Received: from [10.111.173.3] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5093a0ea844sm63722031cf.17.2026.03.13.02.54.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 02:54:10 -0700 (PDT) Message-ID: <9f5839d8-ccc7-4e7a-856b-46b947993df1@oss.qualcomm.com> Date: Fri, 13 Mar 2026 17:53:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: qcom: camss: Fix csid clock configuration and IRQ offset for 8775p To: Bryan O'Donoghue , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Hans Verkuil , Vikram Sharma , Suresh Vankadara , Wenmeng Liu Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260313-vfelite_fix-v1-0-2ee7de00dee7@oss.qualcomm.com> <20260313-vfelite_fix-v1-1-2ee7de00dee7@oss.qualcomm.com> <3499e8ad-ee87-410b-9db1-215d6c20e195@linaro.org> Content-Language: en-US From: Wenmeng Liu In-Reply-To: <3499e8ad-ee87-410b-9db1-215d6c20e195@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=ZN/aWH7b c=1 sm=1 tr=0 ts=69b3dec3 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=fbPyYwy2ZK-1YPEEdNgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDA3NSBTYWx0ZWRfX3vp3kg2fbqlu 7643mHSySUW3v/ZP+sgDM3Vo9XMquizCoTtVrSVP6x1YG+Xw+y1TeVlIeyD0axr/B+edQIV4Y/W nKF4UG1bq0ByHKIw411+fEzTsWOcRpH50wUhn+AQqLLmgiUQvg6PV77InZEQH48k9IxZrCKeq9a KTghfTrOtnpKKfgkIBZQMF2rAx0NAqKYHgN5XPGY38smmjo3REVOfPixsN5ywxZCv9uWP92Jj06 GSATHK+TGH8jB28+RS66Gk8IJ3CK2fFISvsDwThj9S/X05+rC9mSlpMY0befqmdzrr55fpQ2Kgj H3KT8MnNiLASGHR96y5D9ju0Gc0imFmTA9K9Y4PkrhIX/492JIoBf3ivITfmBRc1XR6HwG83cvm ZbD/6w9bSi7fpHAzss7w3HIcUaP5aWgvoEQGJGiYFJyWpzjyirtAKDSAEOfogPPBxC14j0p2KCE GeK76dTHILmvWQm7Cmg== X-Proofpoint-GUID: mrVJJA95uye8mANZcXCvpEqI70iSa__M X-Proofpoint-ORIG-GUID: mrVJJA95uye8mANZcXCvpEqI70iSa__M X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_01,2026-03-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 phishscore=0 adultscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130075 Hi Bryan, On 3/13/2026 5:46 PM, Bryan O'Donoghue wrote: > On 13/03/2026 09:42, Wenmeng Liu wrote: >> Fix two issues in csid driver for 8775p platform: >> >> 1. Simplify clock configuration for csid lite by removing unused clocks >>     and correcting clock rates. Only vfe_lite_csid and vfe_lite_cphy_rx >>     clocks are actually needed. > > This should be its own patch and should that patch have a Fixes: ? > > Simplification != fixing a bug. Sure, There is also an issue with the clock here, I will also modify the description. > >> 2. Fix BUF_DONE_IRQ_STATUS_RDI_OFFSET calculation for csid lite on >>     sa8775p platform. The offset should be 0 for csid lite on sa8775p, >> >> Fixes: ed03e99de0fa ("media: qcom: camss: Add support for CSID 690") >> Signed-off-by: Wenmeng Liu > > Yeah this should be standalone then. > > My general rule here is if your patch requires line items to explain > various things being done, then those line-items deserve their own patch. ACK. > > --- > bod Thanks, Wenmeng