From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67633C43219 for ; Sat, 4 May 2019 11:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3D0F6206DF for ; Sat, 4 May 2019 11:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727435AbfEDLeM (ORCPT ); Sat, 4 May 2019 07:34:12 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7722 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726529AbfEDLeM (ORCPT ); Sat, 4 May 2019 07:34:12 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4919084083BFD99A0328; Sat, 4 May 2019 19:34:09 +0800 (CST) Received: from [127.0.0.1] (10.184.189.20) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Sat, 4 May 2019 19:34:02 +0800 Subject: Re: [PATCH] net: route: Fix vrf dst_entry ref count false increasing From: linmiaohe To: , , , , , , CC: mousuanming , Mingfangsen References: <76551ed7-47ef-7442-69de-6fb42fff4708@huawei.com> Message-ID: <9f599716-eef7-a224-0bda-2f4e7c2f58b4@huawei.com> Date: Sat, 4 May 2019 19:33:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <76551ed7-47ef-7442-69de-6fb42fff4708@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.184.189.20] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/5/4 16:03, linmiaohe wrote: > From: Suanming.Mou > > When config ip in default vrf same as the ip in specified > vrf, fib_lookup will return the route from table local > even if the in device is an enslaved l3mdev. Then the > dst_entry will hold the vrf device rather than loopback > device in local_input of function ip_route_input_slow. > So vrf dst_entry is false increased by route from table > local. > > Here is reproduce step: > 1.enslave enp4s0 to vrf2, and config ip address: > ip link add vrf2 type vrf table 1 > ip link set vrf2 up > ip link set enp4s0 master vrf2 > ip addr ad 125.1.1.1/16 dev enp4s0 > > 2.config same ip in default vrf: > ip addr ad 125.1.1.1/16 dev enp6s0 > > 3.config peer and ping: > ip vrf exec vrf2 ping 125.1.1.2 -c 3 > > 4.del vrf2 link: > ip link del vrf2 > > And "unregister_netdevice: waiting for vrf2 to become free. > Usage count = 1" will occur. > > Signed-off-by: Suanming.Mou > Signed-off-by: Miaohe Lin > --- > net/core/fib_rules.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c > index ffbb827723a2..1a2c11ed1585 100644 > --- a/net/core/fib_rules.c > +++ b/net/core/fib_rules.c > @@ -263,6 +263,11 @@ static int fib_rule_match(struct fib_rule *rule, struct fib_rules_ops *ops, > if (rule->tun_id && (rule->tun_id != fl->flowi_tun_key.tun_id)) > goto out; > > + if (!rule->l3mdev && > + (netif_index_is_l3_master(rule->fr_net, fl->flowi_iif) || > + netif_index_is_l3_master(rule->fr_net, fl->flowi_oif))) > + goto out; > + > if (rule->l3mdev && !l3mdev_fib_rule_match(rule->fr_net, fl, arg)) > goto out; > I'am sorry, but I think this fix looks bad because this patch make vrf working with other ip rule impossible. I will send anothor patch to fix this. Thanks.