From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 526D7254845 for ; Wed, 2 Jul 2025 13:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461893; cv=none; b=QYceYKG5OiGgwgi81eHFCTCaEITOov69y1b5dvFyPooBcTfPFujadmaipdVBnI1CDrBGQxosn3bI7ziqmtJLUrZVP0DVRrKRZIrXkQy2X9/VjNyOWKcvNixTiYZdaJZUWDXUQxMrH0mHGNGHdIce91KrP+TOmaBFWaK9M6y1+vw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751461893; c=relaxed/simple; bh=2qnYYx6xwWMHatqOtbmA5fZZO68GJhtCXnEdgTR+uR0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IkeO7ph1HHlKnPEzoletPVcAYhKKpcZeQiLYX0cXIfS4qViHdBjDXaSkvWlDZjn75RXoZi/X8blzE0CCXcztVk2K/AR9mAwcUp9xrdXbL/j6voUHP2d6enhXGPjkuqjMlkCrsnIw/9RPY5HgSLe1jPOluA1g1yTdJjbXJQrB7ZI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iZhvQyam; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iZhvQyam" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 562D7BnR000415 for ; Wed, 2 Jul 2025 13:11:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jay9izauXc/A0gdbOKQN9NpMjdCplbml2iUZTiy4bd8=; b=iZhvQyamk8dz9MfS UNokItTXOgeGBF083BrEcVIIhMMAfXDNJAjHfP/bbXe4j2qCqvaiG+Rp41kq5yHe cnhVgPEQUSlVOL5jFhFKDZlhcuJ9WZx8bl7iiow/OEyvH8ChfcKNzmyklnsaCsbC peP/VUt+IKdoPXHeiFr3BUDV91JT3gkcIkqi5SnsQyVrGuy6W8IUhCd+XY2SYHRH gL+V0MIEIuipWxwf7CYVjsjV7mUbG8rbqyep+KOoQWqpXd8XoyZlGiEnjKoTKTni Cte6NzLNkMBUY01SDrYRezE+WwMJKzp5z9TzPirnYc1bahDsrM0Kj1Dr81lu4Dly 6QXjaw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j7qmcn6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 02 Jul 2025 13:11:30 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7d0a9d20c2eso149846385a.0 for ; Wed, 02 Jul 2025 06:11:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751461890; x=1752066690; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jay9izauXc/A0gdbOKQN9NpMjdCplbml2iUZTiy4bd8=; b=r7zlz/ULAVsrsDd2f7hHenmI0uHlgr7+V6+EhbjPaQkJXPOccEqQ2P8QI3X7SiRTTN 5cA1ThEO+A88TM3kSTXoS6eXj0nO/C0mOTwQzeeZvWvAu5IeAkNS1O0A0lCUjJ9iOkv3 AjvgY9hsrEWbgzCg7XBLMuqEQrhF7pypEuw/ZBRXYcj0iAA/xnsNuT+8LH3tgPtzTpiu 0nWZ2KbsrCZvu6QBQ7ALNIn+JW4oRa2d1bEmq/DM9UgZiM58Xet/lc9L0FI5AMFIGdhs 9YjRC5VBny9GGCAxqJSPhcC5qNH4WCREXucg27k2ekLU3pzPG2gXK7ukNN33EYXjLXFl p8AQ== X-Forwarded-Encrypted: i=1; AJvYcCUjuKiUS6yH84MbVvk557AuGdvylT8q+GMPxK742FlLsQEpZBV0HhXn1ivlarvTUX0iXzp/+vx1YpKT9N8=@vger.kernel.org X-Gm-Message-State: AOJu0YzzrCSpeoSB0Oo8xnpIIIpPkhO5GvqDziOmCX7iQV3nClI1YWa7 BZS0MhuMTlYGYXIT6qRWJIQOFFt30qB/zKijgnzsUyzZpFKvwFc70iQeASg1tpQkqqU7sk755K8 vmgRmIhZffpyRjt+a1qEsq4cp3TNYj4Jz8cDzkH+pxagbCYLSQBrjJZ+GpE2sOiJaOq8= X-Gm-Gg: ASbGnct5TYm51TwPGR6JHrcnz+uROa4YEzq5i8RMEjIF5iWX0mItfsecvgB3dFcmmuq 1V1oeAK6egTxkNKxkE2HH839KMt/JSGrmj94xsTUdTy5nOroCEvMoeUvPEugJ5586VVId1XqbuW t9gWy9bB95+xDtYvUD7X/MBjtIDB9GGANfMxn5b4kOfWfih3No1mx1XALf2pQC+x4Tu1x//+nVo LA6stWxOPsy65pMi4j5BvgIMEEMeNnYrZpjxcr66ugoenDg9hfa945wZj7EsHIDqmSos3CzK9p7 07XyLFKaFSrZfVWtNYIRVZsYuEpk24HVEYUM4LKMjJ8v5np6l2pUJM3FQLOn0oUAXrB/EJ/Ju5o ZAtM= X-Received: by 2002:a05:620a:3954:b0:7d4:1ecb:dc36 with SMTP id af79cd13be357-7d5c471292emr168242385a.3.1751461889641; Wed, 02 Jul 2025 06:11:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTS+JCpkO+wdIex8GFBFpWIr+rL0zlZnGn08j7hpD5QH4DqCrlEVJJr/mrxA97KHZJKBH54A== X-Received: by 2002:a05:620a:3954:b0:7d4:1ecb:dc36 with SMTP id af79cd13be357-7d5c471292emr168240985a.3.1751461889141; Wed, 02 Jul 2025 06:11:29 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6bbfdsm1080255266b.115.2025.07.02.06.11.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 06:11:28 -0700 (PDT) Message-ID: <9f5be122-302d-402f-91f2-675507612d32@oss.qualcomm.com> Date: Wed, 2 Jul 2025 15:11:25 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] media: dt-bindings: add non-pixel property in iris schema To: Krzysztof Kozlowski , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250627-video_cb-v3-0-51e18c0ffbce@quicinc.com> <20250627-video_cb-v3-1-51e18c0ffbce@quicinc.com> <19dd2e69-ad13-46f2-b99f-04a5e26f10d3@kernel.org> <08c8cdfd-099e-7b90-b163-23ecee3a5da4@quicinc.com> <118f2cbe-d8bd-4177-b0d5-91d9f1dbbef0@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <118f2cbe-d8bd-4177-b0d5-91d9f1dbbef0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=C4TpyRP+ c=1 sm=1 tr=0 ts=68653002 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=wGamMhhJhDPYSn1yWlIA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: l1M_k6eOYyHCVIBz3blvzrdyZ6mauzWn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzAyMDEwNyBTYWx0ZWRfX81Y897hiQqtz MKXYDnh4BMtBr0TPSt0mIwpCnYUQyRaNzbCkErgF1TJ9pGlAhL7hRlc15y9TJLYOzB9ZWO5OuHm NkOM7wJRuIr9a1Q4IpMBgbl039CpfCpBqtkOtDmQ1Bh/QQeIniAhqN9D7a7H4pgjjIQdwDMhnaX mEjafqfNqttqBF6lPQCO6cDYRmF9Nhra7PBN/mH0eg8O8r82K0lPWEWfYnZby+gEJ8BwJs3fp+l iy1PQM3wZhJb51FLrVZTU7r9HAZxQx9gnuOXcIRaEnBxha+nIn4OIF3nD+WIXeJwb+n/EBvAnPu GgQuz/wh6Iqs3dRaAK/dxmJT1wJaRNYMYpsXNduKNpYbd//mBX3PzRbdiLltTPUnchacH01J2d8 HNCdq2mxy/0XzPiL1gHtxhASMeSmRB64hA7I40MEvLVRiQz+IsE1t2zQYxS92BlLZWlJ/uOJ X-Proofpoint-GUID: l1M_k6eOYyHCVIBz3blvzrdyZ6mauzWn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-02_01,2025-07-02_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 spamscore=0 mlxscore=0 mlxlogscore=847 adultscore=0 malwarescore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507020107 On 7/2/25 1:46 PM, Krzysztof Kozlowski wrote: > On 02/07/2025 13:32, Vikash Garodia wrote: >> >> On 7/2/2025 4:43 PM, Krzysztof Kozlowski wrote: >>> On 27/06/2025 17:48, Vikash Garodia wrote: >>>> Existing definition limits the IOVA to an addressable range of 4GiB, and >>>> even within that range, some of the space is used by IO registers, >>>> thereby limiting the available IOVA to even lesser. Video hardware is >>>> designed to emit different stream-ID for pixel and non-pixel buffers, >>>> thereby introduce a non-pixel sub node to handle non-pixel stream-ID. >>>> >>>> With this, both iris and non-pixel device can have IOVA range of 0-4GiB >>>> individually. Certain video usecases like higher video concurrency needs >>>> IOVA higher than 4GiB. >>>> >>>> Add reference to the reserve-memory schema, which defines reserved IOVA [...] >>>> dma-coherent: true >>>> >>>> + non-pixel: >>> >>> Why EXISTING hardware grows? >> Same here, the commit describes the limitation of existing design and also >> explains the need for having the non-pixel device. Its not that the hardware is >> growing here, rather the hardware stream-IDs are utilized differently to get >> higher device addressable range. > > You are not doing this for a new device. There is no new device here at > all. Nowhere here is a new device. > > Changes for a new device COME TOGETHER with the new device. > > What you are doing here is changing existing hardware without any > explanation why. This is bindings getting a reality check.. this goes as far back as Venus existed (msm8974/2012) We unfortunately have to expect a number of similar updates for all multimedia peripherals (GPU/Camera/Display etc.), as certain mappings must be done through certain SIDs (which are deemed 'secure') and some hardware has general addressing limitations that may have been causing silent issues all along Konrad