From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC8D2F1FF9 for ; Thu, 26 Jun 2025 15:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750951773; cv=none; b=PGma2NGtoONI035+ZtM0S87UQxx/HNpCwTOK7d/jUfkEQHvtJ9O1QoaXwCTTDm8EIysdFZU7Q8BlzTf+d4IjBhD543NgprmIB20Y9BPEZVVZZE/tHJe82j6MsmKkmdFBSDfMQ75gurEQ0Vbea5OTQ6jROSZrgNBaaBKRD3k/6sg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750951773; c=relaxed/simple; bh=zsEtWmSEopnL8W/hN2EMviKz3iRraF32LAGf1ufHviI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=M/mXXrjxXHhh+z36TGrLVJaNRq+j3i+pz6V+Z1+s0UD7GzjgAk7LAtvr5bOm2F9W8HRVGsEQjP5Rp8q5VPtizMNF+nBhf37f7ZjLoSNGAuTrhZToRhmxHk7kwzwTh5DQcXhttCsiu7mH3qp9dZt7N8Y+ir5F8ipseNOLp+LJ4mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=K0pXdpfJ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K0pXdpfJ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-45363645a8eso8144245e9.1 for ; Thu, 26 Jun 2025 08:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750951768; x=1751556568; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=+vLjBGNbduGxsHBe1hcwZjNzHv6v3uafeDP+VrPNzGE=; b=K0pXdpfJUeaYbB8nzCy6jVoaA8Yejdie4Aga25pBWZmXtLn3Aboamqete8XT2Ohjgw kuZcnCKKf0XTtpLAlXx5mtAqMfqayAne+0u/P/keKEM1dpqK/3dS3kL6MTYkBtBTZ+Yv OZmMrEQhlrCflyGhRtztd8zAHukI76Zg70+7G3SIvkUC2cpeMMyPT8fIbCMm9zuDgRu3 1qDAuorXI3m4/9iPwnDLOYWnsP4s/eb04glW8eZy/HYLnDIma85rRVCqqn+6dq091pY7 qmzAlb7/tiIbqaPfCMBXqoOKJFzN6n3QphtdKQanW+R0pOI/+8bzLMfjrfk3pMBCvXc2 rtBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750951768; x=1751556568; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=+vLjBGNbduGxsHBe1hcwZjNzHv6v3uafeDP+VrPNzGE=; b=Z18LlsPx1A+cYEnD5VWazs+dquU43SVkigabtG+Ui/Jcb1N9h/KTRak5k/jPRz9Pau c8euFVKRcr7wL4I60gtDauyc5SR4dS/y60ZRJmNH9BEQF3KlCntvn6lN2mWy4r9JDfPu 9rCg19+6o31xLy5sd7xCYwMlwzqfdkqFzVYATjJ+X+emB1FogugvQ46ZMMmKeLiZ5k9a Igk8vaxOR0P21UPyUjSKF80Zzy2cTwK6TmkvAeBxBUbMqzywTK6ZRq8bL1GCaq4q+vQ8 plum34fdYoj3+DicL4io8Vy6Rfcm+lOLemN4zJY4kpRaWEDYWFCOwuFJ5sYsUtbNgYeO DGnw== X-Forwarded-Encrypted: i=1; AJvYcCXbfsgM3jfegAHMZKlF1phm8+HqxcTbh97jsRo1rAV9QeliTuOYYyWnvDUB3Z5FXKfuKw4BsZLAmk9+Ans=@vger.kernel.org X-Gm-Message-State: AOJu0YxCsfFRE+/nAmXi/Qm7FNYkSAUE6PN7UqjeX07i+Asu3VwrVSYt P2zOqK3NR6Kd//cXystXBojmMY9YvYOaKfRo4T2miR8MQiENHV7d1ujkf9Vp3oaQOgg= X-Gm-Gg: ASbGncvMeYVuU2NFxFmz5bBz/HjYjZiNMm7S1Y4y/isA+d7YkDYH2IcozmfF1knpgGc FQcYAszdzjcGUBgBBPMTU8L+hGlDTs/EIuSf3HV88Ors14cbpVO9HlijwKfI4/hL3dcYo1cr4Dc yyt0Xph31ApgrYiGhWFPzjHaQDzjBN+uns5ckEWm5o282Z+m9lLqNJBtkkpaCiY4FswfA1UPNQ8 NY+zYQa9qv3RgQGvN/Xyqq2O1hPagr0NUBln2ABf/jIKbZgqWTSA1/Pip8UXrb302gxMo158he1 zIP2HmCikcHBVGGuEhFarzE/YGJjTLPEywfUIXmUatWQ11zM5sLWMmNCLAZAKBPjXt/YoKHC688 Mv0BIiwbvAJCJofo73C5iDF2p+3uuECInsfoeUZ0= X-Google-Smtp-Source: AGHT+IHpdHnYyM0Oiv1keqv2r8sYvcGTr2Gd4G1+fBIzJWNacxvEidYHy64LKVWJlWS4MITobO6RSw== X-Received: by 2002:a05:600c:4e02:b0:43c:f513:958a with SMTP id 5b1f17b1804b1-45381add658mr82168345e9.13.1750951768377; Thu, 26 Jun 2025 08:29:28 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:fa6f:b132:4858:18cc? ([2a01:e0a:3d9:2080:fa6f:b132:4858:18cc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c3a96sm53194575e9.35.2025.06.26.08.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jun 2025 08:29:28 -0700 (PDT) Message-ID: <9f60698a-bb4f-4559-b347-44c8bb078a0f@linaro.org> Date: Thu, 26 Jun 2025 17:29:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH 4/5] thermal: khadas_mcu_fan: add support for Khadas Edge 2 To: Muhammed Efe Cetin Cc: daniel.lezcano@linaro.org, devicetree@vger.kernel.org, efectn@protonmail.com, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, rafael@kernel.org, robh+dt@kernel.org References: <20250626151644.1492631-1-efectn@protonmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20250626151644.1492631-1-efectn@protonmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/06/2025 17:16, Muhammed Efe Cetin wrote: > On 6/26/25 17:46, neil.armstrong@linaro.org wrote: >> On 26/06/2025 16:36, muhammed.efecetin.67@gmail.com wrote: >>> On 6/26/25 17:11, neil.armstrong@linaro.org wrote: >>>> On 26/06/2025 16:04, muhammed.efecetin.67@gmail.com wrote: >>>>> From: Muhammed Efe Cetin >>>>> >>>>> Fan control on the Khadas Edge 2 is controlled with the 0x8A register, >>>>> using percentage values from 0 to 100, whereas there are only 3 constant steps in previous Khadas boards. >>>>> Therefore, i added a new cooling-levels property, similar to the one used in the pwm-fan driver. >>>>> The original behavior can still be used when the cooling-levels property is not specified, >>>>> ensuring that the new functionality does not break old boards. >>>> >>>> Thanks for the explanation, but would would you like to change that ? The MCU can accept >>>> any value between 0 and 99, so why change the levels from DT ? >>>> >>>> Neil >>> >>> Thanks for the review. Therefore, you say just add values between 0-100 to cooling-device instead of remapping them using cooling-levels property? >>> >>> What would be the best practise of detecting whether the board is Khadas Edge 2? Adding new bool property, reading model propety from devicetree etc. >> >> The register DEVICE_NO should be set at 0x12 for Edge V, 0x11 for Edge 1. I don't have the number for Edge 2, perhaps you can read it ? >> >> Neil > > The DEVICE_NO register is not available for Khadas Edge 2. Here are the registers [0]. > > [0] https://dl.khadas.com/products/edge2/tools/mcu/edge2-mcu-register-description-en-v1.0-230520.pdf OK so it's basically completely different. In this case introduce a separate compatible since we can't detect it dynamically, and just add the registers with EDGE2 prefix. But keep the khadas-mcu-fan-ctrl, it will work if you pass the device type detected via the new compatible. Neil > >> >>> >>> Best regards. >>> >>>> >>>>> >>>>> Signed-off-by: Muhammed Efe Cetin >>>>> --- >>>>> drivers/thermal/khadas_mcu_fan.c | 76 ++++++++++++++++++++++++++++++-- >>>>> 1 file changed, 72 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/drivers/thermal/khadas_mcu_fan.c b/drivers/thermal/khadas_mcu_fan.c >>>>> index d35e5313b..504e7d254 100644 >>>>> --- a/drivers/thermal/khadas_mcu_fan.c >>>>> +++ b/drivers/thermal/khadas_mcu_fan.c >>>>> @@ -15,10 +15,16 @@ >>>>> #include >>>>> #define MAX_LEVEL 3 >>>>> +#define MAX_SPEED 0x64 >>>>> struct khadas_mcu_fan_ctx { >>>>> struct khadas_mcu *mcu; >>>>> unsigned int level; >>>>> + >>>>> + unsigned int fan_max_level; >>>>> + unsigned int fan_register; >>>>> + unsigned int *fan_cooling_levels; >>>>> + >>>>> struct thermal_cooling_device *cdev; >>>>> }; >>>>> @@ -26,9 +32,21 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, >>>>> unsigned int level) >>>>> { >>>>> int ret; >>>>> + unsigned int write_level = level; >>>>> + >>>>> + if (level > ctx->fan_max_level) >>>>> + return -EINVAL; >>>>> + >>>>> + if (ctx->fan_cooling_levels != NULL) { >>>>> + write_level = ctx->fan_cooling_levels[level]; >>>>> + >>>>> + if (write_level > MAX_SPEED) >>>>> + return -EINVAL; >>>>> + } >>>>> + >>>>> + ret = regmap_write(ctx->mcu->regmap, ctx->fan_register, >>>>> + write_level); >>>>> - ret = regmap_write(ctx->mcu->regmap, KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG, >>>>> - level); >>>>> if (ret) >>>>> return ret; >>>>> @@ -40,7 +58,9 @@ static int khadas_mcu_fan_set_level(struct khadas_mcu_fan_ctx *ctx, >>>>> static int khadas_mcu_fan_get_max_state(struct thermal_cooling_device *cdev, >>>>> unsigned long *state) >>>>> { >>>>> - *state = MAX_LEVEL; >>>>> + struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >>>>> + >>>>> + *state = ctx->fan_max_level; >>>>> return 0; >>>>> } >>>>> @@ -61,7 +81,7 @@ khadas_mcu_fan_set_cur_state(struct thermal_cooling_device *cdev, >>>>> { >>>>> struct khadas_mcu_fan_ctx *ctx = cdev->devdata; >>>>> - if (state > MAX_LEVEL) >>>>> + if (state > ctx->fan_max_level) >>>>> return -EINVAL; >>>>> if (state == ctx->level) >>>>> @@ -76,6 +96,47 @@ static const struct thermal_cooling_device_ops khadas_mcu_fan_cooling_ops = { >>>>> .set_cur_state = khadas_mcu_fan_set_cur_state, >>>>> }; >>>>> +static int khadas_mcu_fan_get_cooling_data_edge2(struct khadas_mcu_fan_ctx *ctx, struct device *dev) >>>>> +{ >>>>> + struct device_node *np = ctx->mcu->dev->of_node; >>>>> + int num, i, ret; >>>>> + >>>>> + if (!of_property_present(np, "cooling-levels")) >>>>> + return 0; >>>>> + >>>>> + ret = of_property_count_u32_elems(np, "cooling-levels"); >>>>> + if (ret <= 0) { >>>>> + dev_err(dev, "Wrong data!\n"); >>>>> + return ret ? : -EINVAL; >>>>> + } >>>>> + >>>>> + num = ret; >>>>> + ctx->fan_cooling_levels = devm_kcalloc(dev, num, sizeof(u32), >>>>> + GFP_KERNEL); >>>>> + if (!ctx->fan_cooling_levels) >>>>> + return -ENOMEM; >>>>> + >>>>> + ret = of_property_read_u32_array(np, "cooling-levels", >>>>> + ctx->fan_cooling_levels, num); >>>>> + if (ret) { >>>>> + dev_err(dev, "Property 'cooling-levels' cannot be read!\n"); >>>>> + return ret; >>>>> + } >>>>> + >>>>> + for (i = 0; i < num; i++) { >>>>> + if (ctx->fan_cooling_levels[i] > MAX_SPEED) { >>>>> + dev_err(dev, "MCU fan state[%d]:%d > %d\n", i, >>>>> + ctx->fan_cooling_levels[i], MAX_SPEED); >>>>> + return -EINVAL; >>>>> + } >>>>> + } >>>>> + >>>>> + ctx->fan_max_level = num - 1; >>>>> + ctx->fan_register = KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG_V2; >>>>> + >>>>> + return 0; >>>>> +} >>>>> + >>>>> static int khadas_mcu_fan_probe(struct platform_device *pdev) >>>>> { >>>>> struct khadas_mcu *mcu = dev_get_drvdata(pdev->dev.parent); >>>>> @@ -90,6 +151,13 @@ static int khadas_mcu_fan_probe(struct platform_device *pdev) >>>>> ctx->mcu = mcu; >>>>> platform_set_drvdata(pdev, ctx); >>>>> + ctx->fan_max_level = MAX_LEVEL; >>>>> + ctx->fan_register = KHADAS_MCU_CMD_FAN_STATUS_CTRL_REG; >>>>> + >>>>> + ret = khadas_mcu_fan_get_cooling_data_edge2(ctx, dev); >>>>> + if (ret) >>>>> + return ret; >>>>> + >>>>> cdev = devm_thermal_of_cooling_device_register(dev->parent, >>>>> dev->parent->of_node, "khadas-mcu-fan", ctx, >>>>> &khadas_mcu_fan_cooling_ops); >>>> >>> >> >