mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Sneddon <daniel.sneddon@linux.intel.com>
To: Ashok Raj <ashok.raj@intel.com>, X86-kernel <x86@kernel.org>,
	LKML Mailing List <linux-kernel@vger.kernel.org>
Cc: Dave Hansen <dave.hansen@intel.com>,
	Borislav Petkov <bp@alien8.de>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Subject: Re: [PATCH] x86/cpu: Remove redundant extern x86_read_arch_cap_msr()
Date: Tue, 29 Nov 2022 10:41:16 -0700	[thread overview]
Message-ID: <9f6491f7-b9c1-1450-7c2b-1b890567b21f@linux.intel.com> (raw)
In-Reply-To: <20221128172451.792595-1-ashok.raj@intel.com>

On 11/28/22 10:24, Ashok Raj wrote:
> x86_read_arch_cap_msr() has now moved to arch/x86/include/asm/cpu.h.
> Kill the redundant one in arch/x86/kernel/cpu.h
> 
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> ---
>  arch/x86/kernel/cpu/cpu.h  | 2 --
>  arch/x86/kernel/cpu/bugs.c | 1 +
>  arch/x86/kernel/cpu/tsx.c  | 1 +
>  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/cpu.h b/arch/x86/kernel/cpu/cpu.h
> index a142b8d543a3..727ef3268ffb 100644
> --- a/arch/x86/kernel/cpu/cpu.h
> +++ b/arch/x86/kernel/cpu/cpu.h
> @@ -82,6 +82,4 @@ unsigned int aperfmperf_get_khz(int cpu);
>  extern void x86_spec_ctrl_setup_ap(void);
>  extern void update_srbds_msr(void);
>  
> -extern u64 x86_read_arch_cap_msr(void);
> -
>  #endif /* ARCH_X86_CPU_H */
> diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
> index 3e3230cccaa7..a632fa07e93a 100644
> --- a/arch/x86/kernel/cpu/bugs.c
> +++ b/arch/x86/kernel/cpu/bugs.c
> @@ -33,6 +33,7 @@
>  #include <asm/e820/api.h>
>  #include <asm/hypervisor.h>
>  #include <asm/tlbflush.h>
> +#include <asm/cpu.h>
>  
>  #include "cpu.h"
>  
> diff --git a/arch/x86/kernel/cpu/tsx.c b/arch/x86/kernel/cpu/tsx.c
> index ec7bbac3a9f2..667b25936818 100644
> --- a/arch/x86/kernel/cpu/tsx.c
> +++ b/arch/x86/kernel/cpu/tsx.c
> @@ -11,6 +11,7 @@
>  #include <linux/cpufeature.h>
>  
>  #include <asm/cmdline.h>
> +#include <asm/cpu.h>
>  
>  #include "cpu.h"
>  

Reviewed-by: Daniel Sneddon <daniel.sneddon@linux.intel.com>

  reply	other threads:[~2022-11-29 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-28 17:24 Ashok Raj
2022-11-29 17:41 ` Daniel Sneddon [this message]
2023-01-10 12:18 ` [tip: x86/cpu] " tip-bot2 for Ashok Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9f6491f7-b9c1-1450-7c2b-1b890567b21f@linux.intel.com \
    --to=daniel.sneddon@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®