From: Andy Lutomirski <luto@kernel.org>
To: len.brown@intel.com
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 4/4] intel_idle: Move BYT/CHT auto-demotion fixup into fix_this_cpu
Date: Sun, 13 Mar 2016 21:48:13 -0700 [thread overview]
Message-ID: <9f68cc56173c332b37c1eb8fa672f5ea7d86d7c6.1457930807.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1457930807.git.luto@kernel.org>
In-Reply-To: <cover.1457930807.git.luto@kernel.org>
The demotion policy config registers are per-package and these CPUs
only exist in single-package variants AFAIK, so it's not stricly
necessary to fix these MSRs on each core, but fixing them on resume
is still likely to be helpful, so move them into fix_this_cpu.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/idle/intel_idle.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/idle/intel_idle.c b/drivers/idle/intel_idle.c
index e3d7d8bbc843..cbb02d28dc48 100644
--- a/drivers/idle/intel_idle.c
+++ b/drivers/idle/intel_idle.c
@@ -826,6 +826,11 @@ static void fix_this_cpu(void *dummy)
msr_bits &= ~0x2;
wrmsrl(MSR_IA32_POWER_CTL, msr_bits);
}
+
+ if (icpu->byt_auto_demotion_disable_flag) {
+ wrmsrl(MSR_CC6_DEMOTION_POLICY_CONFIG, 0);
+ wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0);
+ }
}
static const struct idle_cpu idle_cpu_nehalem = {
@@ -1084,11 +1089,6 @@ static int __init intel_idle_cpuidle_driver_init(void)
drv->state_count += 1;
}
- if (icpu->byt_auto_demotion_disable_flag) {
- wrmsrl(MSR_CC6_DEMOTION_POLICY_CONFIG, 0);
- wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0);
- }
-
return 0;
}
--
2.5.0
next prev parent reply other threads:[~2016-03-14 4:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 1:39 C1E auto-promotion suspend/resume Andy Lutomirski
2016-03-14 4:31 ` Brown, Len
2016-03-14 4:48 ` [PATCH 0/4] intel_idle: Improve MSR fixup resume handling Andy Lutomirski
2016-03-14 4:48 ` [PATCH 1/4] intel_idle: Consolidate auto-promotion/auto-demotion fixups Andy Lutomirski
2016-03-14 4:48 ` [PATCH 2/4] intel_idle: Remove a broadcast MSR fixup at boot Andy Lutomirski
2016-03-14 4:48 ` [PATCH 3/4] intel_idle: Fix MSRs after resume Andy Lutomirski
2016-03-17 19:41 ` Andy Lutomirski
2016-03-14 4:48 ` Andy Lutomirski [this message]
2016-03-14 5:24 ` C1E auto-promotion suspend/resume Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f68cc56173c332b37c1eb8fa672f5ea7d86d7c6.1457930807.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®