From: "Anwar, Md Danish" <a0501179@ti.com>
To: Jan Kiszka <jan.kiszka@siemens.com>,
MD Danish Anwar <danishanwar@ti.com>, Suman Anna <s-anna@ti.com>,
Sai Krishna <saikrishnag@marvell.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Diogo Ivo <diogo.ivo@siemens.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Roger Quadros <rogerq@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Nishanth Menon <nm@ti.com>
Cc: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srk@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add support for PA Stats
Date: Mon, 2 Sep 2024 13:21:05 +0530 [thread overview]
Message-ID: <9f7dfdc0-954c-4924-90c3-7742120b487c@ti.com> (raw)
In-Reply-To: <c7e618bd-c33e-4042-b769-392546cb9297@siemens.com>
On 9/2/2024 1:04 PM, Jan Kiszka wrote:
> On 02.09.24 09:28, Anwar, Md Danish wrote:
>>
>>
>> On 9/2/2024 12:52 PM, Jan Kiszka wrote:
>>> On 22.08.24 14:26, MD Danish Anwar wrote:
>>>> Add support for dumping PA stats registers via ethtool.
>>>> Firmware maintained stats are stored at PA Stats registers.
>>>> Also modify emac_get_strings() API to use ethtool_puts().
>>>>
>>>> This commit also maintains consistency between miig_stats and pa_stats by
>>>> - renaming the array icssg_all_stats to icssg_all_miig_stats
>>>> - renaming the structure icssg_stats to icssg_miig_stats
>>>> - renaming ICSSG_STATS() to ICSSG_MIIG_STATS()
>>>> - changing order of stats related data structures and arrays so that data
>>>> structures of a certain stats type is clubbed together.
>>>>
>>>> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
>>>> ---
>>>> drivers/net/ethernet/ti/icssg/icssg_ethtool.c | 19 ++-
>>>> drivers/net/ethernet/ti/icssg/icssg_prueth.c | 6 +
>>>> drivers/net/ethernet/ti/icssg/icssg_prueth.h | 9 +-
>>>> drivers/net/ethernet/ti/icssg/icssg_stats.c | 31 +++-
>>>> drivers/net/ethernet/ti/icssg/icssg_stats.h | 158 +++++++++++-------
>>>> 5 files changed, 140 insertions(+), 83 deletions(-)
>>>>
>>>
>>> ...
>>>
>>>> diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>>> index 53a3e44b99a2..f623a0f603fc 100644
>>>> --- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>>> +++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
>>>> @@ -1182,6 +1182,12 @@ static int prueth_probe(struct platform_device *pdev)
>>>> return -ENODEV;
>>>> }
>>>>
>>>> + prueth->pa_stats = syscon_regmap_lookup_by_phandle(np, "ti,pa-stats");
>>>> + if (IS_ERR(prueth->pa_stats)) {
>>>> + dev_err(dev, "couldn't get ti,pa-stats syscon regmap\n");
>>>> + return -ENODEV;
>>>
>>> I was just beaten for potentially not being backward compatible, but
>>> this is definitely not working with existing DTs, just ran into it.
>>>
>>
>> Jan, I had posted the DT patch needed for this [1]. But the DT patch
>> goes to different tree and it was dependent on binding patch of this
>> series. My intention was once the binding is in, I will post the DT
>> patch in the next window. Till then ICSSG driver will break here but
>> once DT gets merged it will be alright. If that's not the best solution,
>> I can post DT here, but it will need to get merged via net-next.
>>
>> [1] https://lore.kernel.org/all/20240729113226.2905928-4-danishanwar@ti.com/
>>
>
> Why not respect in the driver that the dtbinding says this property is
> only optional?
>
Sure Jan, In that case, I will send out a fix making this optional in
driver.
--
Thanks and Regards,
Md Danish Anwar
next prev parent reply other threads:[~2024-09-02 7:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 12:26 [PATCH net-next v7 0/2] Add support for ICSSG PA_STATS MD Danish Anwar
2024-08-22 12:26 ` [PATCH net-next v7 1/2] dt-bindings: soc: ti: pruss: Add documentation for PA_STATS support MD Danish Anwar
2024-08-22 12:26 ` [PATCH net-next v7 2/2] net: ti: icssg-prueth: Add support for PA Stats MD Danish Anwar
2024-09-02 7:22 ` Jan Kiszka
2024-09-02 7:28 ` Anwar, Md Danish
2024-09-02 7:34 ` Jan Kiszka
2024-09-02 7:51 ` Anwar, Md Danish [this message]
2024-08-26 16:40 ` [PATCH net-next v7 0/2] Add support for ICSSG PA_STATS patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f7dfdc0-954c-4924-90c3-7742120b487c@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=s-anna@ti.com \
--cc=saikrishnag@marvell.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®