From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933698AbcK2PAr (ORCPT ); Tue, 29 Nov 2016 10:00:47 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:45849 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933842AbcK2PAh (ORCPT ); Tue, 29 Nov 2016 10:00:37 -0500 Subject: Re: [PATCH] leds: netxbig: fix module autoload for OF registration References: <1477065125-20877-1-git-send-email-javier@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Richard Purdie , linux-leds@vger.kernel.org To: Jacek Anaszewski From: Javier Martinez Canillas Message-ID: <9f84c025-7835-1664-60df-092b80a4ade7@osg.samsung.com> Date: Tue, 29 Nov 2016 12:00:30 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477065125-20877-1-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jacek, On 10/21/2016 12:52 PM, Javier Martinez Canillas wrote: > If the driver is built as a module, autoload won't work because the module > alias information is not filled. So user-space can't match the registered > device with the corresponding module. > > Export the module alias information using the MODULE_DEVICE_TABLE() macro. > > Before this patch: > > $ modinfo drivers/leds//leds-netxbig.ko | grep alias > alias: platform:leds-netxbig > > After this patch: > > $ modinfo drivers/leds//leds-netxbig.ko | grep alias > alias: platform:leds-netxbig > alias: of:N*T*Clacie,netxbig-ledsC* > alias: of:N*T*Clacie,netxbig-leds > > Signed-off-by: Javier Martinez Canillas > --- > Any comments about this patch? Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America