From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60AD2376BE0; Wed, 10 Jun 2026 06:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781074254; cv=none; b=SSkYQSoEwCRfx3aI5OqrwVTFcWr9vX9l1hxbaWdHXsOD+h6dWA/o8x7WPF30zn5Eahix1W6rWSQ++1CBWbfyK/cekMTkLj8U6UunsH12Rl4h/pAV4m9wYD6ai+vRH3j4xNXcET06jOANCEH9IJKYuIYf73Etwy+RQoi0zFltnEY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781074254; c=relaxed/simple; bh=jxfSRulGI7pbzDMimwytnDMyFlFx/ag7yhG84WjWNUQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=np2v4ymwrVo8QCi6Ji/IiPayuHbeBZvl7wNPL4irX88m+mpEjKLdknZB77lXmwPtooFQPSsU2gtbuUMX22Or1x33883XtfLj+YyGBwburFEvvQrUKE1UP7c5JfWnA33P3Pc4r374+B3ltqnz0Gbm3jeGW++aVx/6tPbg5gk8JFI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=rd48WWnx; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="rd48WWnx" Received: from [192.168.0.43] (chfd-03-b2-v4wan-176392-cust229.vm15.cable.virginm.net [82.19.20.230]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BE335517; Wed, 10 Jun 2026 08:50:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1781074223; bh=jxfSRulGI7pbzDMimwytnDMyFlFx/ag7yhG84WjWNUQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rd48WWnx3Va71zRKz4rlsIG8eNmM44tyyYzyouJINpL7600ECYA2Aq341r7TzgLFz pWeTwO4EX4+WqSZSLK33VAF0Ag/qSGfGQjhXiQ2itQufbLxwGrMxBaJamHZqCsY7AG +MPYuC32/dRQk8tiIhTVlfldaobzFEzMm/p7nkBQ= Message-ID: <9f8551e2-eb11-4774-9573-89122a12569d@ideasonboard.com> Date: Wed, 10 Jun 2026 07:50:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] media: mali-c55: Fix clock leak on reset deassert failure To: David Carlier , Jacopo Mondi Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260609113747.39592-1-devnexen@gmail.com> Content-Language: en-US From: Dan Scally In-Reply-To: <20260609113747.39592-1-devnexen@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi David, thanks again! On 09/06/2026 12:37, David Carlier wrote: > __mali_c55_power_on() enables the clocks before deasserting the resets, > but bails out on a deassert failure without disabling them again. Both > callers treat a failed power-on as already cleaned up, so the clocks are > left enabled. > > Disable them on the error path. > > Fixes: d5f281f3dd29 ("media: mali-c55: Add Mali-C55 ISP driver") > Signed-off-by: David Carlier > --- Yep looks good: Reviewed-by: Daniel Scally > drivers/media/platform/arm/mali-c55/mali-c55-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/platform/arm/mali-c55/mali-c55-core.c b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > index ee4a42674..fb81141d1 100644 > --- a/drivers/media/platform/arm/mali-c55/mali-c55-core.c > +++ b/drivers/media/platform/arm/mali-c55/mali-c55-core.c > @@ -699,6 +699,8 @@ static int __mali_c55_power_on(struct mali_c55 *mali_c55) > mali_c55->resets); > if (ret) { > dev_err(mali_c55->dev, "failed to deassert resets\n"); > + clk_bulk_disable_unprepare(ARRAY_SIZE(mali_c55->clks), > + mali_c55->clks); > return ret; > } >