From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B57F185279 for ; Mon, 1 Jul 2024 09:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719827326; cv=none; b=OMzBRVr75nIZhEbUkbYaAwNONnNk5nk283wm7PLe46jFDAT4fPFQ7oWkdA0ApgjKDaw4CRVT7axiZzse+FtHjpIs7ryEtwsvSMYMuGRFwLV6YMKzZ7V9+l14n6sBpm0KLgCLHBY3US9+Lvoq7nA04kxmAzl0JIsMlQ+Qyrdk+0A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719827326; c=relaxed/simple; bh=Z09LYIfA/dfPotbWA569LzVRfGZJFnaGg2r3ovjw8dw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=o4QoyTNhOXILO5wQau1CaPzSvP3gL7xKjy/EmIYZsFtHlZm0Xri8utFa8/osCxx6jyppVeZFSWKOJix4pd0P58+Tnjgzzu7uaiE+Vd0SLVWgrfWLofYzZ1O+URvZ/iMKupFGLIlkbfLXzxlQR4/q6xJTSnBcXkxrCZ4uXNfLoWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sODe1-0003y0-Fp; Mon, 01 Jul 2024 11:48:21 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sODe0-006LFX-4z; Mon, 01 Jul 2024 11:48:20 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1sODe0-000QE4-0G; Mon, 01 Jul 2024 11:48:20 +0200 Message-ID: <9f87eba115b8cb3ef7499f8615ef5fc009a74f22.camel@pengutronix.de> Subject: Re: [PATCH v1 4/8] PCI: brcmstb: Use swinit reset if available From: Philipp Zabel To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Florian Fainelli , Lorenzo Pieralisi , Krzysztof =?UTF-8?Q?Wilczy=C5=84ski?= , Rob Herring , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Date: Mon, 01 Jul 2024 11:48:19 +0200 In-Reply-To: <20240628205430.24775-5-james.quinlan@broadcom.com> References: <20240628205430.24775-1-james.quinlan@broadcom.com> <20240628205430.24775-5-james.quinlan@broadcom.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hi Jim, On Fr, 2024-06-28 at 16:54 -0400, Jim Quinlan wrote: > The 7712 SOC adds a software init reset device for the PCIe HW. > If found in the DT node, use it. >=20 > Signed-off-by: Jim Quinlan > --- > drivers/pci/controller/pcie-brcmstb.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controll= er/pcie-brcmstb.c > index 4104c3668fdb..0f1c3e1effb1 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -266,6 +266,7 @@ struct brcm_pcie { > struct reset_control *rescal; > struct reset_control *perst_reset; > struct reset_control *bridge; > + struct reset_control *swinit; > int num_memc; > u64 memc_size[PCIE_BRCM_MAX_MEMC]; > u32 hw_rev; > @@ -1626,6 +1627,25 @@ static int brcm_pcie_probe(struct platform_device = *pdev) > dev_err(&pdev->dev, "could not enable clock\n"); > return ret; > } > + > + pcie->swinit =3D devm_reset_control_get_optional_exclusive(&pdev->dev, = "swinit"); > + if (IS_ERR(pcie->swinit)) { > + ret =3D dev_err_probe(&pdev->dev, PTR_ERR(pcie->swinit), > + "failed to get 'swinit' reset\n"); > + goto clk_out; > + } > + > + ret =3D reset_control_assert(pcie->swinit); > + if (ret) { > + dev_err_probe(&pdev->dev, ret, "could not assert reset 'swinit'\n"); > + goto clk_out; > + } else { No need for an else branch here. > + ret =3D dev_err_probe(&pdev->dev, reset_control_deassert(pcie->swinit)= , > + "could not de-assert reset 'swinit' after asserting\n"); Please don't call dev_err_probe() when reset_control_deassert() returns 0. > + if (ret) > + goto clk_out; > + } > + > pcie->rescal =3D devm_reset_control_get_optional_shared(&pdev->dev, "re= scal"); > if (IS_ERR(pcie->rescal)) { > ret =3D PTR_ERR(pcie->rescal); regards Philipp