From: Sinan Kaya <okaya@codeaurora.org>
To: Timur Tabi <timur@codeaurora.org>, linux-pci@vger.kernel.org
Cc: linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Jones <pjones@redhat.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"open list:EFIFB FRAMEBUFFER DRIVER"
<linux-fbdev@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] efi/fb: Convert PCI bus address to resource if translated by the bridge
Date: Wed, 16 May 2018 14:41:12 -0400 [thread overview]
Message-ID: <9f8ea8f6-6005-1b46-4d75-4f89e04ad9c1@codeaurora.org> (raw)
In-Reply-To: <3120434b-9831-bf33-25b8-11aba1c1b648@codeaurora.org>
On 5/16/2018 2:31 PM, Timur Tabi wrote:
> On 05/16/2018 01:23 PM, Sinan Kaya wrote:
>> + win_start = window->res->start - window->offset;
>
> Can you guarantee that window->res->start is always >= window->offset?
>
Resource offset is generally 0 when not translating or a positive number
that you subtract from the resource start to reach to the translating window.
Having a bigger offset than resource start should be considered a BIOS bug.
>> + win_size = window->res->end - window->res->start + 1;
>
> Use resource_size() instead.
>
I'll fix it.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-05-16 18:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 18:23 Sinan Kaya
2018-05-16 18:30 ` Sinan Kaya
2018-05-16 18:31 ` Timur Tabi
2018-05-16 18:41 ` Sinan Kaya [this message]
2018-05-17 10:17 ` Robin Murphy
2018-05-17 13:05 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f8ea8f6-6005-1b46-4d75-4f89e04ad9c1@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pjones@redhat.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®