From: "Kammela, Gayatri" <gayatri.kammela@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>, kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [pdx86-platform-drivers-x86:review-hans 66/68] drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume'
Date: Fri, 8 Jul 2022 18:28:45 -0700 [thread overview]
Message-ID: <9f94800b-6c32-3fc0-97c4-728fc4641aef@linux.intel.com> (raw)
In-Reply-To: <c3982024-3351-956f-605f-ef8453848ff7@redhat.com>
On 7/8/2022 7:44 AM, Hans de Goede wrote:
> Hi,
>
> On 7/4/22 12:51, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git review-hans
>> head: 530ef2a6e81c74c19f918713e519e85652e53a83
>> commit: 1039bb2698ab299a1fc30a4fc2df237867c089e0 [66/68] platform/x86/intel/vsec: Add PCI error recovery support to Intel PMT
>> config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220704/202207041814.S03OvoFK-lkp@intel.com/config)
>> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
>> reproduce (this is a W=1 build):
>> # https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/commit/?id=1039bb2698ab299a1fc30a4fc2df237867c089e0
>> git remote add pdx86-platform-drivers-x86 https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git
>> git fetch --no-tags pdx86-platform-drivers-x86 review-hans
>> git checkout 1039bb2698ab299a1fc30a4fc2df237867c089e0
>> # save the config file
>> mkdir build_dir && cp config build_dir/.config
>> make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/intel/
>>
>> If you fix the issue, kindly add following tag where applicable
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/platform/x86/intel/vsec.c:475:6: warning: no previous prototype for 'intel_vsec_pci_resume' [-Wmissing-prototypes]
>> 475 | void intel_vsec_pci_resume(struct pci_dev *pdev)
>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +/intel_vsec_pci_resume +475 drivers/platform/x86/intel/vsec.c
>>
>> 474
>> > 475 void intel_vsec_pci_resume(struct pci_dev *pdev)
>> 476 {
>> 477 dev_info(&pdev->dev, "Done resuming PCI device\n");
>> 478 }
>> 479
>>
>
> I've squashed a patch marking intel_vsec_pci_resume() as static into my
> review-hans branch.
Thank you Hans!
>
> Regards,
>
> Hans
>
prev parent reply other threads:[~2022-07-09 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-04 10:51 kernel test robot
2022-07-08 14:44 ` Hans de Goede
2022-07-09 1:28 ` Kammela, Gayatri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f94800b-6c32-3fc0-97c4-728fc4641aef@linux.intel.com \
--to=gayatri.kammela@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®