From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 931F2C433ED for ; Fri, 21 May 2021 01:15:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7574760FEF for ; Fri, 21 May 2021 01:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236534AbhEUBQY (ORCPT ); Thu, 20 May 2021 21:16:24 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3635 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236106AbhEUBQX (ORCPT ); Thu, 20 May 2021 21:16:23 -0400 Received: from dggems701-chm.china.huawei.com (unknown [172.30.72.59]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FmT9k1rJDzmWpV; Fri, 21 May 2021 09:12:42 +0800 (CST) Received: from dggemx753-chm.china.huawei.com (10.0.44.37) by dggems701-chm.china.huawei.com (10.3.19.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 21 May 2021 09:14:59 +0800 Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 21 May 2021 09:14:58 +0800 Subject: Re: [PATCH -next] erofs: fix error return code in erofs_read_superblock() To: Gao Xiang , Dan Carpenter , Wei Yongjun CC: , , "Hulk Robot" , References: <20210519141657.3062715-1-weiyongjun1@huawei.com> <20210520053226.GB1955@kadam> <20210520084023.GA5720@hsiangkao-HP-ZHAN-66-Pro-G1> From: Chao Yu Message-ID: <9f96b12f-b05b-c118-4391-448f780702ff@huawei.com> Date: Fri, 21 May 2021 09:14:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20210520084023.GA5720@hsiangkao-HP-ZHAN-66-Pro-G1> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/20 16:40, Gao Xiang wrote: > Hi Yongjun and Dan, > > On Thu, May 20, 2021 at 08:32:26AM +0300, Dan Carpenter wrote: >> On Wed, May 19, 2021 at 02:16:57PM +0000, Wei Yongjun wrote: >>> 'ret' will be overwritten to 0 if erofs_sb_has_sb_chksum() return true, >>> thus 0 will return in some error handling cases. Fix to return negative >>> error code -EINVAL instead of 0. >>> >>> Reported-by: Hulk Robot >>> Signed-off-by: Wei Yongjun >> >> You need to add Fixes tags to bug fix patches and you need to ensure >> that the authors of the Fixes commit are CC'd so they can review your >> fix. get_maintainer.pl will add the author automatically, but normally >> I like to put them in the To header to make sure they see it. >> >> Fixes: b858a4844cfb ("erofs: support superblock checksum") > > The commit and the tag look good to me (sorry for a bit delay on this), > > Fixes: b858a4844cfb ("erofs: support superblock checksum") > Cc: stable # 5.5+ > Reviewed-by: Gao Xiang Reviewed-by: Chao Yu Thanks, > > (will apply to dev-test for a while and then to -next.) > > Thanks, > Gao Xiang > > . >