From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99413C344B for ; Mon, 30 Mar 2026 10:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774868138; cv=none; b=dR/4U9PXKNaB6MkrIisThTS3foY+urqhlFiafH+Adocl+1oyQKw1EnWpCuFf93pxwD/Hb2Cu8Ve6MR5JWqIJ+g7TC/uz8KG84unnACOK9qg17JIjySyiS+y+VQqu5kMS6J1xRz7HYhnSmcnh0um52qq5qYfPH4TEg86olrKNCw0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774868138; c=relaxed/simple; bh=IxVCxS3KsrL7X9+TLUafohMnmgl8E7kaA4sFH55EiJk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZEPLW87ZjGZfUsYJM4zy6hiWab+vzZgvKXwgVrDSFFAk2z0tzegWgmxbq62f2DfuH6S8VFlWHjvDK9Yqdz9MfvQhZZmr2I7iMw3KMMnMdUluPlyVTsrr8r7W5+O1JYz2HutXbGGOoUMtWDI57WTBaozMI1QyQmttymd68eQ6xYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lX4PfEcQ; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lX4PfEcQ" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4853c1ca73aso42823055e9.2 for ; Mon, 30 Mar 2026 03:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774868135; x=1775472935; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=IxVCxS3KsrL7X9+TLUafohMnmgl8E7kaA4sFH55EiJk=; b=lX4PfEcQ+SUBKWkBRDMsTlfA0M0wFgK9o7iMLad0kQhaXlWLKmgwBsYQM3+Dx5uflq YQpGZySYF1mi7WA2CcDp/3ZRmCgjPFIBS6/7rVKadePQszyr53vRjQ0s3wv9gMrv6jMl //vMbEZk+WlGwgaXQxxICdaJgIXjIzQLL1n57WxXy+oHfqZemnlcRqSG2xLWf0BOyzbB vPVKD48oI0Zq/9pkQiV/ewez48+7R4YidV28uQNTfHfmMWAbfWeHefChfCRUSftgSBR8 D+g94L9JCCxshU96wSqeguMLA4ipw/rBgS1pZROCNSycbgN+sJZZAiEFv5YKD7UGHOa4 GvdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774868135; x=1775472935; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IxVCxS3KsrL7X9+TLUafohMnmgl8E7kaA4sFH55EiJk=; b=jTgiaZyyHKXc9Lku0+YMCekxfPM6R2ok82xuuIjC/RFo5WFVO8naFkz4Muf4SXKH6C 74h6hSamkbR6B4PJSBjIauyR9ST7Tb0yPRVK4swrN3p5Hfrzzngya4sW2GbnR2cZQbdP XSMgZKtFD+w/kKtA9iAgnjc7id8IClUoZZ85qgOebSWnU2gi4hHiHLqe+I1Z7EfhR1g0 a82gZ/6Kp1sRoFUosGg9WOSfgTyaJfOIsY534krZ73zTl11j1o4pgld0fh9Gno+qJCky 4ViOE7EJQdwuMcD3vf60HKGYtjInb/ejvjqy5ldXA6UJfOuowFbXpIXI5MaiArPnnwwH 8YKg== X-Forwarded-Encrypted: i=1; AJvYcCXUoH36jcrc/YlUjxmj/eMqkcqy0N4zq8NmB+kC4+cW0+nZRPABpwNsL3yf/79Ih8nDv2EHZUi7Z758SXI=@vger.kernel.org X-Gm-Message-State: AOJu0YykPe/J7yOO7pfcDw7l1AmymzqcUJnSka2Sfhqx4dgF7g2j2wi2 xh+K9SyUFAF1dz2mU41vCoCa2bd44FVuYvcgSeBln36mdL7ebbaFqIxy4scncV/lapA= X-Gm-Gg: ATEYQzxyCit/A11w6di2IBvWy/meB3T2W2vuoswIPr2/ypH+E2fxeqaLtRuQIC8RjT/ WLjrTx+bSjxuiiNU1DjQCt7odL7LZj2Pl99XJUJstZ4YYpts8345a2HriKIe7dF/z/No0a+P+UG jg4Hwq5SxGASY7VJ7P+wE98a36L6zU6MUeYkcbVxbOPNSGplKXYHdMdhbhCNDxvMZdihMGHXO6f ixNHmZMS+kq1GJ4deL4F7bjUu9g+9LFZ3aWd02dL3Tw6rWqDS2nzOjOtHpF6r0Qi6GsH4X60haX rksASFpvu1Tvzb3pcNtii/TFv5s7KinUcs1YEr25BieC3Ae3jm19ijRxJ//fohwpF4KFhV8sNOs 4S4UldnFRmK1rzGw6jfQSD3R0eASYlrT0C8vemRvudSNSKSguy+9YflMcNay8BfCkiLBdmyO5R2 WwR0V77SzCgBV6XAuzdbsDWyRlSTI+ X-Received: by 2002:a05:600c:4e08:b0:487:1fb4:7b3 with SMTP id 5b1f17b1804b1-48727ef0cc2mr216860995e9.23.1774868135275; Mon, 30 Mar 2026 03:55:35 -0700 (PDT) Received: from draszik.lan ([212.129.78.46]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48730629033sm164969365e9.6.2026.03.30.03.55.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Mar 2026 03:55:34 -0700 (PDT) Message-ID: <9f9d400b84512be41d47099d916338be5662061e.camel@linaro.org> Subject: Re: [PATCH v8 07/10] pmdomain: samsung: add support for google,gs101-pd From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski Cc: Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson , Liam Girdwood , Mark Brown , Peter Griffin , Tudor Ambarus , Juan Yescas , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Marek Szyprowski Date: Mon, 30 Mar 2026 11:55:30 +0100 In-Reply-To: <177409897341.266364.10743294916208405425.b4-review@b4> References: <20260318-gs101-pd-v8-0-241523460b10@linaro.org> <20260318-gs101-pd-v8-7-241523460b10@linaro.org> <177409897341.266364.10743294916208405425.b4-review@b4> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8+build1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-03-21 at 14:16 +0100, Krzysztof Kozlowski wrote: > On Wed, 18 Mar 2026 15:27:52 +0000, Andr=C3=A9 Draszik wrote: > > On Google gs101, direct mmio register access to the PMU registers > > doesn't work and access must happen via a regmap created by the PMU > > driver instead. > >=20 > > Add a flag to the device match data to denote this case, and obtain > > the regmap using the parent node in DT if true, while keeping to use > > the traditional direct mmio regmap otherwise. > >=20 > > Additionally, the status is just one bit on gs101. > >=20 > > Tested-by: Marek Szyprowski > > Signed-off-by: Andr=C3=A9 Draszik >=20 > There are few reviews from Sashiko which seem legitimate. Please check > them. If they are false positives, just reply that you carefully went > through them. Thanks for pointing out Sashiko, seems like a useful tool! I'll go through it. A.