From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbdJFJTp (ORCPT ); Fri, 6 Oct 2017 05:19:45 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34569 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbdJFIzF (ORCPT ); Fri, 6 Oct 2017 04:55:05 -0400 X-Google-Smtp-Source: AOwi7QAJ7i4xcoKzRrMQi0M28lppP6U3sF5Rpjs6eR3cRt5vFE4J+bFV0et5Wf5MNK+2ZWhFW0y4hA== Subject: Re: [PATCH] kvm, mm: account kvm related kmem slabs to kmemcg To: Shakeel Butt , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Vladimir Davydov , Michal Hocko , Greg Thelen Cc: Andrew Morton , linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Borntraeger , James Hogan , Christoffer Dall , Paul Mackerras , David Gibson References: <20171006010724.186563-1-shakeelb@google.com> From: Paolo Bonzini Message-ID: <9f9dce19-3ee2-ace7-e54a-9c8f9b89080c@redhat.com> Date: Fri, 6 Oct 2017 10:55:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171006010724.186563-1-shakeelb@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/10/2017 03:07, Shakeel Butt wrote: > The kvm slabs can consume a significant amount of system memory > and indeed in our production environment we have observed that > a lot of machines are spending significant amount of memory that > can not be left as system memory overhead. Also the allocations > from these slabs can be triggered directly by user space applications > which has access to kvm and thus a buggy application can leak > such memory. So, these caches should be accounted to kmemcg. > > Signed-off-by: Shakeel Butt > --- > arch/x86/kvm/mmu.c | 4 ++-- > virt/kvm/kvm_main.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index eca30c1eb1d9..87c5db9e644d 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -5475,13 +5475,13 @@ int kvm_mmu_module_init(void) > > pte_list_desc_cache = kmem_cache_create("pte_list_desc", > sizeof(struct pte_list_desc), > - 0, 0, NULL); > + 0, SLAB_ACCOUNT, NULL); > if (!pte_list_desc_cache) > goto nomem; > > mmu_page_header_cache = kmem_cache_create("kvm_mmu_page_header", > sizeof(struct kvm_mmu_page), > - 0, 0, NULL); > + 0, SLAB_ACCOUNT, NULL); > if (!mmu_page_header_cache) > goto nomem; > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 9deb5a245b83..3d73299e05f2 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -4010,7 +4010,7 @@ int kvm_init(void *opaque, unsigned vcpu_size, unsigned vcpu_align, > if (!vcpu_align) > vcpu_align = __alignof__(struct kvm_vcpu); > kvm_vcpu_cache = kmem_cache_create("kvm_vcpu", vcpu_size, vcpu_align, > - 0, NULL); > + SLAB_ACCOUNT, NULL); > if (!kvm_vcpu_cache) { > r = -ENOMEM; > goto out_free_3; > Reviewed-by: Paolo Bonzini Adding maintainers for other architectures, because they probably want to do something similar. Paolo