From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C65C9294A05 for ; Fri, 23 May 2025 15:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748014206; cv=none; b=WKkSlfviHJDj5qF8cEbNbEPxFXqyN5sXDsiqREQ8IolkqEWNrcZT6ZcT8I6+eVb2lf6mwj8pCOLeio+5cwoYLVy//51MjofJ7ce85FRI1JF3CNeizlDUZmP7B1ZEdhyd7v+xhUhkkYfz42wHiYgJZPAosg+MGEWstqwdscMq/qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748014206; c=relaxed/simple; bh=ap09PPMpRfnB0hj509ImQDib3x/WBo05UmUabOlkmMQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rjWbl8qL1ap3GJG2lrUArG4ArL7DlZe912ke0hPqeSYPMvRtfudZtOS1Q7ZNBsPw9GP7JX2R9WoqaOGO/Glx27z+EnK2lnS7YVqxIIzohCXFE3LStJ/5seP2YPPiNZMCyjnym31/1u8DZzgFLIqYs/LdXCx1uYsaANk56Jwqt5o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=au2b19yy; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="au2b19yy" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-231fc83a33aso80015ad.0 for ; Fri, 23 May 2025 08:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1748014204; x=1748619004; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZysAlyZtrotmIvgcjSaWUnFpu8BmC8DX1etzBHhsTSU=; b=au2b19yy/hEXIDR70yx3j2KpImtXIwV86QHhgBsABWTIW4fWk+b0jjYDAaYivlApNN 3jZBrz3D5sO2NmM+ivU5iQcspLE/S+Bcw+PTQ7tOSwpspQFaAY7DxJrFvzNET4WfpJiN UzmBMG+vKTwpiErtkNIFaDBauBf5BoflY+NPKyw9nYhh+w3nqhm79+Da63JwtlM69GNZ 7irLjmIDHXusZULnNboj6lzXnEh1q3htFJQxzrRhtFJaiWURlaG3gqwYD+iVJvHKyvCf Pxfp32tkCekGCQbwHoKgsWhRGksYzZGWI/N8cd+oKGUyS3uSZrnT2RXJeaEYreMMlPbK KhtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748014204; x=1748619004; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZysAlyZtrotmIvgcjSaWUnFpu8BmC8DX1etzBHhsTSU=; b=j8ytwHNCTPfIFCWa5Ptgf27BodK92srgZtBZdrdQCA4S6dJf3TfPed8fwmrUtq3mxH us39SPbEUvCEvTdXqFRNQ5edjGLEogs8Ebm/8/snX8TrOA8F9qxHOeZTlG7cZMk2jGY8 e2Ga7Su0rotXJTQg6RxOXwLpt7dAZWCMMIixRof3a30Giu1fH2EEifNsWoBfRAEEuEJW tnLb8sWGH3TobYBH3DHsCi/0P/0ey6wyC6dcwQPoou5TZq/l29pWYgX01RqHH+BOx0CR qdAOf/7VMcg4N2VLGNWm763YZ5Rokq6OUvTPaSOiY24wOLVRuqBE4WXc+W5uOpqQfq0J pxkQ== X-Forwarded-Encrypted: i=1; AJvYcCXW8cRQT0k1r7+L+D0AH9Wsmk6gcY1O8HrotliG0qKSaTTBEBAhYvmLyTwzXA3XSzvg+g3vqqN33jUvQi8=@vger.kernel.org X-Gm-Message-State: AOJu0YyUIAiM+yKmzTbbsR7Lmv3ruke/1oDJj8yVNwYTeX/8Jbu7w7Yi iUyUEc1yf2qxKzPN2HADjjtCpFdkFjPAllatXyZ5umXetsW48ArOIYZTHD3/BKHMuoc= X-Gm-Gg: ASbGncu7tuZBv+FPWcd1qiNe/C4jU3COgR3Bw8D1jGVmF+xNrkp/+XgX9vzalRFyP92 7tArVbZEDwRRDIZV04iv3fFOBwcifDx6kQXV0uDAiOcIMs2/JGYCdXylJFelwtBOps4Y9pdwDZE cGR9qkjiFk6bbm7ZN7OUTb1POGjbIiGEu1lhrnIv2ztlh8cNRyCyujx7kwP7U1g45VCkEB6i6v/ 5akqQ6bvZJw2P0zm1ffIliZMMbOh97Hug/AarpBppUpBJHvCCO+Dbl9ypKj3v77RbZD5H07ukVw /NN9BWdYfo95bUzjWW3bvf4CSuuKuRTJ1b3BgAuAP5O+xOZ0AV6MONn/9Nz18odU3p8hI4q8eiX jiBR4lJgj/mF75xKyLF21 X-Google-Smtp-Source: AGHT+IEdlANg8wwO3+blZsMeIKZDl/aWdfuOZvDvj8FeW02HTI0mk6reEwHEpni5Wcy/mFcYlo/kjQ== X-Received: by 2002:a17:902:dac7:b0:224:e0f:4b5 with SMTP id d9443c01a7336-231de351d32mr381454745ad.7.1748014204025; Fri, 23 May 2025 08:30:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e17:9700:16d2:7456:6634:9626? ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-231d4ed195csm125049005ad.212.2025.05.23.08.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 May 2025 08:30:03 -0700 (PDT) Message-ID: <9f9e2869-725d-4590-887a-9b0ef091472e@rivosinc.com> Date: Fri, 23 May 2025 17:29:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 13/14] RISC-V: KVM: add support for FWFT SBI extension To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: Samuel Holland , Andrew Jones , Deepak Gupta , Charlie Jenkins , Atish Patra , linux-riscv References: <20250523101932.1594077-1-cleger@rivosinc.com> <20250523101932.1594077-14-cleger@rivosinc.com> Content-Language: en-US From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 23/05/2025 15:05, Radim Krčmář wrote: > 2025-05-23T12:19:30+02:00, Clément Léger : >> +++ b/arch/riscv/kvm/vcpu_sbi_fwft.c >> +static const enum sbi_fwft_feature_t kvm_fwft_defined_features[] = { >> + SBI_FWFT_MISALIGNED_EXC_DELEG, >> + SBI_FWFT_LANDING_PAD, >> + SBI_FWFT_SHADOW_STACK, >> + SBI_FWFT_DOUBLE_TRAP, >> + SBI_FWFT_PTE_AD_HW_UPDATING, >> + SBI_FWFT_POINTER_MASKING_PMLEN, >> +}; > > How will userspace control which subset of these features is allowed in > the guest? > > (We can reuse the KVM SBI extension interface if we don't want to add a > FWFT specific ONE_REG.) Hi Radim, I didn't looked at that part. But most likely using the kvm one reg interface seems ok like what is done for STA ? We could have per feature override with one reg per feature. Is this something blocking though ? We'd like to merge FWFT once SBI 3.0 is ratified so that would be nice not delaying it too much. I'll take a look at it to see if it isn't too long to implement. Thanks, Clément > > Thanks.