From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3703D277017 for ; Tue, 24 Mar 2026 05:15:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774329327; cv=none; b=CXNGWp+YBqZfJkNB3I1E052KloKBbSXA5qJqLX3/1SWhSxbV8bJ2NPAXQwXVgil+m9ZGckLwN9SItTcXjksgEwRGo5+sYIaafucByxzSxAVaGre85va7FHFKrErPjhPqwedaioiwQW92izYdMR1PxNGNXhUDTwhF3wOMPa8Lmuw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774329327; c=relaxed/simple; bh=mFSN/Scch+iSBbvGZ6JEeuNoSUnRF4fKrQBINnoNrnQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZErtY13pVlBv25kfrz+PbAt3xZMRCUdAdvk3HSAEaMFOaoaUEayIHqIr+PTB7NRDdxcnEgJS3JnIohWMkEWvHHsACHJnKyiAhp9UHle/giwwmz4jy91MWogOcF/bV6ePLEZndZzPhtLWtkfwfxnJdXH2ibU4Fa7MtHlCxctn1xQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LKWhIp53; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U007OXlP; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LKWhIp53"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U007OXlP" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O37vKD618735 for ; Tue, 24 Mar 2026 05:15:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fV7aXshRMXgRNymfOfiTCp/pI6NQFCBxOCj9Tnvy50U=; b=LKWhIp53IeBe/dwx 4urY0ObI825FLxF3O8dMSncDZ8V/u23uu/QS9JN2JF5rU4YqGKbMGkKzttcR62r3 br9Jt0Fi/OZpglK5hXZr4uWxhfG8l2OQz35eu4nxVoWpviLjURzHjFYI8W+Bccd3 mz8mQLFaam8XxQ2FCVfTzykwH0DVQWEt8doRtHz9RFgnC1b8fq2COu4leHEThhLa j7n9X/vQ0cTRSeF/DM0EUsY/0DV0jNEVnYsbcbyAl88EHA6y9bS/hD7qcj7K8Nxx 2ofjNGepfdwaRNWxsNZg/CM/C1MmgxXjKb1owNKz/A50DhIBDYYaz340FYBMDDM8 kza3ww== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d31jgm4sm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 05:15:25 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2aecfe69196so65204905ad.1 for ; Mon, 23 Mar 2026 22:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774329325; x=1774934125; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fV7aXshRMXgRNymfOfiTCp/pI6NQFCBxOCj9Tnvy50U=; b=U007OXlPdedH4Z54a3RyFfMYQb6jLJc14cdfklwHgIZUwohSs0YH6o5l9/9mSs3vG7 uFLPSb14DYrw7VlmcSOPT9bcPm9J+9nHVjCfSibU5HSHOCC6cwWipRc5pEP7LsuMonUu MgUN/NrdS1/ZDmJogenGjMP+/gzuzavDv0hYdxyiZL1UojIhoBo9yiY4yee+nKov4y+F cHcZsHYk42CPB5abSBjLMB4Aa1qyMIjODxyWcuNGUAnAyTJ/cEEYaDBWwPDPKItmVhFd Qrw52Ri4jk9o4JSxyowdZBN98Bq5cd1wVhvsfPCleo+rgf0rF103x/UBGx2YePqpdZa6 814g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774329325; x=1774934125; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fV7aXshRMXgRNymfOfiTCp/pI6NQFCBxOCj9Tnvy50U=; b=rrodVGYcGP3FNPuQZFrAZNWlJd6C7fOHgl1vcbVWqxTjYxEANK9Ra/mnthjtmyAW2M Ipt8ISi4a3fNbJj+bpctEfEEJg/HGe5x+bcyQTDLpdjQ5eauhnRJLWMyqEy52ZzxqmRS hau16u1sACpgZobNm67hl9OLcMvLPMheTUt45vhvxDH5Uoho2hZ1q6CW21sU5NexWTSG jOLnWUjcgLcmtva/mhJNi5d7mYPQBhstiVOZsPYjrwW9PQFSOuL123Y9osmcWar2AS5p VLD36pkRh9WWFKuzjpg8xaQC5xLALsQogPsJbSNm8ffXUTh68GCdiL7PepCiyE9jtRbS vlnQ== X-Forwarded-Encrypted: i=1; AJvYcCX9c6ukUbUyuoT5Lgo85eEnY0cFsVr5jAnolbMx/MaVLVgSD9nRNpWfByK+x9j/GNDYHCEbFG83x4kqRIY=@vger.kernel.org X-Gm-Message-State: AOJu0YynF5tbJAicU2p7hAOxhBEI0rEjw8ra0sGRd2+Io0dh8rpeLoZI tAVsuYaTADBvijYLEa94x7ZSK3o/MzbiQX/vIsBf5YVY8/U1ziyNTyjfecQFhzr5MNsbgCeeb8A vtn/7HdiYH5iyr4c5a03OCZcGNXvCcwTXnJVvAlNw2Ozv4nQcvEuI5QJ/IvHsBC4q99c= X-Gm-Gg: ATEYQzw2UTJ2EwYt4+MXv0AcdDMdJbsQaXWjLgOiAR6Pwwqa51ok/mhgsI/MrpbKodA CcJAnAhTfjQhxgKrU9N5l523Ry2BN+I/ib2XzlLeFye1BtbaCPLr32UVzWvlBp64xuyoRYeesn/ zB4pLT6lD4Mi+zjZm3L8fqSKBvXbZr0BJLqPGaJW9Th9El1/hqiXZ2tX8OUiaE2inUoVOmj/z3F tB6ttNav77WfY62rIODd5A+AyxBs3QC9Jm2vD+KH/cwr0EtCUy7oDpRZlI5F92ap2zcJ33CDbkH R+VuteFMwLu/KVb4lPd46CnLZvvVfUhoPbDxahFz1cCzTKZs+CG9RunCct8GvaS6MJHE4FxdWd4 5LN7f1vEqL2zZEzzgpyEKnS4g3PR/uwEHXhi2wAAEvmDRL23VKCpbiw== X-Received: by 2002:a17:902:d48a:b0:2ae:6457:3099 with SMTP id d9443c01a7336-2b08277cae4mr133308605ad.26.1774329324527; Mon, 23 Mar 2026 22:15:24 -0700 (PDT) X-Received: by 2002:a17:902:d48a:b0:2ae:6457:3099 with SMTP id d9443c01a7336-2b08277cae4mr133308175ad.26.1774329323989; Mon, 23 Mar 2026 22:15:23 -0700 (PDT) Received: from [10.0.0.3] ([106.222.233.113]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b08366c74dsm174187005ad.62.2026.03.23.22.15.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 22:15:23 -0700 (PDT) Message-ID: <9fa40f68-54f4-d684-9e80-511c1ab230f2@oss.qualcomm.com> Date: Tue, 24 Mar 2026 10:45:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 2/7] media: iris: switch to hardware mode after firmware boot Content-Language: en-US To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , Conor Dooley , Saravana Kannan , Joerg Roedel , Will Deacon , Robin Murphy , Stefan Schmidt , Hans Verkuil , Krzysztof Kozlowski , Vishnu Reddy , Hans Verkuil Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Bryan O'Donoghue References: <20260313-kaanapali-iris-v3-0-9c0d1a67af4b@oss.qualcomm.com> <20260313-kaanapali-iris-v3-2-9c0d1a67af4b@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: <20260313-kaanapali-iris-v3-2-9c0d1a67af4b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 9erCfXNYBMOIEtjupUqjuDCA10EH-zc1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA0MSBTYWx0ZWRfX3O19ADP6LbUw /M5grIgn2tFMTTy5L82dyKe+Npc72v31cHorVu668KKlWktfRLKrc2Wi6eD8Defk7INZdK9AoHp VDrIZZplRMwQ44uoq6qi9JqfGEfUQ/8uOMMu8FixEJo3UYPlJxl0FnuErvr+n4LMPzjXlPq3jqz Chnh9kZEhGpq2c6KtMtKedoO13tA1ISbAxlCTKsf2RUOS4zFvnDJrxxs6seCj7vmanRDD3cTVH7 mtw1tu2wy3AmOgzSZaIaD+0t+kgW7Zl6Zr88aYEZBLgNopxUv7g1oVd4oZWsbuQTj0I+bj2SGO/ Qn9fBKJpqCj0IetIe+1xmyaOcPFI/o455EcJSDWu07CRmjLEp+d1031LBJlwwRn7ZdXjPGNW31C TX4PhVzGZiKFSTkwDqNJuhLpapQFuyyLfyXklYFG1TWDgXjLJZFxusrV6vQUr286bBLOpU7JOso krzlcP6CE8qqox+K/PA== X-Authority-Analysis: v=2.4 cv=CMInnBrD c=1 sm=1 tr=0 ts=69c21ded cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=hbzS8gabZINpAvasuVNEhA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=dE1MpONsbtOZy1RxgbwA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: 9erCfXNYBMOIEtjupUqjuDCA10EH-zc1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_01,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240041 On 3/13/2026 6:49 PM, Vikash Garodia wrote: > Currently the driver switches the vcodec GDSC to hardware (HW) mode > before firmware load and boot sequence. GDSC can be powered off, keeping > in hw mode, thereby the vcodec registers programmed in TrustZone (TZ) > carry default (reset) values. > Move the transition to HW mode after firmware load and boot sequence. > > The bug was exposed with driver configuring different stream ids to > different devices via iommu-map. With registers carrying reset values, > VPU would not generate desired stream-id, thereby leading to SMMU fault. > > For vpu4, when GDSC is switched to HW mode, there is a need to perform > the reset operation. Without reset, there are occassional issues of > register corruption observed. Hence the vpu GDSC switch also involves > the reset. > > Fixes: dde659d37036 ("media: iris: Introduce vpu ops for vpu4 with necessary hooks") > Co-developed-by: Vishnu Reddy > Signed-off-by: Vishnu Reddy > Signed-off-by: Vikash Garodia > --- > drivers/media/platform/qcom/iris/iris_core.c | 4 ++++ > drivers/media/platform/qcom/iris/iris_hfi_common.c | 4 ++++ > drivers/media/platform/qcom/iris/iris_vpu2.c | 1 + > drivers/media/platform/qcom/iris/iris_vpu3x.c | 9 +++----- > drivers/media/platform/qcom/iris/iris_vpu4x.c | 24 ++++++++++++---------- > drivers/media/platform/qcom/iris/iris_vpu_common.c | 16 +++++++++------ > drivers/media/platform/qcom/iris/iris_vpu_common.h | 3 +++ > 7 files changed, 38 insertions(+), 23 deletions(-) > Reviewed-by: Dikshita Agarwal Thanks, Dikshita