From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752783AbcFOBYs (ORCPT ); Tue, 14 Jun 2016 21:24:48 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:43779 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbcFOBYq (ORCPT ); Tue, 14 Jun 2016 21:24:46 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: frank.wang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <5ec73b731a669b2448a6d2f3ea86ce8a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 1/2] Documentation: bindings: add DT documentation for Rockchip USB2PHY To: =?UTF-8?Q?Heiko_St=c3=bcbner?= References: <1465783810-18756-1-git-send-email-frank.wang@rock-chips.com> <1465783810-18756-2-git-send-email-frank.wang@rock-chips.com> <22577234.U1lnbZuDkj@diego> <3008400.RaKLTh6Yt6@diego> Cc: dianders@chromium.org, linux@roeck-us.net, groeck@chromium.org, jwerner@chromium.org, kishon@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, xzy.xu@rock-chips.com, kever.yang@rock-chips.com, huangtao@rock-chips.com, william.wu@rock-chips.com, frank.wang@rock-chips.com From: Frank Wang Message-ID: <9fa6e288-a6c5-eee7-8cb3-ef52b6a9e6f7@rock-chips.com> Date: Wed, 15 Jun 2016 09:24:28 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <3008400.RaKLTh6Yt6@diego> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2016/6/14 21:28, Heiko Stübner wrote: > Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko Stübner: >> Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: >>> Signed-off-by: Frank Wang >> looks really cool now, thanks for addressing all the review comments >> >> Reviewed-by: Heiko Stuebner > You've only added the very common "reg" property, so I guess it should be just > fine to keep Rob's Ack on the binding in that case. OK, I will keep Rob's Ack in the next patch. > I noticed one thing below though. > As you'll probably need to do another version (see comments to patch2), you > could change that as well in both here and in the second patch - see below: Well, I will correct them and send out with a new version later. >>> --- >>> >>> Changes in v5: >>> - Added 'reg' property to identify the different phy-blocks. >>> >>> Changes in v4: >>> - Used 'phy-supply' instead of 'vbus_*-supply'. >>> >>> Changes in v3: >>> - Added 'clocks' and 'clock-names' optional properties. >>> - Specified 'otg-port' and 'host-port' as the sub-node name. >>> >>> Changes in v2: >>> - Changed vbus_host optional property from gpio to regulator. >>> - Specified vbus_otg-supply optional property. >>> - Specified otg_id and otg_bvalid property. >>> >>> .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 >>> >>> ++++++++++++++++++++ 1 file changed, 64 insertions(+) >>> >>> create mode 100644 >>> >>> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new >>> file >>> mode 100644 >>> index 0000000..48bb5de >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> @@ -0,0 +1,64 @@ >>> +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK >>> + >>> +Required properties (phy (parent) node): >>> + - compatible : should be one of the listed compatibles: >>> + * "rockchip,rk3366-usb2phy" >>> + * "rockchip,rk3399-usb2phy" >>> + - reg : the address offset of grf for usb-phy configuration. >>> + - #clock-cells : should be 0. >>> + - clock-output-names : specify the 480m output clock name. >>> + >>> +Optional properties: >>> + - clocks : phandle + phy specifier pair, for the input clock of phy. >>> + - clock-names : input clock name of phy, must be "phyclk". >>> + >>> +Required nodes : a sub-node is required for each port the phy provides. >>> + The sub-node name is used to identify host or otg port, >>> + and shall be the following entries: >>> + * "otg-port" : the name of otg port. >>> + * "host-port" : the name of host port. >>> + >>> +Required properties (port (child) node): >>> + - #phy-cells : must be 0. See ./phy-bindings.txt for details. >>> + - interrupts : specify an interrupt for each entry in interrupt-names. >>> + - interrupt-names : a list which shall be the following entries: >>> + * "otg_id" : for the otg id interrupt. >>> + * "otg_bvalid" : for the otg vbus interrupt. > please use "-" not underscores in dt-bindings, so "otg-id", "otg-bvalid". > > >>> + * "linestate" : for the host/otg linestate interrupt. >>> + >>> +Optional properties: >>> + - phy-supply : phandle to a regulator that provides power to VBUS. >>> + See ./phy-bindings.txt for details. >>> + >>> +Example: >>> + >>> +grf: syscon@ff770000 { >>> + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + >>> +... >>> + >>> + u2phy: usb2-phy@700 { >>> + compatible = "rockchip,rk3366-usb2phy"; >>> + reg = <0x700 0x2c>; >>> + #clock-cells = <0>; >>> + clock-output-names = "sclk_otgphy0_480m"; >>> + >>> + u2phy_otg: otg-port { >>> + #phy-cells = <0>; >>> + interrupts = , >>> + , >>> + ; >>> + interrupt-names = "otg_id", "otg_bvalid", "linestate"; > again "-" not "_". > > >>> + status = "okay"; >>> + }; >>> + >>> + u2phy_host: host-port { >>> + #phy-cells = <0>; >>> + interrupts = ; >>> + interrupt-names = "linestate"; >>> + status = "okay"; >>> + }; >>> + }; >>> +}; > BR. Frank