From: Shuai Xue <xueshuai@linux.alibaba.com>
To: Ilkka Koskinen <ilkka@os.amperecomputing.com>,
Jing Zhang <renyu.zj@linux.alibaba.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 1/2] perf/dwc_pcie: Fix the event numbers
Date: Thu, 5 Dec 2024 15:25:10 +0800 [thread overview]
Message-ID: <9fa8c4b3-1585-4f2c-84df-d61d8c5c8329@linux.alibaba.com> (raw)
In-Reply-To: <20241205061914.5568-2-ilkka@os.amperecomputing.com>
在 2024/12/5 14:19, Ilkka Koskinen 写道:
> According to Databook, L1 aux is event number 0x08 and
> TX L0s and RX L0S is 0x09. Fix the event numbers for the
> two events.
>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
> drivers/perf/dwc_pcie_pmu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/dwc_pcie_pmu.c b/drivers/perf/dwc_pcie_pmu.c
> index 9cbea9675e21..890cf3bb43a2 100644
> --- a/drivers/perf/dwc_pcie_pmu.c
> +++ b/drivers/perf/dwc_pcie_pmu.c
> @@ -199,8 +199,8 @@ static struct attribute *dwc_pcie_pmu_time_event_attrs[] = {
> DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(L1_1, 0x05),
> DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(L1_2, 0x06),
> DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(CFG_RCVRY, 0x07),
> - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(TX_RX_L0S, 0x08),
> - DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(L1_AUX, 0x09),
> + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(L1_AUX, 0x08),
> + DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(TX_RX_L0S, 0x09),
>
> /* Group #1 */
> DWC_PCIE_PMU_TIME_BASE_EVENT_ATTR(tx_pcie_tlp_data_payload, 0x20),
LGTM.
Reviewed-by: Shuai Xue <xueshuai@linux.alibaba.com>
Thanks.
Best Regards,
Shuai
next prev parent reply other threads:[~2024-12-05 7:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 6:19 [PATCH 0/2] perf/dwc_pcie: Fix the swapped event numbers as well as the documentation Ilkka Koskinen
2024-12-05 6:19 ` [PATCH 1/2] perf/dwc_pcie: Fix the event numbers Ilkka Koskinen
2024-12-05 7:25 ` Shuai Xue [this message]
2024-12-05 6:19 ` [PATCH 2/2] Documentation: dwc_pcie_pmu: Fix the mnemonics and eventid Ilkka Koskinen
2024-12-05 7:26 ` Shuai Xue
2024-12-05 7:24 ` [PATCH 0/2] perf/dwc_pcie: Fix the swapped event numbers as well as the documentation Shuai Xue
2024-12-09 18:43 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fa8c4b3-1585-4f2c-84df-d61d8c5c8329@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=corbet@lwn.net \
--cc=ilkka@os.amperecomputing.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=renyu.zj@linux.alibaba.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®