From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756149AbdLOMxQ (ORCPT ); Fri, 15 Dec 2017 07:53:16 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33310 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755957AbdLOMxO (ORCPT ); Fri, 15 Dec 2017 07:53:14 -0500 Subject: Re: [PATCH] pinctrl: axp209: add CONFIG_OF dependency To: Arnd Bergmann , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171215124910.2887096-1-arnd@arndb.de> From: Quentin Schulz Message-ID: <9fa963bb-cc84-d367-9090-c8b7ad796411@free-electrons.com> Date: Fri, 15 Dec 2017 13:53:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171215124910.2887096-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 15/12/2017 13:48, Arnd Bergmann wrote: > The pinconf_generic_dt_free_map and pinconf_generic_dt_node_to_map_group > functions are only defined when CONFIG_OF is set: > > drivers/pinctrl/pinctrl-axp209.c:312:21: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function); did you mean 'pinconf_generic_params'? > drivers/pinctrl/pinctrl-axp209.c:313:18: error: 'pinconf_generic_dt_free_map' undeclared here (not in a function); did you mean 'pinconf_generic_params'? > > This adds a Kconfig depdency for the driver to prevent randconfig > build failures. > > Fixes: 23f75d7dfa92 ("pinctrl: axp209: add pinctrl features") > Signed-off-by: Arnd Bergmann > --- > drivers/pinctrl/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index ce126955212c..648be90ac1cb 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -65,7 +65,7 @@ config PINCTRL_AS3722 > > config PINCTRL_AXP209 > tristate "X-Powers AXP209 PMIC pinctrl and GPIO Support" > - depends on MFD_AXP20X > + depends on MFD_AXP20X && OF > help > AXP PMICs provides multiple GPIOs that can be muxed for different > functions. This driver bundles a pinctrl driver to select the function > I already sent a patch fixing this issue yesterday: https://patchwork.kernel.org/patch/10111721/ Thanks anyway :) Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com