From: Paolo Abeni <pabeni@redhat.com>
To: Ronak Doshi <ronak.doshi@broadcom.com>, netdev@vger.kernel.org
Cc: Guolin Yang <guolin.yang@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3] vmxnet3: correctly report gso type for UDP tunnels
Date: Fri, 30 May 2025 08:48:47 +0200 [thread overview]
Message-ID: <9faa4d04-e370-42f9-81e1-0759ca236000@redhat.com> (raw)
In-Reply-To: <20250530004631.68288-1-ronak.doshi@broadcom.com>
On 5/30/25 2:46 AM, Ronak Doshi wrote:
> Commit 3d010c8031e3 ("udp: do not accept non-tunnel GSO skbs landing
> in a tunnel") added checks in linux stack to not accept non-tunnel
> GRO packets landing in a tunnel. This exposed an issue in vmxnet3
> which was not correctly reporting GRO packets for tunnel packets.
>
> This patch fixes this issue by setting correct GSO type for the
> tunnel packets.
>
> Currently, vmxnet3 does not support reporting inner fields for LRO
> tunnel packets. This is fine for now as workaround is to enable
> tnl-segmentation offload on the relevant interfaces. This problem
> pre-exists this patch fix and can be addressed as a separate future
> patch.
I think it would be better if you rephrase the above paragraph, as is a
bit misleading. The workaround is available only in some scenarios: when
the egress device supports tunnel TSO and only if the relevant egress
driver does not use the skb inner fields (many NICs actually use/need them).
Note that there is no guarantee that the egress device will be vmxnet, too.
/P
prev parent reply other threads:[~2025-05-30 6:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 0:46 Ronak Doshi
2025-05-30 6:48 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9faa4d04-e370-42f9-81e1-0759ca236000@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guolin.yang@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ronak.doshi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®