From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD66C433DB for ; Sun, 17 Jan 2021 22:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7E80222B3 for ; Sun, 17 Jan 2021 22:23:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730522AbhAQWXt (ORCPT ); Sun, 17 Jan 2021 17:23:49 -0500 Received: from relay01.th.seeweb.it ([5.144.164.162]:47905 "EHLO relay01.th.seeweb.it" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730472AbhAQWXO (ORCPT ); Sun, 17 Jan 2021 17:23:14 -0500 Received: from IcarusMOD.eternityproject.eu (unknown [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 6E53C1F424; Sun, 17 Jan 2021 23:22:07 +0100 (CET) Subject: Re: [PATCH v4 2/2] media: dt-bindings: media: i2c: Add IMX300 CMOS sensor binding To: Sakari Ailus Cc: mchehab@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, konrad.dybcio@somainline.org, marijn.suijten@somainline.org, martin.botka@somainline.org References: <20210113182934.444727-1-angelogioacchino.delregno@somainline.org> <20210113182934.444727-3-angelogioacchino.delregno@somainline.org> <20210116234404.GX850@valkosipuli.retiisi.org.uk> From: AngeloGioacchino Del Regno Message-ID: <9fab4d1a-7c33-3999-4a84-d0abff205d3e@somainline.org> Date: Sun, 17 Jan 2021 23:22:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210116234404.GX850@valkosipuli.retiisi.org.uk> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 17/01/21 00:44, Sakari Ailus ha scritto: > Hi AngeloGioacchino, > > On Wed, Jan 13, 2021 at 07:29:34PM +0100, AngeloGioacchino Del Regno wrote: >> Add YAML device tree binding for IMX300 CMOS image sensor, and >> the relevant MAINTAINERS entries. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> .../bindings/media/i2c/sony,imx300.yaml | 112 ++++++++++++++++++ >> MAINTAINERS | 7 ++ >> 2 files changed, 119 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx300.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx300.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx300.yaml >> new file mode 100644 >> index 000000000000..4fa767feea80 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx300.yaml >> @@ -0,0 +1,112 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/i2c/sony,imx300.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Sony 1/2.3-Inch 25Mpixel Stacked CMOS Digital Image Sensor >> + >> +maintainers: >> + - AngeloGioacchino Del Regno >> + >> +description: |- >> + The Sony IMX300 is a 1/2.3-inch Stacked CMOS (Exmor-RS) digital image >> + sensor with a pixel size of 1.08um and an active array size of >> + 5948H x 4140V. It is programmable through I2C interface at address 0x10. >> + Image data is sent through MIPI CSI-2, which is configured as either 2 or >> + 4 data lanes. >> + >> +properties: >> + compatible: >> + const: sony,imx300 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 > > Please add assigned clock related properties; see > Documentation/driver-api/media/camera-sensor.rst . > >> + >> + vdig-supply: >> + description: >> + Digital I/O voltage supply, 1.15-1.20 volts >> + >> + vana-supply: >> + description: >> + Analog voltage supply, 2.2 volts >> + >> + vddl-supply: >> + description: >> + Digital core voltage supply, 1.8 volts >> + >> + reset-gpios: >> + description: |- >> + Reference to the GPIO connected to the xclr pin, if any. >> + Must be released (set high) after all supplies are applied. >> + >> + # See ../video-interfaces.txt for more details >> + port: >> + type: object >> + properties: >> + endpoint: >> + type: object >> + >> + properties: >> + data-lanes: >> + description: |- >> + The driver only supports four-lane operation. > > This can be removed as bindings describe hardware, not driver operation. > >> + items: >> + - const: 0 >> + - const: 1 >> + - const: 2 >> + - const: 3 > > Two lanes here, too? > >> + >> + clock-noncontinuous: true >> + >> + link-frequencies: >> + $ref: /schemas/types.yaml#/definitions/uint64-array >> + description: >> + Allowed data bus frequencies. The driver currently needs >> + to switch between 780000000 and 480000000 Hz in order to >> + guarantee functionality of all modes. > > You can omit this description, too. > >> + >> + required: >> + - data-lanes >> + - link-frequencies >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - vana-supply >> + - vdig-supply >> + - vddl-supply > > Are the regulators really required? I'm not quite sure about the > established practices; still the common case is that one or two of these > are hard-wired. > >> + - port >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + i2c0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + imx300: sensor@10 { >> + compatible = "sony,imx300"; >> + reg = <0x10>; >> + clocks = <&imx300_xclk>; >> + vana-supply = <&imx300_vana>; /* 2.2v */ >> + vdig-supply = <&imx300_vdig>; /* 1.2v */ >> + vddl-supply = <&imx300_vddl>; /* 1.8v */ >> + >> + port { >> + imx300_0: endpoint { >> + remote-endpoint = <&csi1_ep>; >> + data-lanes = <0 1 2 3>; >> + clock-noncontinuous; >> + link-frequencies = /bits/ 64 <780000000 480000000>; >> + }; >> + }; >> + }; >> + }; >> + >> +... >> diff --git a/MAINTAINERS b/MAINTAINERS >> index ad9abb42f852..5e0f08f48d48 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -16633,6 +16633,13 @@ T: git git://linuxtv.org/media_tree.git >> F: Documentation/devicetree/bindings/media/i2c/imx290.txt >> F: drivers/media/i2c/imx290.c >> >> +SONY IMX300 SENSOR DRIVER >> +M: AngeloGioacchino Del Regno >> +L: linux-media@vger.kernel.org > > Please also add the git tree. > > Ideally also the MAINTAINERS change comes with the first patch adding the > files, which should be the DT bindings. I.e. just reverse the order of the > patches. > >> +S: Maintained >> +F: Documentation/devicetree/bindings/media/i2c/sony,imx300.yaml >> +F: drivers/media/i2c/imx300.c >> + >> SONY IMX319 SENSOR DRIVER >> M: Bingbu Cao >> L: linux-media@vger.kernel.org > Besides that, I'm sorry I forgot to port the following tag from V3 of this patch, which didn't change. I'm adding the forgotten R-b from Rob here: Reviewed-by: Rob Herring Sorry again.