From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1728F22CF00 for ; Mon, 13 Jan 2025 11:39:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736768349; cv=none; b=bB8fGrPe/+Ooj/c+qcUROVE3YmZbz4qXBvRnk87Yp2/4/fIyye/9YGsG3MBT9iGrWjL+/BUUFgb5PmLt1nOpTCdL7ngmBDL2BB5GLcskV3R6pWSVHcirsDkBo4Cwdkw8qFLd49Cv2DLyFiMAxxneDwMLR4OH53AuvR0Suuw7WfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736768349; c=relaxed/simple; bh=vhD6tgVLRLRbfL34BndPBb0FfJdqEdhMUU11dYraRG8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R8Uf505zPY1VKcrkrT+HhQbwgSuab4F9PA9Zy1rhvxtFLIlg7jvDQD11nA/5WNnXw9nHsn5hYJfBy0O91RqmYi80ojACOiEz8Hv8Sw+T3QsXiGaQ63xEOc0qBSBvDhYETqkYPHCyeilTwqeT7IKxaBBrRNcT7N6jh8AWycXhL7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=i5LgTsAC; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="i5LgTsAC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1736768343; bh=vhD6tgVLRLRbfL34BndPBb0FfJdqEdhMUU11dYraRG8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=i5LgTsACFNwW3lxjCBjVh5hVbsiTCIpJxf+TP21V4kIBASq2pHui057KvbLok3uaG h7GjLVKPIT6yNEQ7VcKZaS6ZaSArJN5TREhYN56PD9vUAskCeF4qtChoEiEJT8QFjv OHOJRitB+lGaD5KW0HBRP7yW7gRHM4ey7yZ9THBDfOs9BLjUkDAFmDa6rWcBTf9CAM ac5Zc6+chezUsbFx4k+k4P3HqO/+fQIToKyuPP/Ge1iW3/0smTEtXenkAZ5ehJQxhw JQbVexaY+w1gGpuhRybkDx3Balsfcg2I94Zdp7iZqw2ofFjtQ05bjYn2mCQfIbd5yJ j8ZKnF/2W/law== Received: from [192.168.1.90] (unknown [82.76.59.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id CF5B517E0D72; Mon, 13 Jan 2025 12:39:02 +0100 (CET) Message-ID: <9faebd93-1c82-49e2-87f2-2928a016b044@collabora.com> Date: Mon, 13 Jan 2025 13:39:02 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/display: hdmi: Do not read EDID on disconnected connectors To: Dmitry Baryshkov Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250111-hdmi-conn-edid-read-fix-v1-1-d68361624380@collabora.com> <2df6xkxqpljeowlqad6s5pxujefx6iw2a2caqlgljrgpmxlqqz@lark6bpzexca> From: Cristian Ciocaltea Content-Language: en-US In-Reply-To: <2df6xkxqpljeowlqad6s5pxujefx6iw2a2caqlgljrgpmxlqqz@lark6bpzexca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Dmitry, On 1/13/25 11:16 AM, Dmitry Baryshkov wrote: > On Sat, Jan 11, 2025 at 12:04:09AM +0200, Cristian Ciocaltea wrote: >> The recently introduced hotplug event handler in the HDMI Connector >> framework attempts to unconditionally read the EDID data, leading to a >> bunch of non-harmful, yet quite annoying DDC/I2C related errors being >> reported. >> >> Ensure the operation is performed only for connectors having the status >> connected or unknown. >> >> Fixes: ab716b74dc9d ("drm/display/hdmi: implement hotplug functions") >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/display/drm_hdmi_state_helper.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/display/drm_hdmi_state_helper.c b/drivers/gpu/drm/display/drm_hdmi_state_helper.c >> index 2691e8b3e480131ac6e4e4b74b24947be55694bd..8e4b30e09b53b84cfd36199d56db3221a00085b0 100644 >> --- a/drivers/gpu/drm/display/drm_hdmi_state_helper.c >> +++ b/drivers/gpu/drm/display/drm_hdmi_state_helper.c >> @@ -786,8 +786,10 @@ drm_atomic_helper_connector_hdmi_update(struct drm_connector *connector, >> const struct drm_edid *drm_edid; >> >> if (status == connector_status_disconnected) { >> + drm_edid_connector_update(connector, NULL); >> // TODO: also handle CEC and scramber, HDMI sink disconnected. >> drm_connector_hdmi_audio_plugged_notify(connector, false); >> + return; > > I think, it should be other way around: plugged_notify before > drm_edid_connector_update(). At least that would follow current logic of > the function. Yeah, I wasn't really sure about the order here. Will get this fixed in v2. Thanks, Cristian