From: Juergen Gross <jgross@suse.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com
Cc: x86@kernel.org, xen-devel@lists.xenproject.org,
srinivas.eeda@oracle.com, joe.jin@oracle.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Call xen_cleanhighmap() with 4MB aligned for page tables mapping
Date: Wed, 27 Sep 2017 16:33:04 +0200 [thread overview]
Message-ID: <9faf8d7b-227f-2ecd-26e6-44ae4270d469@suse.com> (raw)
In-Reply-To: <44ebc914-d1a3-06ac-9ec5-b866d5f04e0a@oracle.com>
On 27/09/17 15:38, Boris Ostrovsky wrote:
> On 09/27/2017 05:43 AM, Juergen Gross wrote:
>> On 27/09/17 11:41, Zhenzhong Duan wrote:
>>> When bootup a PVM guest with large memory(Ex.240GB), XEN provided initial
>>> mapping overlaps with kernel module virtual space. When mapping in this space
>>> is cleared by xen_cleanhighmap(), in certain case there could be an 2MB mapping
>>> left. This is due to XEN initialize 4MB aligned mapping but xen_cleanhighmap()
>>> finish at 2MB boundary.
>
> Does this mapping need to be 4MB-aligned?
I guess you are questioning the alignment of addr to be 4MB?
In this case you are right: the end of the mapping is 4MB aligned, as
correctly stated in the comment added.
> (I also think this should go to stable trees)
Indeed.
Juergen
next prev parent reply other threads:[~2017-09-27 14:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 9:41 Zhenzhong Duan
2017-09-27 9:43 ` Juergen Gross
2017-09-27 13:38 ` Boris Ostrovsky
2017-09-27 14:33 ` Juergen Gross [this message]
2017-09-27 14:48 ` Boris Ostrovsky
2017-09-27 14:56 ` Juergen Gross
2017-09-27 15:02 ` Boris Ostrovsky
2017-09-27 15:03 ` [Xen-devel] " Andrew Cooper
2017-09-27 20:01 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9faf8d7b-227f-2ecd-26e6-44ae4270d469@suse.com \
--to=jgross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hpa@zytor.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=srinivas.eeda@oracle.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®