From: Robert Greener <rob@robgreener.com>
To: unlisted-recipients:; (no To-header on input)
Subject: [PATCH 10/13] usb: core: config: fix checkpatch.pl braces warning
Date: Tue, 5 Oct 2021 14:34:03 +0100 [thread overview]
Message-ID: <9fb688c9a39a9114a6137361dc4a143d7a198822.1633442131.git.rob@robgreener.com> (raw)
In-Reply-To: <cover.1633442131.git.rob@robgreener.com>
This fixes the following checkpatch.pl warnings:
core/config.c:268: CHECK:BRACES: braces {} should be used on all arms of this statement
core/config.c:272: CHECK:BRACES: Unbalanced braces around else statement
core/config.c:649: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Robert Greener <rob@robgreener.com>
---
drivers/usb/core/config.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 9717f89bcb6f..76038e8c84c5 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -265,11 +265,12 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno,
buffer += d->bLength;
size -= d->bLength;
- if (d->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE)
+ if (d->bLength >= USB_DT_ENDPOINT_AUDIO_SIZE) {
n = USB_DT_ENDPOINT_AUDIO_SIZE;
- else if (d->bLength >= USB_DT_ENDPOINT_SIZE)
+ }
+ else if (d->bLength >= USB_DT_ENDPOINT_SIZE) {
n = USB_DT_ENDPOINT_SIZE;
- else {
+ } else {
dev_warn(ddev,
"config %d interface %d altsetting %d has an invalid endpoint descriptor of length %d, skipping\n",
cfgno, inum, asnum, d->bLength);
@@ -646,7 +647,6 @@ static int usb_parse_configuration(struct usb_device *dev, int cfgidx,
for ((buffer2 = buffer, size2 = size);
size2 > 0;
(buffer2 += header->bLength, size2 -= header->bLength)) {
-
if (size2 < sizeof(struct usb_descriptor_header)) {
dev_warn(ddev,
"config %d descriptor has %d excess byte%s, ignoring\n",
--
2.32.0
next prev parent reply other threads:[~2021-10-05 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 13:55 [PATCH 00/13] usb: core: config: fix all checkpatch.pl warnings Robert Greener
2021-10-05 12:22 ` [PATCH 01/13] usb: core: config: Use tabs rather than spaces for new lines of args Robert Greener
2021-10-05 14:59 ` Joe Perches
2021-10-05 12:31 ` [PATCH 02/13] usb: core: config: fix block comment styles Robert Greener
2021-10-05 12:35 ` [PATCH 03/13] usb: core: config: Change `unsigned` to `unsigned int` Robert Greener
2021-10-05 12:37 ` [PATCH 04/13] usb: core: config: Avoid multiple line derefrence Robert Greener
2021-10-05 12:41 ` [PATCH 05/13] usb: core: config: Fix typo in dev_warn Robert Greener
2021-10-05 13:22 ` [PATCH 06/13] usb: core: config: unsplit strings which are split across lines Robert Greener
2021-10-05 13:25 ` [PATCH 07/13] usb: core: config: remove unnecessary blank lines Robert Greener
2021-10-05 13:26 ` [PATCH 08/13] usb: core: config: add blank lines after struct def Robert Greener
2021-10-05 13:30 ` [PATCH 09/13] usb: core: config: fix inline spacign Robert Greener
2021-10-05 13:34 ` Robert Greener [this message]
2021-10-05 13:37 ` [PATCH 11/13] usb: core: config: remove unnecessary parentheses Robert Greener
2021-10-05 13:43 ` [PATCH 12/13] usb: core: config: remove multiple assignments Robert Greener
2021-10-05 13:52 ` [PATCH 13/13] usb: core: config: fix parenthesis alignment Robert Greener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fb688c9a39a9114a6137361dc4a143d7a198822.1633442131.git.rob@robgreener.com \
--to=rob@robgreener.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®