From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751505AbdFHB1k (ORCPT ); Wed, 7 Jun 2017 21:27:40 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:7781 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdFHB1j (ORCPT ); Wed, 7 Jun 2017 21:27:39 -0400 Subject: Re: [PATCH] Revert "ARM: 8433/1: add a VMSPLIT_3G_OPT config option" To: Russell King - ARM Linux References: <1496825972-26829-1-git-send-email-xieyisheng1@huawei.com> <20170607093350.GJ4902@n2100.armlinux.org.uk> CC: , , , , , , , , From: Yisheng Xie Message-ID: <9fbfa9c0-e46f-0f88-4c8f-de8be9114941@huawei.com> Date: Thu, 8 Jun 2017 09:23:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20170607093350.GJ4902@n2100.armlinux.org.uk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.29.40] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.5938A714.00AB,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 189fa0b490364ad50998e72e981a0f97 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Russell, Thanks for comment! On 2017/6/7 17:33, Russell King - ARM Linux wrote: > On Wed, Jun 07, 2017 at 04:59:32PM +0800, Yisheng Xie wrote: >> This reverts commit 63ce446c9b5787a94ed875bab20772e1a2b3092f. > > There's no real reason to revert this, thereby removing it from non-LPAE > cases where it does work. You've already shown adding a dependency for > LPAE on this option (or even vice versa) is enough to stop the problem > occuring. > > IMHO, It would be better to make VMSPLIT_3G_OPT depend on !ARM_LPAE. OK, I will send a patch as your suggestion. Thanks Yisheng Xie