From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98B6BC433FE for ; Tue, 29 Mar 2022 14:54:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238171AbiC2Ozu (ORCPT ); Tue, 29 Mar 2022 10:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238160AbiC2Ozq (ORCPT ); Tue, 29 Mar 2022 10:55:46 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5216F275FD; Tue, 29 Mar 2022 07:54:02 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id l7-20020a05600c1d0700b0038c99618859so1388193wms.2; Tue, 29 Mar 2022 07:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x2iu+zBPbGJB5ooat97bM+huvpOZWu4gZrFvI4ckaOE=; b=IROVNJM1ru5LaXMGZn903JNdTjJaObmwMRdNp/wp2GoC4nOYeEufiPPCjRsJoTBScn KlC5YmJ06B7vXQuK65JU2caPKNtb4T92OZviYFXdB58px9jgRuCTwQdT9NzJ3TXPc6un tEWVaNUEOOC8IpywB2I7RyUVmSDCLVvxjIs+IAWeRtGk2D6AQklLfGT4yaklVYROLhSW ZyuKRj+YdL4r9XzyQce7tqaz23Bl8f3duuzLfs81e7KqFkZlIiyEfGPFWFrMp3k9elLi uS+72v9iA2EF2XsL52qO9E4VulTSUYe5+BrTOBLe8n6JuifT0TLGbL/DAaZcTjjE2Bhi txfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x2iu+zBPbGJB5ooat97bM+huvpOZWu4gZrFvI4ckaOE=; b=yBHF06YM6SsL5CYGJtRB9Zr14JIkYNoW4ZCJVmWb0YL8irbpQR+ZOJ5f1vMGrp74zH baHoOdtRamCxbbsTPDqkuWq1vIIQGhSzK6wepK2Ti7Q/l+awvt0qGaPcfcKsmNaHJAIZ FEQ6m10MFzpS0bWIRvG3lN/23Iln1typOHgEipI8ph8bSFDDsu7wL4MAxo6RNU4PgQIW EXjWpf6yFyxeRk5WdBsRItCbApMP5RGaQJx+ITRGTR02PsoExIs9A9znHlCwFcCjBGVM KNFs+ZQ6Wqeajm4NZcFIMa4xXZIHV1mwJR65Zp4Adz/EsKsJiHcyQkV/xjAMqquZMShJ VeyA== X-Gm-Message-State: AOAM531sqB/rYo675ph8xAm753CLNL15wcP8UigC70g44HwKkd8vNT+Y 8ZQhyCqkpLxfQYJidM+1FJA= X-Google-Smtp-Source: ABdhPJzDSqcgQxPGLOvYXN+CPNjCKxQ3s32uYGY6KiwJcnuvTHGNN2AcrjyDEqpbvzX7Q3Rmre0xEA== X-Received: by 2002:a05:600c:348c:b0:38c:f335:7219 with SMTP id a12-20020a05600c348c00b0038cf3357219mr17239wmq.174.1648565640828; Tue, 29 Mar 2022 07:54:00 -0700 (PDT) Received: from [192.168.1.145] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id k23-20020a7bc417000000b0038ccada7566sm2305595wmi.11.2022.03.29.07.53.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 07:54:00 -0700 (PDT) Message-ID: <9fc6564b-6119-e7b6-6edc-95c25d0d4bff@gmail.com> Date: Tue, 29 Mar 2022 16:53:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v3 1/1] arm64: dts: mt6359: add PMIC MT6359 nodes Content-Language: en-US To: Hui-Liu Liu , lee.jones@linaro.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, eddie.huang@mediatek.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, fshao@chromium.org Cc: srv_heupstream@mediatek.com, zhiyong.tao@mediatek.com, hsin-hsiung.wang@mediatek.com, sean.wang@mediatek.com, macpaul.lin@mediatek.com, yuchen.huang@mediatek.com, wen.su@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20220328103729.25102-1-hui.liu@mediatek.com> <20220328103729.25102-2-hui.liu@mediatek.com> From: Matthias Brugger In-Reply-To: <20220328103729.25102-2-hui.liu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/03/2022 12:37, Hui-Liu Liu wrote: > From: Hui Liu > > MT6359 is the primary PMIC for MT8192. > Add PMIC MT6359 related node which is used for MT8192 platform. > Thanks for the commit message. Can't we include the dtsi directly in the mt8192-evb.dts? Regards, Matthias > Signed-off-by: Hui Liu > --- > arch/arm64/boot/dts/mediatek/mt6359.dtsi | 298 +++++++++++++++++++++++ > 1 file changed, 298 insertions(+) > create mode 100644 arch/arm64/boot/dts/mediatek/mt6359.dtsi > > diff --git a/arch/arm64/boot/dts/mediatek/mt6359.dtsi b/arch/arm64/boot/dts/mediatek/mt6359.dtsi > new file mode 100644 > index 000000000000..df3e822232d3 > --- /dev/null > +++ b/arch/arm64/boot/dts/mediatek/mt6359.dtsi > @@ -0,0 +1,298 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2022 MediaTek Inc. > + */ > + > +&pwrap { > + pmic: pmic { > + compatible = "mediatek,mt6359"; > + interrupt-controller; > + #interrupt-cells = <2>; > + > + mt6359codec: mt6359codec { > + }; > + > + regulators { > + mt6359_vs1_buck_reg: buck_vs1 { > + regulator-name = "vs1"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <2200000>; > + regulator-enable-ramp-delay = <0>; > + regulator-always-on; > + }; > + mt6359_vgpu11_buck_reg: buck_vgpu11 { > + regulator-name = "vgpu11"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + regulator-ramp-delay = <5000>; > + regulator-enable-ramp-delay = <200>; > + regulator-allowed-modes = <0 1 2>; > + }; > + mt6359_vmodem_buck_reg: buck_vmodem { > + regulator-name = "vmodem"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1100000>; > + regulator-ramp-delay = <10760>; > + regulator-enable-ramp-delay = <200>; > + }; > + mt6359_vpu_buck_reg: buck_vpu { > + regulator-name = "vpu"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + regulator-ramp-delay = <5000>; > + regulator-enable-ramp-delay = <200>; > + regulator-allowed-modes = <0 1 2>; > + }; > + mt6359_vcore_buck_reg: buck_vcore { > + regulator-name = "vcore"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1300000>; > + regulator-ramp-delay = <5000>; > + regulator-enable-ramp-delay = <200>; > + regulator-allowed-modes = <0 1 2>; > + }; > + mt6359_vs2_buck_reg: buck_vs2 { > + regulator-name = "vs2"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1600000>; > + regulator-enable-ramp-delay = <0>; > + regulator-always-on; > + }; > + mt6359_vpa_buck_reg: buck_vpa { > + regulator-name = "vpa"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <3650000>; > + regulator-enable-ramp-delay = <300>; > + }; > + mt6359_vproc2_buck_reg: buck_vproc2 { > + regulator-name = "vproc2"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + regulator-ramp-delay = <7500>; > + regulator-enable-ramp-delay = <200>; > + regulator-allowed-modes = <0 1 2>; > + }; > + mt6359_vproc1_buck_reg: buck_vproc1 { > + regulator-name = "vproc1"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + regulator-ramp-delay = <7500>; > + regulator-enable-ramp-delay = <200>; > + regulator-allowed-modes = <0 1 2>; > + }; > + mt6359_vcore_sshub_buck_reg: buck_vcore_sshub { > + regulator-name = "vcore_sshub"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + }; > + mt6359_vgpu11_sshub_buck_reg: buck_vgpu11_sshub { > + regulator-name = "vgpu11_sshub"; > + regulator-min-microvolt = <400000>; > + regulator-max-microvolt = <1193750>; > + }; > + mt6359_vaud18_ldo_reg: ldo_vaud18 { > + regulator-name = "vaud18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-enable-ramp-delay = <240>; > + }; > + mt6359_vsim1_ldo_reg: ldo_vsim1 { > + regulator-name = "vsim1"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3100000>; > + }; > + mt6359_vibr_ldo_reg: ldo_vibr { > + regulator-name = "vibr"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <3300000>; > + }; > + mt6359_vrf12_ldo_reg: ldo_vrf12 { > + regulator-name = "vrf12"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + }; > + mt6359_vusb_ldo_reg: ldo_vusb { > + regulator-name = "vusb"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3000000>; > + regulator-enable-ramp-delay = <960>; > + regulator-always-on; > + }; > + mt6359_vsram_proc2_ldo_reg: ldo_vsram_proc2 { > + regulator-name = "vsram_proc2"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1293750>; > + regulator-ramp-delay = <7500>; > + regulator-enable-ramp-delay = <240>; > + regulator-always-on; > + }; > + mt6359_vio18_ldo_reg: ldo_vio18 { > + regulator-name = "vio18"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + regulator-enable-ramp-delay = <960>; > + regulator-always-on; > + }; > + mt6359_vcamio_ldo_reg: ldo_vcamio { > + regulator-name = "vcamio"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + }; > + mt6359_vcn18_ldo_reg: ldo_vcn18 { > + regulator-name = "vcn18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-enable-ramp-delay = <240>; > + }; > + mt6359_vfe28_ldo_reg: ldo_vfe28 { > + regulator-name = "vfe28"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-enable-ramp-delay = <120>; > + }; > + mt6359_vcn13_ldo_reg: ldo_vcn13 { > + regulator-name = "vcn13"; > + regulator-min-microvolt = <900000>; > + regulator-max-microvolt = <1300000>; > + }; > + mt6359_vcn33_1_bt_ldo_reg: ldo_vcn33_1_bt { > + regulator-name = "vcn33_1_bt"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3500000>; > + }; > + mt6359_vcn33_1_wifi_ldo_reg: ldo_vcn33_1_wifi { > + regulator-name = "vcn33_1_wifi"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3500000>; > + }; > + mt6359_vaux18_ldo_reg: ldo_vaux18 { > + regulator-name = "vaux18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-enable-ramp-delay = <240>; > + regulator-always-on; > + }; > + mt6359_vsram_others_ldo_reg: ldo_vsram_others { > + regulator-name = "vsram_others"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1293750>; > + regulator-ramp-delay = <5000>; > + regulator-enable-ramp-delay = <240>; > + }; > + mt6359_vefuse_ldo_reg: ldo_vefuse { > + regulator-name = "vefuse"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <2000000>; > + }; > + mt6359_vxo22_ldo_reg: ldo_vxo22 { > + regulator-name = "vxo22"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <2200000>; > + regulator-always-on; > + }; > + mt6359_vrfck_ldo_reg: ldo_vrfck { > + regulator-name = "vrfck"; > + regulator-min-microvolt = <1500000>; > + regulator-max-microvolt = <1700000>; > + }; > + mt6359_vrfck_1_ldo_reg: ldo_vrfck_1 { > + regulator-name = "vrfck"; > + regulator-min-microvolt = <1240000>; > + regulator-max-microvolt = <1600000>; > + }; > + mt6359_vbif28_ldo_reg: ldo_vbif28 { > + regulator-name = "vbif28"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <2800000>; > + regulator-enable-ramp-delay = <240>; > + }; > + mt6359_vio28_ldo_reg: ldo_vio28 { > + regulator-name = "vio28"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3300000>; > + regulator-always-on; > + }; > + mt6359_vemc_ldo_reg: ldo_vemc { > + regulator-name = "vemc"; > + regulator-min-microvolt = <2900000>; > + regulator-max-microvolt = <3300000>; > + }; > + mt6359_vemc_1_ldo_reg: ldo_vemc_1 { > + regulator-name = "vemc"; > + regulator-min-microvolt = <2500000>; > + regulator-max-microvolt = <3300000>; > + }; > + mt6359_vcn33_2_bt_ldo_reg: ldo_vcn33_2_bt { > + regulator-name = "vcn33_2_bt"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3500000>; > + }; > + mt6359_vcn33_2_wifi_ldo_reg: ldo_vcn33_2_wifi { > + regulator-name = "vcn33_2_wifi"; > + regulator-min-microvolt = <2800000>; > + regulator-max-microvolt = <3500000>; > + }; > + mt6359_va12_ldo_reg: ldo_va12 { > + regulator-name = "va12"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1300000>; > + regulator-always-on; > + }; > + mt6359_va09_ldo_reg: ldo_va09 { > + regulator-name = "va09"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1200000>; > + }; > + mt6359_vrf18_ldo_reg: ldo_vrf18 { > + regulator-name = "vrf18"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1810000>; > + }; > + mt6359_vsram_md_ldo_reg: ldo_vsram_md { > + regulator-name = "vsram_md"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1293750>; > + regulator-ramp-delay = <10760>; > + regulator-enable-ramp-delay = <240>; > + }; > + mt6359_vufs_ldo_reg: ldo_vufs { > + regulator-name = "vufs"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + }; > + mt6359_vm18_ldo_reg: ldo_vm18 { > + regulator-name = "vm18"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1900000>; > + regulator-always-on; > + }; > + mt6359_vbbck_ldo_reg: ldo_vbbck { > + regulator-name = "vbbck"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1200000>; > + }; > + mt6359_vsram_proc1_ldo_reg: ldo_vsram_proc1 { > + regulator-name = "vsram_proc1"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1293750>; > + regulator-ramp-delay = <7500>; > + regulator-enable-ramp-delay = <240>; > + regulator-always-on; > + }; > + mt6359_vsim2_ldo_reg: ldo_vsim2 { > + regulator-name = "vsim2"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <3100000>; > + }; > + mt6359_vsram_others_sshub_ldo: ldo_vsram_others_sshub { > + regulator-name = "vsram_others_sshub"; > + regulator-min-microvolt = <500000>; > + regulator-max-microvolt = <1293750>; > + }; > + }; > + > + mt6359rtc: mt6359rtc { > + compatible = "mediatek,mt6358-rtc"; > + }; > + }; > +}; > -- > 2.25.1 > > ************* MEDIATEK Confidentiality Notice ******************** > The information contained in this e-mail message (including any > attachments) may be confidential, proprietary, privileged, or otherwise > exempt from disclosure under applicable laws. It is intended to be > conveyed only to the designated recipient(s). Any use, dissemination, > distribution, printing, retaining or copying of this e-mail (including its > attachments) by unintended recipient(s) is strictly prohibited and may > be unlawful. If you are not an intended recipient of this e-mail, or believe > that you have received this e-mail in error, please notify the sender > immediately (by replying to this e-mail), delete any and all copies of > this e-mail (including any attachments) from your system, and do not > disclose the content of this e-mail to any other person. Thank you!