From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7EE193BA23C for ; Thu, 5 Mar 2026 15:43:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725393; cv=none; b=Zaql4/TxaF8CzEsjsfvv0gKTMzlZFimnMFySKG3niWH2QC08X+N8Y2K+PGOKfz5hlMIZXMxw46GFfZS4jc6IDWwtVcxcFh4U+/zFuegfujptXz957Gk5NLaeztsVRRBufQta9Rjp145qGfxhLqD+bI4AF9R06G+84uuUdvBjsh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772725393; c=relaxed/simple; bh=iVDjx/NEFxcLp/n5WshPE6kVHdojQR29NK6rWPwBcB4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CzwecrFs2BJjkL3MC0ClqpKW1ezgogmyZid14gyi3tfEk26vpL+ewi2VdRGcwoARfXgxpjW88NFo+85xvg3PPXu88sLmJLik0iYOnC5yte7E1DvRfHb2T8mmtrA4RaZpVIAHcjl/HkiVNH5c6uAXHU35qFGcyZMDXysXyxpAlHU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AD8B8339; Thu, 5 Mar 2026 07:43:03 -0800 (PST) Received: from [10.1.32.28] (e122027.cambridge.arm.com [10.1.32.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1CF6C3F73B; Thu, 5 Mar 2026 07:43:07 -0800 (PST) Message-ID: <9fcc4a4c-ac62-4a85-a660-07a1476104d9@arm.com> Date: Thu, 5 Mar 2026 15:43:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panthor: Correct the order of arguments passed to gem_sync To: Akash Goel , boris.brezillon@collabora.com, liviu.dudau@arm.com Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com References: <20260305110723.2871733-1-akash.goel@arm.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20260305110723.2871733-1-akash.goel@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/03/2026 11:07, Akash Goel wrote: > This commit corrects the order of arguments passed to panthor_gem_sync() > function, called when the SYNC_WAIT condition has to be evaluated for a > blocked GPU queue. > > Fixes: cd2c9c3015e6 (drm/panthor: Add flag to map GEM object Write-Back Cacheable) > Signed-off-by: Akash Goel Reviewed-by: Steven Price > --- > drivers/gpu/drm/panthor/panthor_sched.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..a70f1db0764e 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue > > out_sync: > /* Make sure the CPU caches are invalidated before the seqno is read. > - * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check > + * panthor_gem_sync() is a NOP if map_wc=true, so no need to check > * it here. > */ > - panthor_gem_sync(&bo->base.base, queue->syncwait.offset, > + panthor_gem_sync(&bo->base.base, > + DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE, > + queue->syncwait.offset, > queue->syncwait.sync64 ? > sizeof(struct panthor_syncobj_64b) : > - sizeof(struct panthor_syncobj_32b), > - DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE); > + sizeof(struct panthor_syncobj_32b)); > > return queue->syncwait.kmap + queue->syncwait.offset; >