From: "André Draszik" <andre.draszik@linaro.org>
To: Amit Sunil Dhamne <amitsd@google.com>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Badhri Jagan Sridharan <badhri@google.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Peter Griffin <peter.griffin@linaro.org>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
RD Babiera <rdbabiera@google.com>, Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v5 4/5] power: supply: max77759: add charger driver
Date: Tue, 10 Feb 2026 06:39:14 +0000 [thread overview]
Message-ID: <9fce298c842533bc6ede7f1a97040337236351d8.camel@linaro.org> (raw)
In-Reply-To: <277e1c95-e221-4c07-a00e-d0f0a1a7553f@google.com>
Hi Amit,
On Mon, 2026-02-09 at 16:42 -0800, Amit Sunil Dhamne wrote:
> Hi Andre',
>
> On 2/4/26 4:49 AM, André Draszik wrote:
> > On Tue, 2026-02-03 at 22:50 +0000, Amit Sunil Dhamne via B4 Relay wrote:
> >
> > > +
> > > +static void psy_work_item(struct work_struct *work)
> > > +{
> > > + struct max77759_charger *chg =
> > > + container_of(work, struct max77759_charger, psy_work.work);
> > > + union power_supply_propval current_limit, online;
> > > + int ret;
> > > +
> > > + ret = power_supply_get_property(chg->tcpm_psy,
> > > + POWER_SUPPLY_PROP_CURRENT_MAX,
> > > + ¤t_limit);
> > > + if (ret) {
> > > + dev_err(chg->dev,
> > > + "Failed to get CURRENT_MAX psy property, ret=%d",
> > > + ret);
> > > + goto err;
> > > + }
> > > +
> > > + ret = power_supply_get_property(chg->tcpm_psy, POWER_SUPPLY_PROP_ONLINE,
> > > + &online);
> > > + if (ret) {
> > > + dev_err(chg->dev,
> > > + "Failed to get ONLINE psy property, ret=%d",
> > > + ret);
> > > + goto err;
> > > + }
> > > +
> > > + if (online.intval && current_limit.intval) {
> > > + ret = set_input_current_limit(chg, current_limit.intval);
> > > + if (ret) {
> > > + dev_err(chg->dev,
> > > + "Unable to set current limit, ret=%d", ret);
> > > + goto err;
> > > + }
> > > +
> > > + charger_set_mode(chg, MAX77759_CHGR_MODE_CHG_BUCK_ON);
> > > + } else {
> > > + charger_set_mode(chg, MAX77759_CHGR_MODE_OFF);
> > > + }
> > > +
> > > + chg->psy_work_retry_cnt = 0;
> > > + return;
> > > +
> > > +err:
> > > + charger_set_mode(chg, MAX77759_CHGR_MODE_OFF);
> > > + if (chg->psy_work_retry_cnt >= MAX_NUM_RETRIES)
> > > + return;
> > I'd say this final giving up could benefit from a dev_err(), while ...
>
> I want to clarify if you want me to add this final giving up print just
> once or every time I am returning early?
I meant something along the lines of this:
+ if (chg->psy_work_retry_cnt)
+ dev_dbg(chg->dev, "chg psy_work succeeded after %d\n",
+ chg->psy_work_retry_cnt)
+ chg->psy_work_retry_cnt = 0;
+ return;
+
+err:
+ charger_set_mode(chg, MAX77759_CHGR_MODE_OFF);
+ if (chg->psy_work_retry_cnt >= MAX_NUM_RETRIES) {
+ dev_warn(chg->dev, "chg psy_work failed, giving up",
+ chg->psy_work_retry_cnt, MAX_NUM_RETRIES);
+ return;
+ }
> >
> > > +
> > > + ++chg->psy_work_retry_cnt;
> > > + dev_err(chg->dev, "Retrying %u/%u chg psy_work",
> > > + chg->psy_work_retry_cnt, MAX_NUM_RETRIES);
> > ... this one could be demoted (but doesn't have to).
> >
> > That'd make it easier to determine if it's still in the process of
> > trying, or if it has given up fully.
>
> I was assuming the printing of "3/3" would indicate the final giving up
> and sufficient.
If you see 3/3 in the log, you'll know that it has scheduled the work (for
the last attempt), but you won't easily know if 3/3 has ran yet or if it
has completed successfully this time or if it was still unsuccessful.
> >
> > > + schedule_delayed_work(&chg->psy_work,
> > > + msecs_to_jiffies(PSY_WORK_RETRY_DELAY_MS));
> > > +}
> > > +
> > > +static int psy_changed(struct notifier_block *nb, unsigned long evt, void *data)
> > > +{
> > > + struct max77759_charger *chg = container_of(nb, struct max77759_charger,
> > > + nb);
> > > + static const char *psy_name = "tcpm-source";
> > > + struct power_supply *psy = data;
> > > +
> > > + if (!strnstr(psy->desc->name, psy_name, strlen(psy_name)) ||
> > > + evt != PSY_EVENT_PROP_CHANGED)
> > > + return NOTIFY_OK;
> > > +
> > > + chg->tcpm_psy = psy;
> > Do you need locking here? What if this is changed while a previous
> > psy_work_item() is still executing?
>
> I don't think that's ever possible in this case though. The power
> supply that this driver registers is downstream of the tcpm's.
A previous work could still be executing (e.g. due to retrying), no? It
should also probably set chg->psy_work_retry_cnt = 0; here, to allow it
to retry up to MAX_NUM_RETRIES when a new work is queued and a previous
one was unsuccessful?
Cheers,
Andre
next prev parent reply other threads:[~2026-02-10 6:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 22:50 [PATCH v5 0/5] Introduce MAX77759 " Amit Sunil Dhamne via B4 Relay
2026-02-03 22:50 ` [PATCH v5 1/5] dt-bindings: mfd: maxim,max77759: reference power-supply schema and add regulator property Amit Sunil Dhamne via B4 Relay
2026-02-03 22:50 ` [PATCH v5 2/5] dt-bindings: usb: maxim,max33359: Add supply property for vbus Amit Sunil Dhamne via B4 Relay
2026-02-03 22:50 ` [PATCH v5 3/5] mfd: max77759: add register bitmasks and modify irq configs for charger Amit Sunil Dhamne via B4 Relay
2026-02-04 6:46 ` André Draszik
2026-02-03 22:50 ` [PATCH v5 4/5] power: supply: max77759: add charger driver Amit Sunil Dhamne via B4 Relay
2026-02-04 5:34 ` kernel test robot
2026-02-04 12:49 ` André Draszik
2026-02-10 0:42 ` Amit Sunil Dhamne
2026-02-10 6:39 ` André Draszik [this message]
2026-02-03 22:50 ` [PATCH v5 5/5] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode Amit Sunil Dhamne via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fce298c842533bc6ede7f1a97040337236351d8.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=amitsd@google.com \
--cc=badhri@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk+dt@kernel.org \
--cc=kyletso@google.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=rdbabiera@google.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®