mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Brian Norris <briannorris@chromium.org>,
	Douglas Anderson <dianders@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
	Alexandru M Stan <amstan@chromium.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Simon Glass <sjg@chromium.org>,
	Guenter Roeck <groeck@chromium.org>,
	Mark Brown <broonie@kernel.org>,
	Ryan Case <ryandcase@chromium.org>,
	Randall Spangler <rspangler@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority
Date: Fri, 12 Apr 2019 11:23:19 +0200	[thread overview]
Message-ID: <9fce8b1c-e277-2eeb-4b0d-e6b0e1851419@collabora.com> (raw)
In-Reply-To: <CA+ASDXNmxspD_3p-BftgySn5mPSYvSTeEXkzNS9B+ReZho-Uyw@mail.gmail.com>

Hi,

On 12/4/19 3:27, Brian Norris wrote:
> On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson <dianders@chromium.org> wrote:
>> +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev,
>> +                                struct cros_ec_command *ec_msg,
>> +                                cros_ec_xfer_fn_t fn)
>> +{
>> +       struct cros_ec_xfer_work_params params;
>> +
>> +       INIT_WORK(&params.work, cros_ec_xfer_high_pri_work);
> 
> Sorry for the late review, but this should have been
> INIT_WORK_ONSTACK(). Should it be a new patch, or is this in a
> non-rebasing tree yet?
> 

No need to resend, I'll do the modification myself and push again.

Thanks,
 Enric

> Otherwise, looks fine to me:
> 
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> 

      reply	other threads:[~2019-04-12  9:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 20:31 Douglas Anderson
2019-04-03 21:04 ` Matthias Kaehlcke
2019-04-03 21:08   ` Doug Anderson
2019-04-03 21:19     ` Matthias Kaehlcke
2019-04-04 15:00       ` Enric Balletbo i Serra
2019-04-12  1:27 ` Brian Norris
2019-04-12  9:23   ` Enric Balletbo i Serra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9fce8b1c-e277-2eeb-4b0d-e6b0e1851419@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=amstan@chromium.org \
    --cc=bleung@chromium.org \
    --cc=briannorris@chromium.org \
    --cc=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=groeck@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mka@chromium.org \
    --cc=rspangler@chromium.org \
    --cc=ryandcase@chromium.org \
    --cc=sjg@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome