From: Ben Hutchings <ben@decadent.org.uk>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Salvatore Bonaccorso <carnil@debian.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Use $KBUILD_BUILD_TIMESTAMP as man page date
Date: Sat, 13 May 2023 20:51:16 +0200 [thread overview]
Message-ID: <9fcf1d5f1612d45b60a65340d125364c5ae26dfb.camel@decadent.org.uk> (raw)
In-Reply-To: <ZFuVRK4cKapgaRwD@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2168 bytes --]
On Wed, 2023-05-10 at 09:59 -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 09, 2023 at 09:03:28PM +0200, Salvatore Bonaccorso escreveu:
> > Hi Peter, Ingo, Arnaldo,
> >
> > On Tue, May 17, 2016 at 02:28:09PM +0100, Ben Hutchings wrote:
> > > This allows man pages to be built reproducibly.
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > ---
> > > --- a/tools/perf/Documentation/Makefile
> > > +++ b/tools/perf/Documentation/Makefile
> > > @@ -120,6 +120,9 @@ endif
> > > ifdef DOCBOOK_SUPPRESS_SP
> > > XMLTO_EXTRA += -m manpage-suppress-sp.xsl
> > > endif
> > > +ifdef KBUILD_BUILD_TIMESTAMP
> > > +ASCIIDOC_EXTRA += -a revdate=$(shell date -u -d '$(KBUILD_BUILD_TIMESTAMP)' +%Y-%m-%d)
> > > +endif
> > >
> > > SHELL_PATH ?= $(SHELL)
> > > # Shell quote;
> > > --- a/tools/perf/Documentation/asciidoc.conf
> > > +++ b/tools/perf/Documentation/asciidoc.conf
> > > @@ -71,6 +71,9 @@ ifdef::backend-docbook[]
> > > [header]
> > > template::[header-declarations]
> > > <refentry>
> > > +<refentryinfo>
> > > +template::[docinfo]
> > > +</refentryinfo>
> > > <refmeta>
> > > <refentrytitle>{mantitle}</refentrytitle>
> > > <manvolnum>{manvolnum}</manvolnum>
> >
> > As we do apply the change in Downstream in Debian, I was wondering if
> > it just felt trough the cracks and could still be applied. Is there
> > anything missing?
>
> Isn't this fixed in:
>
> commit d586ac10ce56b2381b8e1d8ed74660c1b2b8ab0d
> Author: Ian Rogers <irogers@google.com>
> Date: Fri Sep 20 21:13:27 2019 -0700
>
> perf docs: Allow man page date to be specified
>
> With this change if a perf_date parameter is provided to asciidoc then
> it will override the default date written to the man page metadata.
[...]
Not entirely, because the value for perf_date is currently generated
with "git log", and Debian package builds are not done from a Git
checkout. I'll revise my patch to allow perf_date to be set from
KBUILD_BUILD_TIMESTAMP, which is already used in the kernel build.
Ben.
--
Ben Hutchings
Life would be so much easier if we could look at the source code.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-05-13 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 13:28 Ben Hutchings
2023-05-09 19:03 ` Salvatore Bonaccorso
2023-05-10 12:59 ` Arnaldo Carvalho de Melo
2023-05-13 18:51 ` Ben Hutchings [this message]
2023-05-13 19:33 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fcf1d5f1612d45b60a65340d125364c5ae26dfb.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=carnil@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®