From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8499E28AB0B for ; Fri, 26 Sep 2025 08:55:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758876921; cv=none; b=HeyY9g70XWzx2mEWOIt8V8pcmVUjM0/PKW1CVQhyLTfPU74UA2aWlz7/NzMhGaE+RhjuGzbwfMLK7HgYzvh8X2+/f5bvwiS2L7tX9yyRUjuk4tW/cJ26XNLr5JvMUDpV2kbDIrmUQMoyC/ZxqW9xQGxzYDF0nvERxSabYPCzLis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758876921; c=relaxed/simple; bh=H3oclPLZNC4FPP4H+RvI7lOCqvvODgPKvGIwZ8+Tfhc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mHN+srwja0R5tJcY8I6PA/lYdOJ4DzMzyHgyS9mTovVIiCsJ3J2+XspHT2mpRRKrhQ5nmN6NKcF20yjsQ08z+ruU04yabPiiqKj1uOUvwioVXcahdhxlxbxEbqf+CWCa63MRX4IlHT9MzAErPCgyHkbgXSejFcTBJlnpiy+qpXo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xz6raaDi; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xz6raaDi" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58Q71AJt000853 for ; Fri, 26 Sep 2025 08:55:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YZwahU0c/LPU8BcKe/dMgehNfskCJrh2bk5U3NX1qmk=; b=Xz6raaDiQz6E4hD/ Xzj25pAphxef/808b8ckaykidndJvOY+tWWYQT3e7CIVN9czC2KvD8tvF2z2+9z3 teIK/jMRH9Q60SU5kYvGxOoZhqP0BYoq0e+yUqsgZI0oBRDXwcAALyioEyPbfNpB PULoO8J8SMI/5b+fARKt6gsV0uGvxpTXNTvZUrL0MyF1Opq9nKvQ69yImBSd69EJ UgnL2qjhen3dxGQXYlS66YZlTi/OyJ7M2OpSGqFZkaug1SPgmApSvnTWbwoTGDOI iKdh20HrWzsKJADL7vtcjeaOwGUKe7W8AHSDEQJzT83XIX4bfzU2afSP5tt0YFQJ guYeuw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49db0tt6ge-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 26 Sep 2025 08:55:18 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-82b15c1dca8so75708385a.1 for ; Fri, 26 Sep 2025 01:55:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758876917; x=1759481717; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YZwahU0c/LPU8BcKe/dMgehNfskCJrh2bk5U3NX1qmk=; b=rvvQVbRLKiJbXOM5yB1F9KWtIzgGV2iCr7D7ZZRargLg5d27gD+a+wCrvDT8BzQQCN Dh9CPTKlKuO/gw85TQhGxAfiEqsYuty2svQjk/8k87XnB1pcz/KYz+uk+jJK30F4tr2w 2eNm2EabOnzmP4PP8wVkx1MlKYeri50SLm2xBuE8+YljuuvnMymgQODSzPr71h4rgMKF 4oH2oXhqa6r+FQGm2jIj9BD3npi/ouKGEt00MABmAZAhDbr6skKNfl1+XnXGHaQqAcqC 81/wDpsuXzrLOds6KwTQd4PXjhIgAeTaeP2DlH4a1wuCzibBw5pqCtcKAFy2dqF6fo9d p3+A== X-Forwarded-Encrypted: i=1; AJvYcCUX2IIIdjGqNfG/JvijR4EAJ0wQ/hisjWTe60m36yIvspDL4qm0k+CQtF7na3+Ow8XZWvM99DTixsCiOVA=@vger.kernel.org X-Gm-Message-State: AOJu0YzesEBBzhuz1lgTHzx6UMWyn4JYWTyProN52/GYV+w+k15barCN OJ3KBQJs2WlmTYwb6co/5H1iuEk+NLvTYKzo0QWdjqmXSiCeis8qlpEYuDqC/TjlMP3zHweDQrr lSZojlvgtpHTzZ+8gV4I7UPNusPOGie/GLXJSBhuSkYQLpaC6MM8QxxJuFvgeXGM+19M= X-Gm-Gg: ASbGnct1r7BiWUuP/J9PVsOchpEVWGkPjn9zhkja0q8GF6Z0Au8WxKNSUlthL3bwTRz POpZvbHhQYer4bpn68HErA7RiFmYGJg2NcfMdCZql3KNmDipdHf+XApJMR9X//f5owmpHlTIJ8Z jbnjm1kHcRtxbFdmGScgpMeGWTYNvBG4H7Vnazeo8HKsJmJ5piEqVjjzYy33Un62EvAPBLs0AUN OEK7WBGIB3McghH5e9kKiW49ZmiqtEgDBPbcRvoP9HDgeNb20ugzJIMRTe1ratLnYyFLHpTdwFQ 6ngIY4I8Ab11BJwYNmiU2ekHarlVgWj8mxl1YL9OpAv/TXfgccufeYKFp72Hu5knVOk6T5+hs7t QEXLw/7Wt8E2Ce1CJNUvdnA== X-Received: by 2002:a05:620a:4722:b0:856:6bcd:4adc with SMTP id af79cd13be357-85ae6d81b82mr523497285a.9.1758876917349; Fri, 26 Sep 2025 01:55:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRRY3Uq60Ht2WVCNKABn0E4Jb7bHcKPpmbGoeQFqat2Wl0O7Ko5BzeVbNeba66xZoL423QRA== X-Received: by 2002:a05:620a:4722:b0:856:6bcd:4adc with SMTP id af79cd13be357-85ae6d81b82mr523495185a.9.1758876916746; Fri, 26 Sep 2025 01:55:16 -0700 (PDT) Received: from [192.168.149.223] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b35446f7547sm324068866b.67.2025.09.26.01.55.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Sep 2025 01:55:16 -0700 (PDT) Message-ID: <9fcf3835-a88e-4e0d-a970-064d696c62a2@oss.qualcomm.com> Date: Fri, 26 Sep 2025 10:55:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/24] arm64: dts: qcom: Update pmh0104 dtsi for Glymur CRD To: Pankaj Patil , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Kamal Wadhwa References: <20250925-v3_glymur_introduction-v2-0-8e1533a58d2d@oss.qualcomm.com> <20250925-v3_glymur_introduction-v2-13-8e1533a58d2d@oss.qualcomm.com> <7eb0af93-7cc6-4b1f-beea-d5663c1bbd59@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <7eb0af93-7cc6-4b1f-beea-d5663c1bbd59@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I9Vohdgg c=1 sm=1 tr=0 ts=68d654f6 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=EUspDBNiAAAA:8 a=SJhbF7H-XdBiwAQF7hIA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: rn54wEavlobte5tmz5BL9ikVfKfenxrR X-Proofpoint-ORIG-GUID: rn54wEavlobte5tmz5BL9ikVfKfenxrR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTI1MDE3MSBTYWx0ZWRfXw0o4ydQF/HjP OSRYsP9Gs6jVO5v1NJyKAWOqFB1HNt5V17i67JseKkfQDZ/QMGBpawu00hYcwATE5R46YPzewGW WnumI1nPt1eqEOeu6pXhz2Sz+BxkDrW4R43nGbpN2EkYrQvtTHjveZO8gyCClvr+jPg8pXfR5dC izQcTcd/l5hqGLDOsWuJkyX7CT0XKhv+4+UmJlwzouAMmV3Rzg6gY75KJb1UwSRn7omzOp8qoUS QZBEHtsMfc7q+MvmDaqdHAzNUcJBuMgeKoDfLdY78d1MFbFTHTUXx3ElWR7/3XMtGmbonN312ti sai1KFPPjT4cfarLEMeLYcM463if9Qbrh3beTK5GJQwcHmYbwwSeOFJbO5aoG9YcRYwaLWxUlIW 8ir5TtKbzypoQcPmxrHlwU/op1DlZw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-26_02,2025-09-26_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2509150000 definitions=main-2509250171 On 9/26/25 9:07 AM, Pankaj Patil wrote: > On 9/25/2025 1:25 PM, Krzysztof Kozlowski wrote: >> On Thu, 25 Sept 2025 at 15:29, Pankaj Patil >> wrote: >>> From: Kamal Wadhwa >>> >>> Update the pmh0104.dtsi to include multiple instances of PMH0104 >>> DT nodes, one for each SID assigned to this PMIC on the spmi_bus0 >>> and spmi_bus1 in Glymur CRD board. >>> >>> Take care to avoid compilation issue with the existing nodes by >>> gaurding each PMH0104 nodes with `#ifdef` for its corresponding >>> SID macro. So that only the nodes which have the their SID macro >>> defined are the only ones picked for compilation. >>> >>> Signed-off-by: Kamal Wadhwa >>> Signed-off-by: Pankaj Patil >>> --- >>> arch/arm64/boot/dts/qcom/pmh0104.dtsi | 84 +++++++++++++++++++++++++++++++++++ >>> 1 file changed, 84 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/pmh0104.dtsi b/arch/arm64/boot/dts/qcom/pmh0104.dtsi >>> index f5393fdebe957ea0caf4bbc16117374b4759bda3..d3ea7486d842ec813a79268fc1466e1513426d78 100644 >>> --- a/arch/arm64/boot/dts/qcom/pmh0104.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/pmh0104.dtsi >>> @@ -6,7 +6,63 @@ >>> #include >>> #include >>> >>> +&spmi_bus0 { >>> +#ifdef PMH0104_I_E0_SID >> >> NAK >> >> I'm surprised you decided to ignore all existing discussions and my >> clear point in this. >> >> This is neither readable, nor maintainable. >> >> Please join community in discussing this, instead of coming with >> another invention which I already said is poor. >> >> Best regards, >> Krzysztof > Please ignore this series, it was sent by mistake as v2 prior to v1. > I've replied to the cover letter mentioning the same. > > I'll update the v1 and re-post with all the comments taken care off. (Please make sure you mark it as v3 then to prevent confusing the tooling) Konrad