From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7468C433E1 for ; Thu, 13 Aug 2020 14:56:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B77DC20781 for ; Thu, 13 Aug 2020 14:56:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="2Av2azx9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726686AbgHMO4f (ORCPT ); Thu, 13 Aug 2020 10:56:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726167AbgHMO4e (ORCPT ); Thu, 13 Aug 2020 10:56:34 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4BE6C061757 for ; Thu, 13 Aug 2020 07:56:33 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id a5so7489637ioa.13 for ; Thu, 13 Aug 2020 07:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2N3vz3aoKozJuLd8HhRVAVV0+DlbtHXg7rxrCEwGelY=; b=2Av2azx9MhIvUoXaAZXBnYYlP5YN9u45JAgTOqjgnW9MJlQOpjRtOVGtv6zITH6N20 34yQMx+43blJDN9CwZEFY2EGFBSsba0p7OCFNYfgpJSDFcynpdO0ziqX1zJsENMYMkzE /YFiX8ORzlZ5qq/qP0TrVKNgjawRTN2sOsyMErmwsJ1hspoYM3E2/JB38VF7rRMBQALL RK2riwofKiC7kxl4YkPouojYjjgcZLoi3D7TOPvCuSvY39rCq/W9EkN5PFt1Aul+2Z2O Su1r9y0eBcGqgPhekBoedLpDnYcwNO121jDyo36iJnos86vrInbGyoO/LfAa6EhlqzMT G/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2N3vz3aoKozJuLd8HhRVAVV0+DlbtHXg7rxrCEwGelY=; b=F6c6zepeS57aoFdIlKXlRMZBKBfDfnT5uDtJGsI7AUHGCESfwCbBLE8Y8iKW8gHJTN 5gUprkB3yrQEREmIpJRgVvC0NTO/51hCvQ0e5XgCtH/Ohr0HUrOHed9gUcG4UNm3GL8d QLNeXsvPeuUWZsqupM23WkZZtqdRnnOSWHeLvqKlnH74lRVQ6eAsi/ST/ECFgduT29Y8 zthZ1H0nSJ8FspYhnVZSn3a6sIwv1kOJlSmL9CTQdRvJSDD+YDB/jTNDLJbsI6MJDJVL 699aeeacRJfbpYSsP0jZaPwM4ERUTBEYIn2KmWr+xCNRbtBhXWSwhOZLv5doOtrG64Xj Mxfg== X-Gm-Message-State: AOAM5305phj1MD1cJfPBAd1+WsLBlsCQMKLQV/6T/T+G24qo/MKH0d7V hs2VnIf0ZcD2O0+9YEyJKKDS9A== X-Google-Smtp-Source: ABdhPJw2yxzFwbHDrUKj9GjW5VjBSwwvqRtbrnuWKdCOX0w5kMRjsicXpo2Tt4m8J+or3X1H7vOCdQ== X-Received: by 2002:a02:6d5d:: with SMTP id e29mr5296096jaf.139.1597330591852; Thu, 13 Aug 2020 07:56:31 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id l2sm2892965ilt.2.2020.08.13.07.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Aug 2020 07:56:31 -0700 (PDT) Subject: Re: [PATCH] fs/io_uring.c: Fix uninitialized variable is referenced in io_submit_sqe To: Liu Yong Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20200813065644.GA91891@ubuntu> From: Jens Axboe Message-ID: <9fd08f8f-8c89-9c59-6d9e-5933ccc65967@kernel.dk> Date: Thu, 13 Aug 2020 08:56:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200813065644.GA91891@ubuntu> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/13/20 12:56 AM, Liu Yong wrote: > the commit ("opcode>") > caused another vulnerability. After io_get_req(), the sqe_submit struct > in req is not initialized, but the following code defaults that > req->submit.opcode is available. Thanks, I'll add this for 5.4-stable, it doesn't affect any kernels newer than that. -- Jens Axboe