From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90CE1C4167B for ; Mon, 11 Dec 2023 08:11:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbjLKIKz (ORCPT ); Mon, 11 Dec 2023 03:10:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233910AbjLKIKt (ORCPT ); Mon, 11 Dec 2023 03:10:49 -0500 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B581DD5 for ; Mon, 11 Dec 2023 00:10:54 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046060;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0VyDC938_1702282251; Received: from 30.97.48.179(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0VyDC938_1702282251) by smtp.aliyun-inc.com; Mon, 11 Dec 2023 16:10:52 +0800 Message-ID: <9fd5a85e-2521-4295-938b-bedb9ee1b67b@linux.alibaba.com> Date: Mon, 11 Dec 2023 16:10:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/5] erofs: support I/O submission for sub-page compressed blocks To: linux-erofs@lists.ozlabs.org Cc: LKML , dhavale@google.com, Yue Hu References: <20231206091057.87027-1-hsiangkao@linux.alibaba.com> <20231206091057.87027-2-hsiangkao@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20231206091057.87027-2-hsiangkao@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/12/6 17:10, Gao Xiang wrote: > Add a basic I/O submission path first to support sub-page blocks: > > - Temporary short-lived pages will be used entirely; > > - In-place I/O pages can be used partially, but compressed pages need > to be able to be mapped in contiguous virtual memory. > > As a start, currently cache decompression is explicitly disabled for > sub-page blocks, which will be supported in the future. > > Signed-off-by: Gao Xiang ... > + cur = mdev.m_pa; > + end = cur + pcl->pclusterpages << PAGE_SHIFT; In this patch, here should be end = cur + (pcl->pclusterpages << PAGE_SHIFT); but since this line will be immediately updated in the next patch as `end = cur + pcl->pclustersize;` so it will have no impact. I've fixed it up in the development tree. Thanks, Gao Xiang