From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41BB9CD98E3 for ; Wed, 11 Oct 2023 01:26:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344620AbjJKB0A (ORCPT ); Tue, 10 Oct 2023 21:26:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344484AbjJKBZ7 (ORCPT ); Tue, 10 Oct 2023 21:25:59 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8FED8F; Tue, 10 Oct 2023 18:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=jrBARauvKO5bXj4/z3JabNLTPC5n3Bm+xpPysDJ+pI4=; b=B9uIJsB/DtjzIKSFaoJWTj2obe w27vMYq7GufA8gdAaNleiqpJMpuKvQJe5LBk+lY1Jw35b1Ii/7YL2IgqKGVujLYO/1qQA27gRrYIR CVdbgPENQnJ9rrwywzDo+/rMuzuZtsiZOF5LFax5HzTjldGI5q9EDaLD5Qdo4qeMzQ+Y=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qqNyu-001PlJ-TW; Wed, 11 Oct 2023 03:25:48 +0200 Date: Wed, 11 Oct 2023 03:25:48 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , "open list:DOCUMENTATION" , "open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER" Subject: Re: [PATCH net-next 2/2] net: dsa: Rename IFLA_DSA_MASTER to IFLA_DSA_CONDUIT Message-ID: <9fd77135-22df-4d3f-a0a5-9548829d4124@lunn.ch> References: <20231010213942.3633407-1-florian.fainelli@broadcom.com> <20231010213942.3633407-3-florian.fainelli@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231010213942.3633407-3-florian.fainelli@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > enum { > IFLA_DSA_UNSPEC, > - IFLA_DSA_MASTER, > + IFLA_DSA_MASTER, /* Deprecated, use IFLA_DSA_CONDUIT instead */ > + IFLA_DSA_CONDUIT = IFLA_DSA_MASTER, > __IFLA_DSA_MAX, > }; Minor point, but maybe it seems better if we flip this around? enum { IFLA_DSA_UNSPEC, - IFLA_DSA_MASTER, + IFLA_DSA_CONDUIT, + IFLA_DSA_MASTER = IFLA_DSA_CONDUIT, /* Deprecated */ __IFLA_DSA_MAX, }; Reviewed-by: Andrew Lunn Andrew