Re: [PATCH] ufs: core: Initialize a variable mode for PA_PWRMODE

["Peter Wang (王信友)" <peter.wang@mediatek.com>]

On Thu, 2025-10-02 at 16:00 +0900, Wonkon Kim wrote:
> 
> If ufshcd_dme_get() fails uic cmd error,
> a variable mode has a garbage value.
> It may return unintended result for pwr mode restore.
> 
> Initialize it as 0 and will return true when ufshcd_dme_get() fails,
> because PA power mode 0 is not defined.
> 
> Signed-off-by: Wonkon Kim <wkon.kim@samsung.com>
> ---
>  drivers/ufs/core/ufshcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 9a43102b2b21..a4438a3cb73a 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6581,7 +6581,7 @@ static inline void
> ufshcd_recover_pm_error(struct ufs_hba *hba)
>  static bool ufshcd_is_pwr_mode_restore_needed(struct ufs_hba *hba)
>  {
>         struct ufs_pa_layer_attr *pwr_info = &hba->pwr_info;
> -       u32 mode;
> +       u32 mode = 0;
> 
>         ufshcd_dme_get(hba, UIC_ARG_MIB(PA_PWRMODE), &mode);
> 
> --
> 2.34.1
> 

Reviewed-by: Peter Wang <peter.wang@mediatek.com>