From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbdBIJY1 (ORCPT ); Thu, 9 Feb 2017 04:24:27 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:55986 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752179AbdBIJYZ (ORCPT ); Thu, 9 Feb 2017 04:24:25 -0500 To: Jay Vosburgh , Andy Gospodarek CC: From: zhou zhengwu Subject: =?UTF-8?Q?[BUG]_port=ef=bc=88belong_to_a_lacp_aggregate_group?= =?UTF-8?Q?=ef=bc=89cannot_be_unselected_while_the_connected_port_failed?= Message-ID: <9fdee5fd-6e06-6bac-bca7-d5c5ea547177@huawei.com> Date: Thu, 9 Feb 2017 17:19:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.25.115] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.589C3518.0359,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 14a218908b647bb609f349692a1c05ad Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi [1] Testing OS: SUSE 11SP3( kernel version 3.0.93) [2]Problem description: ServerA [bond] ----------- [bond] ServerB Two servers are connected with bonding interfaces LACP is enabled. Firstly, it works well. Then, one port (for example, port B) in serverB failed, it can send but not receive packets including the LACPDU however the port status is still UP. Result: In serverB, port B is unselected and traffic is sent through other aggregate port. While In serverA, port A connecting with port B of serverB is still selected by LACP and traffic is still sent through it [3]Two question about the implementation of LACP RX machine: 1. Following judging condition marked with “*” is reasonable? static void ad_rx_machine(struct lacpdu *lacpdu, struct port *port) { ……………………. case AD_RX_CURRENT: // detect loopback situation if (!MAC_ADDRESS_COMPARE(&(lacpdu->actor_system), &(port->actor_system))) { // INFO_RECEIVED_LOOPBACK_FRAMES pr_err("%s: An illegal loopback occurred on adapter (%s).\n" "Check the configuration to verify that all adapters are connected to 802.3ad compliant switch ports\n", port->slave->dev->master->name, port->slave->dev->name); return; } __update_selected(lacpdu, port); __update_ntt(lacpdu, port); __record_pdu(lacpdu, port); port->sm_rx_timer_counter = __ad_timer_to_ticks(AD_CURRENT_WHILE_TIMER, (u16)(port->actor_oper_port_state & AD_STATE_LACP_TIMEOUT)); port->actor_oper_port_state &= ~AD_STATE_EXPIRED; // verify that if the aggregator is enabled, the port is enabled too. //(because if the link goes down for a short time, the 802.3ad will not // catch it, and the port will continue to be disabled) ***** if (port->aggregator ***** && port->aggregator->is_active ***** && !__port_is_enabled(port)) ***** __enable_port(port); -------------------- is the judging condition reasonable? break; ……………………. } 2. While lacp rx machine receive the lacpdu packets, whether the port should be selected or not should be done. Currently,if lacp rx machine is in AD_RX_CURRENT and if the partner's configuration is unchanged, port will still be selected. However, it is not reasonable in some conditions. For example, partner port failed which can send but not receive pkts. At the same time, the port still be UP. static void __update_selected(struct lacpdu *lacpdu, struct port *port) { if (lacpdu && port) { const struct port_params *partner = &port->partner_oper; // check if any parameter is different if (ntohs(lacpdu->actor_port) != partner->port_number || ntohs(lacpdu->actor_port_priority) != partner->port_priority || MAC_ADDRESS_COMPARE(&lacpdu->actor_system, &partner->system) || ntohs(lacpdu->actor_system_priority) != partner->system_priority || ntohs(lacpdu->actor_key) != partner->key || (lacpdu->actor_state & AD_STATE_AGGREGATION) != (partner->port_state & AD_STATE_AGGREGATION)) { // update the state machine Selected variable port->sm_vars &= ~AD_PORT_SELECTED; } } }