From: Hans de Goede <hdegoede@redhat.com>
To: "Sebastian Reichel" <sebastian.reichel@collabora.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] power: supply: test-power: implement charge_behaviour property
Date: Wed, 27 Mar 2024 11:44:41 +0100 [thread overview]
Message-ID: <9fe3d7a6-3b34-4c96-bd9f-510b41f9ab0d@redhat.com> (raw)
In-Reply-To: <6f0761a6-5f49-42e2-9b79-3e04c9d259a4@redhat.com>
Hi,
On 3/27/24 11:36 AM, Hans de Goede wrote:
> Hi Sebastian,
>
> On 3/26/24 8:50 PM, Sebastian Reichel wrote:
>>
>> On Wed, 06 Mar 2024 20:37:04 +0100, Thomas Weißschuh wrote:
>>> To validate the special formatting of the "charge_behaviour" sysfs
>>> property add it to the example driver.
>>>
>>>
>>
>> Applied, thanks!
>>
>> [1/1] power: supply: test-power: implement charge_behaviour property
>> commit: 070c1470ae24317e7b19bd3882b300b6d69922a4
>
> Does this mean that you've also applied patches 1-3 of:
> "[PATCH v2 0/4] power: supply: core: align charge_behaviour format with docs" ?
>
> Because this is a new version of 4/4 of that series and I think
> that the new test may depend on the fixes from patches 1-3
> of that series (which I'm reviewing now).
Ok, I have some not entirely trivial comments on patch 3/4 of that series.
I guess you (Sebastian) could address those while merging, or wait for
a v3 of the series.
Regards,
Hans
next prev parent reply other threads:[~2024-03-27 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 19:37 Thomas Weißschuh
2024-03-26 19:50 ` Sebastian Reichel
2024-03-27 10:36 ` Hans de Goede
2024-03-27 10:44 ` Hans de Goede [this message]
2024-03-27 13:25 ` Sebastian Reichel
2024-03-27 13:34 ` Hans de Goede
2024-03-27 18:30 ` Thomas Weißschuh
2024-03-27 19:13 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe3d7a6-3b34-4c96-bd9f-510b41f9ab0d@redhat.com \
--to=hdegoede@redhat.com \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®