From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukas Timmermann <linux@timmermann.space>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Alexandre Marquet <tb@a-marquet.fr>
Subject: Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)
Date: Fri, 28 Nov 2025 10:01:44 +0100 [thread overview]
Message-ID: <9ff65dc6-6f13-47f0-966c-f9885288843e@kernel.org> (raw)
In-Reply-To: <jqfu76ojoznc7xgyevuzmj7fg3necrr5cp645ye5zk652ytx5w@s4yaxzcq7jzt>
On 27/11/2025 21:01, Lukas Timmermann wrote:
>>> +
>>> + lid-switch {
>>> + label = "Lid";
>>> + gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
>>> + linux,input-type = <5>; /* EV_SW */
>>> + linux,code = <0>; /* SW_LID */
>>> + debounce-interval = <10>;
>>> + wakeup-source;
>>> + };
>>> + };
>>> +
>>> + multi-led {
>>> + compatible = "leds-group-multicolor";
>>> + color = <LED_COLOR_ID_RGB>;
>>> + function = LED_FUNCTION_STATUS;
>>> + leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
>>> + };
>>> +
>>> + wlan_pwrseq: mmc1-pwrseq {
>>
>> Just "pwrseq"
>>
> Acknowledged.
> Just out of curiosity. Why is that?
You have only one pwrseq device, so not need to precise which one is
that and node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-28 9:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 15:12 [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10) Lukas Timmermann
2025-11-25 15:12 ` [PATCH v2 1/3] dt-bindings: ARM: samsung: Add Google Manta (Nexus 10) Lukas Timmermann
2025-11-25 15:12 ` [PATCH v2 2/3] ARM: dts: exynos: " Lukas Timmermann
2025-11-26 9:10 ` Krzysztof Kozlowski
2025-11-27 20:01 ` Lukas Timmermann
2025-11-28 9:01 ` Krzysztof Kozlowski [this message]
2025-11-25 15:12 ` [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot Lukas Timmermann
2025-11-26 9:24 ` Krzysztof Kozlowski
2025-11-27 11:53 ` Lukas Timmermann
2025-12-04 11:22 ` Pavel Machek
2025-12-04 11:51 ` Krzysztof Kozlowski
2025-12-04 11:53 ` Pavel Machek
2025-12-04 11:54 ` Krzysztof Kozlowski
2025-12-04 11:55 ` Pavel Machek
2025-12-04 12:02 ` Krzysztof Kozlowski
2025-12-04 12:38 ` Pavel Machek
2025-11-25 15:20 ` [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10) Krzysztof Kozlowski
2025-11-25 15:22 ` Krzysztof Kozlowski
2025-11-26 22:46 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ff65dc6-6f13-47f0-966c-f9885288843e@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@timmermann.space \
--cc=robh@kernel.org \
--cc=tb@a-marquet.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®