From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753765AbdLMQvF (ORCPT ); Wed, 13 Dec 2017 11:51:05 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:35564 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753749AbdLMQu7 (ORCPT ); Wed, 13 Dec 2017 11:50:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AF54560A3B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH] PCI/AER: update AER status string print to match other AER logs To: Bjorn Helgaas Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org References: <1508254922-30925-1-git-send-email-tbaicar@codeaurora.org> <6d5b3747-ceb7-d47f-9d5f-47aa69ec33cf@codeaurora.org> <20171115175636.GA1794@bhelgaas-glaptop.roam.corp.google.com> From: Tyler Baicar Message-ID: <9ff7829c-02b7-ba51-3609-08fd9468106a@codeaurora.org> Date: Wed, 13 Dec 2017 11:50:56 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171115175636.GA1794@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/15/2017 12:56 PM, Bjorn Helgaas wrote: > Hi Tyler, > > On Wed, Nov 15, 2017 at 09:47:41AM -0500, Tyler Baicar wrote: >> On 10/17/2017 11:42 AM, Tyler Baicar wrote: >>> Currently the AER driver uses cper_print_bits() to print the AER status >>> string. This causes the status string to not include the proper PCI device >>> name prefix that the other AER prints include. Also, it has a different >>> print level than all the other AER prints. >>> >>> Update the AER driver to print the AER status string with the proper string >>> prefix and proper print level. >> Hello, >> >> Will this patch be pulled into 4.15? > Sorry, I am preparing the 4.15 pull request right now, and it doesn't > include this change. > > I do like the dev_err() change, but would prefer fewer lines of > output. I could have applied just the dev_err() change, but to > minimize pain for people who parse the logs, I'd rather make one > change in the output instead of making one change now and another > later. Hello Bjorn, Are there existing abbreviations for these AER status strings that I cannot find? Or do you want me to abbreviate them similar to the style used with prints in lspci -vv? Once they are abbreviated, you'd prefer to have all errors that have occurred to be printed on the same line, correct? Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.