From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751600AbbKPTi7 (ORCPT ); Mon, 16 Nov 2015 14:38:59 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:56255 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750910AbbKPTi6 (ORCPT ); Mon, 16 Nov 2015 14:38:58 -0500 From: Punit Agrawal To: Guenter Roeck Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Jean Delvare , lm-sensors@lm-sensors.org Subject: Re: [v2] hwmon: (scpi) skip unsupported sensors properly References: <1446052651-9024-1-git-send-email-sudeep.holla@arm.com> <20151116175920.GA15811@roeck-us.net> Date: Mon, 16 Nov 2015 19:37:14 +0000 In-Reply-To: <20151116175920.GA15811@roeck-us.net> (Guenter Roeck's message of "Mon, 16 Nov 2015 09:59:20 -0800") Message-ID: <9hh1tbprb11.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Guenter Roeck writes: > On Wed, Oct 28, 2015 at 05:17:31PM +0000, Sudeep Holla wrote: >> Currently it's assumed that firmware exports only the class of sensors >> supported by the driver. However with newer firmware or SCPI protocol >> revision, support for newer classes of sensors can be present. >> >> The driver fails to probe with the following warning if an unsupported >> class of sensor is encountered in the firmware. >> >> sysfs: cannot create duplicate filename >> '/devices/platform/scpi/scpi:sensors/hwmon/hwmon0/' >> ------------[ cut here ]------------ >> WARNING: at fs/sysfs/dir.c:31 >> Modules linked in: >> >> CPU: 0 PID: 6 Comm: kworker/u12:0 Not tainted 4.3.0-rc7 #137 >> Hardware name: ARM Juno development board (r0) (DT) >> Workqueue: deferwq deferred_probe_work_func >> PC is at sysfs_warn_dup+0x54/0x78 >> LR is at sysfs_warn_dup+0x54/0x78 >> >> This patch fixes the above issue by skipping through the unsupported >> class of SCPI sensors. >> >> Fixes: 68acc77a2d51 ("hwmon: Support thermal zones registration for SCP temperature sensors") >> Fixes: ea98b29a05e9 ("hwmon: Support sensors exported via ARM SCP interface") >> Cc: Guenter Roeck >> Reviewed-by: Punit Agrawal >> Signed-off-by: Sudeep Holla >> Acked-by: Guenter Roeck > > In the assumption that this patch can now be applied, I queued it up > for the next -rc. Looks like our emails crossed on the wire. :) Thanks for applying the patch. Punit > > Guenter > >> --- >> drivers/hwmon/scpi-hwmon.c | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> [...]