From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754754AbbINOj0 (ORCPT ); Mon, 14 Sep 2015 10:39:26 -0400 Received: from fw-tnat.cambridge.arm.com ([217.140.96.140]:58564 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751496AbbINOjY (ORCPT ); Mon, 14 Sep 2015 10:39:24 -0400 From: Punit Agrawal To: Mark Rutland Cc: "linux-arm-kernel\@lists.infradead.org" , "devicetree\@vger.kernel.org" , Sudeep Holla , "linux-pm\@vger.kernel.org" , "lm-sensors\@lm-sensors.org" , Liviu Dudau , "edubezval\@gmail.com" , "linux\@roeck-us.net" , "linux-kernel\@vger.kernel.org" , "robh+dt\@kernel.org" Subject: Re: [PATCH v3 1/5] Documentation: add DT bindings for ARM SCPI sensors References: <1442235619-4029-1-git-send-email-punit.agrawal@arm.com> <1442235619-4029-2-git-send-email-punit.agrawal@arm.com> <20150914131448.GC7002@leverpostej> <9hhh9mxf7lg.fsf@e105922-lin.cambridge.arm.com> <20150914134949.GE7002@leverpostej> Date: Mon, 14 Sep 2015 15:38:36 +0100 In-Reply-To: <20150914134949.GE7002@leverpostej> (Mark Rutland's message of "Mon, 14 Sep 2015 14:49:49 +0100") Message-ID: <9hhk2rtdq1f.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Rutland writes: >> >> +Sensor bindings for the sensors based on SCPI Message Protocol >> >> +-------------------------------------------------------------- >> >> +SCPI provides an API to access the various sensors on the SoC. >> >> + >> >> +Required properties: >> >> +- compatible : should be "arm,scpi-sensors". >> >> +- #thermal-sensor-cells: should be set to 1. This property follows the >> >> + thermal device tree bindings[2]. >> > >> > You need to specify what the valid values for this cell are. >> >> The enumeration depends on the number of sensors exported by SCP >> firmware - which is platform dependent. I could add add something like >> if you think that is helpful - >> >> "Valid cell value is a number between 0..n-1, where n is the number >> of sensors exported by SCP firmware." > > Can the FW identifer space have holes? Or are they always contiguous? The way the SCP interface is defined, the sensor identifiers are contiguous, but not all are temperature sensors. > > If this is the same as the raw FW identifer value, specify that. > Otherwise, you need to specify the mapping. I'll update the patch to add mappings for Juno r0 (and r1 if I can get my hands on one). > > There needs to be enough information for a dts author to figure out > which values to place in the DT. I understand. Except sometimes it is hard to get the firmware to commit to not modify the ordering - discoverability and all that. :) > > Thanks, > Mark. > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html