mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Punit Agrawal <punit.agrawal@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, viresh.kumar@linaro.org,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	edubezval@gmail.com, dawei.chien@mediatek.com,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH v3 1/3] devicetree: bindings: Add optional dynamic-power-coefficient property
Date: Mon, 09 Nov 2015 18:39:35 +0000	[thread overview]
Message-ID: <9hhvb9b6mqg.fsf@e105922-lin.cambridge.arm.com> (raw)
In-Reply-To: <20151109174542.GA19016@rob-hp-laptop> (Rob Herring's message of "Mon, 9 Nov 2015 11:45:42 -0600")

Rob Herring <robh@kernel.org> writes:

> On Mon, Nov 09, 2015 at 05:29:21PM +0000, Punit Agrawal wrote:
>> The dynamic power consumption of a device is proportional to the
>> square of voltage (V) and the clock frequency (f). It can be expressed as
>> 
>> Pdyn = dynamic-power-coefficient * V^2 * f.
>> 
>> The coefficient represents the running time dynamic power consumption in
>> units of mw/MHz/uVolt^2 and can be used in the above formula to
>> calculate the dynamic power in mW.
>
> I have no issue with the binding, but I wonder if a single value is 
> really sufficient to model this. Don't you also need a static
> component?

In general, power consumption does consist of the static and dynamic
power. Here we are only modelling the dynamic component.

For CPUs, we found that a single-coefficient model using frequency and
voltages gives a reasonable estimation of dynamic power consumption. For
thermal management, because of using closed loop control providing the
dynamic consumption is good enough as long as static power for your
platform is not significant.

On the other hand, there isn't a generally applicable model for static
power - it has complex relationships with temperature, voltages, etc
which make it hard to express as a simple formula. For platforms where
static power is significant, providing it via platform code is the only
option for now.

This patchset enables platforms where dynamic power works well to setup
their power model for thermal management via device tree.

>
> Rob
>
>> 
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> ---
>>  Documentation/devicetree/bindings/arm/cpus.txt | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/cpus.txt b/Documentation/devicetree/bindings/arm/cpus.txt
>> index 91e6e5c..c33362d 100644
>> --- a/Documentation/devicetree/bindings/arm/cpus.txt
>> +++ b/Documentation/devicetree/bindings/arm/cpus.txt
>> @@ -240,6 +240,23 @@ nodes to be present and contain the properties described below.
>>  		Definition: Specifies the syscon node controlling the cpu core
>>  			    power domains.
>>  
>> +	- dynamic-power-coefficient
>> +		Usage: optional
>> +		Value type: <prop-encoded-array>
>> +		Definition: A u32 value that represents the running time dynamic
>> +			    power coefficient in units of mW/MHz/uVolt^2. The
>> +			    coefficient can either be calculated from power
>> +			    measurements or derived by analysis.
>> +
>> +			    The dynamic power consumption of the CPU  is
>> +			    proportional to the square of the Voltage (V) and
>> +			    the clock frequency (f). The coefficient is used to
>> +			    calculate the dynamic power as below -
>> +
>> +			    Pdyn = dynamic-power-coefficient * V^2 * f
>> +
>> +			    where voltage is in uV, frequency is in MHz.
>> +
>>  Example 1 (dual-cluster big.LITTLE system 32-bit):
>>  
>>  	cpus {
>> -- 
>> 2.5.3
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-11-09 18:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 17:29 [PATCH v3 0/3] Dynamic power model from device tree Punit Agrawal
2015-11-09 17:29 ` [PATCH v3 1/3] devicetree: bindings: Add optional dynamic-power-coefficient property Punit Agrawal
2015-11-09 17:45   ` Rob Herring
2015-11-09 18:39     ` Punit Agrawal [this message]
2015-11-09 17:29 ` [PATCH v3 2/3] cpufreq-dt: Supply power coefficient when registering cooling devices Punit Agrawal
2015-11-10 12:28   ` Javi Merino
2015-11-09 17:29 ` [PATCH v3 3/3] cpufreq: arm_big_little: Add support to register a cpufreq cooling device Punit Agrawal
2015-11-10 12:34   ` Javi Merino
2015-11-13  4:56   ` Viresh Kumar
2015-11-16 15:29     ` Punit Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9hhvb9b6mqg.fsf@e105922-lin.cambridge.arm.com \
    --to=punit.agrawal@arm.com \
    --cc=dawei.chien@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=edubezval@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®