From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f73.google.com (mail-ed1-f73.google.com [209.85.208.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C512C3BE155 for ; Thu, 11 Jun 2026 09:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781170235; cv=none; b=Wx20p6on+2zq/K+dq00A2I7Aq8QemZbJVKQjfc/thr/1ZDqkkOO7i0BL6C/sS9+WQ1GUI2KCTy/8yXqB/e7nROlGcMDGp0KL3T7fN0SyL3TyL9VZoFZNNEN8fxrhEeer1zPPtTeCMwURLr3ULGQRPQ2cP4AmCgCgKAu0CMuZkeo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781170235; c=relaxed/simple; bh=uB2fIDFpQzC327cXcDrAAb6lpn5t+rUglT1IKTwypJ0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=K0s0gIKENWA6ltTg7GTUoG8nGr8QZ4vKZ02KE+LiHV/8+T/eRO45QPEx+1JZySMA5SAaGQWFLDPslsO0LeyC6Q3AuGdNWddAQLc5DJGkSAK6K7m3AXQL52BjEMh9BpNPWfG63RdPEaJxMK2wQLGaYAp2pA8ccLLrSGK3CF3UgEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=wYlBW1Fa; arc=none smtp.client-ip=209.85.208.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="wYlBW1Fa" Received: by mail-ed1-f73.google.com with SMTP id 4fb4d7f45d1cf-68b479cb98bso8327271a12.1 for ; Thu, 11 Jun 2026 02:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1781170229; x=1781775029; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MaX7x21+nHDjl6ZC8E7UHL0betYQU1IeZDqIxfjL42A=; b=wYlBW1FatpP1BVAqyhBdi6NZuV+dGYtS8xOPi+572f6PJ1spN4hPZW9nkTk7zsJjut LaIT/ObjaksqWdcgcJBzbZyh/YKim1UKQuTeu865Yjomsao663kHFDKO6tqL9KwC6kFo 0ka+s6rs40/Zq5ZF6ME7M5CDxk3XJE8JEbsarZesk4Tql/T3vvWIAYDEat/tH0l16OhV /CnhzNakrgmhcBU6Q0fNtvVNuLqn4/Hf/p9SZvGrrVShI2HpkCGj05R2QJ1sLOYR3ysr UnNHZzVmudJgBP9QxQI2nfhDsRzOe7TkdmkerE6XBuyflV+pajKrhcEaxSQp5OhcTKIB w/7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781170229; x=1781775029; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MaX7x21+nHDjl6ZC8E7UHL0betYQU1IeZDqIxfjL42A=; b=XGzKmCjY3leTOlfj2uQ4h7jfVv6dGaWRoV1CfcA7TFbJS2zhlSPizm+v6KV685wqoB IOfFu5SzWwtr7q9mgn9g/jUp2rZMlB1eNwP0BDEGjk3fxwyYPewPRiPmY2w3M86lvWNz xa7EBVembqWCPh2OK33b1sf/0qnP1PKvWgNJUUfT1yHJeK4dsmE8J+x1i9rnWMeffSEt lGmZmTPQKhlA/kH9cj+XTWSuKX24w+ABfqEzqYHu8QYTVUV4YDawaorEXNqKe9e61kZ3 SREDWcHboXuBj0C196d6WmvsQyrSyB3TRvArSkfa4S58pAj5V+2USSDgEgZx7lZpeAiU ynBg== X-Forwarded-Encrypted: i=1; AFNElJ9eEKo612aNp82M3D/9EbBpRl6rvOK2UpIuXV/CD+cKG8z3BeOj2ZHmnNMHudVl4gqGVBH1RK76L00GS88=@vger.kernel.org X-Gm-Message-State: AOJu0YzwdMBCMgm2sFqZIWRo8R6skQT4ZTKSSRzMT0aObJ2nQFwAXEKV jKO4UPdlpZgqYeKzF+1t8O9qRBSv43JrogStoGU+tZAVnbPDNcRJIil0ElT7hpbRUdBxYpsqED+ g/qCXv5gdap3VZnfK+A== X-Received: from edvi16.prod.google.com ([2002:aa7:dd10:0:b0:68d:63b5:c714]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:e0e:b0:68c:dbd5:a6ee with SMTP id 4fb4d7f45d1cf-6930e2e93c4mr874570a12.25.1781170228404; Thu, 11 Jun 2026 02:30:28 -0700 (PDT) Date: Thu, 11 Jun 2026 09:30:27 +0000 In-Reply-To: <2vxzfr2vso9b.fsf@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <074445fc4964961f12171ea129f2a7690322a78a.1780944056.git.tarunsahu@google.com> <2vxzfr2vso9b.fsf@kernel.org> Message-ID: <9huz1pedv2z0.fsf@tarunix.c.googlers.com> Subject: Re: [PATCH] liveupdate: Document that retrieve failure is permanent From: tarunsahu@google.com To: Pratyush Yadav Cc: Pasha Tatashin , Mike Rapoport , Pratyush Yadav , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, vipinsh@google.com Content-Type: text/plain; charset="UTF-8" Pratyush Yadav writes: > On Mon, Jun 08 2026, Tarun Sahu wrote: > >> Signed-off-by: Tarun Sahu >> --- >> include/uapi/linux/liveupdate.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/liveupdate.h b/include/uapi/linux/liveupdate.h >> index 30bc66ee9436..a564d2bd05c1 100644 >> --- a/include/uapi/linux/liveupdate.h >> +++ b/include/uapi/linux/liveupdate.h >> @@ -168,7 +168,8 @@ struct liveupdate_session_preserve_fd { >> * associated with the token and populates the @fd field with a new file >> * descriptor referencing the restored resource in the current (new) kernel. >> * This operation must be performed *before* signaling completion via >> - * %LIVEUPDATE_IOCTL_FINISH. >> + * %LIVEUPDATE_IOCTL_FINISH. Once retrieve call is failed, retrieve status >> + * is saved. So it is permanent failure and retry is pointless. > > Perhaps the wording below is slightly better from a user perspective? > > If a retrieve of a token fails, subsequent attempts to retrieve the > token fail with the same error code. Failed retrieves are not > retried. Updated! > >> * >> * Return: 0 on success, negative error code on failure (e.g., invalid token). >> */ >> >> base-commit: 2d3090a8aeb596a26935db0955d46c9a5db5c6ce >> prerequisite-patch-id: 30753743cdfab5c3c5355ecde725b6648f1b7a17 > > -- > Regards, > Pratyush Yadav