From: tarunsahu@google.com
To: Russell King <linux@armlinux.org.uk>,
Geoff Levand <geoff@infradead.org>,
Masakazu Mokuno <mokuno@sm.sony.co.jp>,
"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@ozlabs.org>,
helgaas@kernel.org, Nicholas Piggin <npiggin@gmail.com>,
sourabhjain@linux.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 0/3] Convert manual kfree(dev) to put_device()
Date: Thu, 17 Sep 2026 21:07:59 +0000 [thread overview]
Message-ID: <9huzse37io28.fsf@tarunix.c.googlers.com> (raw)
In-Reply-To: <20260904171610.3342398-1-tarunsahu@google.com>
Hello, This is the gentle remind for picking up this series.
Please, let me know if it needs any improvements.
~Tarun
Tarun Sahu <tarunsahu@google.com> writes:
> Hello,
>
> As per the kernel-doc guidelines, Devices that are tried to register
> with device_register or to add using device_add, must use put_device
> on their failure path (not kfree). This series contains 3 patches
> for updating such instances. Same for kobject_init_and_add or
> kobject_add, call kobject_put instead of kfree in case of error.
>
> V4 <- V3
> 1. Added Fixes tags
> 2. update commit msg as per the suggestion on v3
>
> V3 <- V2
> 1. Updated the commit msg of each patch to mention about the kernel-doc
> guidelines.
>
> V2 <- V1
> 1. Removed patch [1] as it is part of another series [2] already.
>
> [1]: https://lore.kernel.org/all/20260810162814.1398016-4-tarunsahu@google.com/
> [2]: https://lore.kernel.org/all/20260724171945.2812749-5-shubhrajyoti.datta@amd.com/
>
> Tarun Sahu (3):
> ARM: locomo: Fix device reference leak on registration failure
> firmware: edd: Fix kobject reference leak on registration failure
> powerpc/ps3: use put_device() on device_register() failure in
> ps3_system_bus_device_register
>
> arch/arm/common/locomo.c | 13 ++--
> arch/powerpc/platforms/ps3/device-init.c | 83 ++++++++++++++----------
> arch/powerpc/platforms/ps3/system-bus.c | 2 +
> drivers/firmware/edd.c | 2 +-
> 4 files changed, 59 insertions(+), 41 deletions(-)
>
>
> base-commit: cee9395acd8043be0644b25c34bfa86623f2b935
> --
> 2.55.0.979.g7e5102b832-goog
prev parent reply other threads:[~2026-09-17 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 17:16 Tarun Sahu
2026-09-04 17:16 ` [PATCH v4 1/3] ARM: locomo: Fix device reference leak on registration failure Tarun Sahu
2026-09-04 17:16 ` [PATCH v4 2/3] firmware: edd: Fix kobject " Tarun Sahu
2026-09-04 17:16 ` [PATCH v4 3/3] powerpc/ps3: use put_device() on device_register() failure in ps3_system_bus_device_register Tarun Sahu
2026-09-17 21:07 ` tarunsahu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9huzse37io28.fsf@tarunix.c.googlers.com \
--to=tarunsahu@google.com \
--cc=chleroy@kernel.org \
--cc=geoff@infradead.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mokuno@sm.sony.co.jp \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulus@ozlabs.org \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®